mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-14 04:49:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

zig: prefer .jsUndefined() over .undefined for JSValue (#20332)

Browse Source
This commit is contained in:
Meghan Denny
2025-06-12 12:18:46 -08:00
committed by GitHub
parent d6590c4bfa
commit dedd433cbf
84 changed files with 569 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/napi/napi.zig
View File

@@ -674,7 +674,7 @@ pub export fn napi_make_callback(env_: napi_env, _: *anyopaque, recv_: napi_valu
if (recv != .zero)
recv
else
.undefined,
.jsUndefined(),
if (arg_count > 0 and args != null)
@as([*]const JSC.JSValue, @ptrCast(args.?))[0..arg_count]
else
@@ -1616,16 +1616,16 @@ pub const ThreadSafeFunction = struct {
switch (this.callback) {
.js => |strong| {
const js = strong.get() orelse .undefined;
const js: JSValue = strong.get() orelse .jsUndefined();
if (js.isEmptyOrUndefinedOrNull()) {
return;
}
_ = js.call(globalObject, .undefined, &.{}) catch |err|
_ = js.call(globalObject, .jsUndefined(), &.{}) catch |err|
globalObject.reportActiveExceptionAsUnhandled(err);
},
.c => |cb| {
const js = cb.js.get() orelse .undefined;
const js: JSValue = cb.js.get() orelse .jsUndefined();
const handle_scope = NapiHandleScope.open(env, false);
defer if (handle_scope) |scope| scope.close(env);