From e7373bbf32d56f78a63ec75966e455f1c3bb94cd Mon Sep 17 00:00:00 2001
From: Jarred Sumner <jarred@jarredsumner.com>
Date: Mon, 28 Jul 2025 19:54:14 -0700
Subject: [PATCH] when CI scripts/build.mjs is killed, also kill the processes
 it started (#21445)

### What does this PR do?

reduce number of zombie build processes that can happen in CI or when
building locally

### How did you verify your code works?
---
 scripts/build.mjs | 39 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 36 insertions(+), 3 deletions(-)

diff --git a/scripts/build.mjs b/scripts/build.mjs
index 1ad5bc577a..d1fab297b6 100755
--- a/scripts/build.mjs
+++ b/scripts/build.mjs
@@ -224,6 +224,31 @@ async function spawn(command, args, options, label) {
     ...options,
   });
 
+  let killedManually = false;
+
+  function onKill() {
+    clearOnKill();
+    if (!subprocess.killed) {
+      killedManually = true;
+      subprocess.kill?.();
+    }
+  }
+
+  function clearOnKill() {
+    process.off("beforeExit", onKill);
+    process.off("SIGINT", onKill);
+    process.off("SIGTERM", onKill);
+  }
+
+  // Kill the entire process tree so everything gets cleaned up. On Windows, job
+  // control groups make this haappen automatically so we don't need to do this
+  // on Windows.
+  if (process.platform !== "win32") {
+    process.once("beforeExit", onKill);
+    process.once("SIGINT", onKill);
+    process.once("SIGTERM", onKill);
+  }
+
   let timestamp;
   subprocess.on("spawn", () => {
     timestamp = Date.now();
@@ -253,8 +278,14 @@ async function spawn(command, args, options, label) {
   }
 
   const { error, exitCode, signalCode } = await new Promise(resolve => {
-    subprocess.on("error", error => resolve({ error }));
-    subprocess.on("exit", (exitCode, signalCode) => resolve({ exitCode, signalCode }));
+    subprocess.on("error", error => {
+      clearOnKill();
+      resolve({ error });
+    });
+    subprocess.on("exit", (exitCode, signalCode) => {
+      clearOnKill();
+      resolve({ exitCode, signalCode });
+    });
   });
 
   if (done) {
@@ -301,7 +332,9 @@ async function spawn(command, args, options, label) {
   }
 
   if (signalCode) {
-    console.error(`Command killed: ${signalCode}`);
+    if (!killedManually) {
+      console.error(`Command killed: ${signalCode}`);
+    }
   } else {
     console.error(`Command exited: code ${exitCode}`);
   }