From ec3464ca6c2e0886ac032f85d1cb6f9df86d4828 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Fri, 22 Nov 2024 01:37:06 -0800 Subject: [PATCH] dont sigaltstack when about to use WTFReportBacktrace --- src/crash_handler.zig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/crash_handler.zig b/src/crash_handler.zig index 1bae80ccc4..7c8f41bc69 100644 --- a/src/crash_handler.zig +++ b/src/crash_handler.zig @@ -754,7 +754,9 @@ fn handleSegfaultPosix(sig: i32, info: *const std.posix.siginfo_t, _: ?*const an ); } -var did_register_sigaltstack = false; +// skip in canary since we let WTFReportBacktrace print trace +// this will make stack overflow have a slightly worse ux but its rare enough to be worth it and still unique enough to be diagnosable +var did_register_sigaltstack = bun.Environment.isRelease and bun.Environment.is_canary; var sigaltstack: [512 * 1024]u8 = undefined; pub fn updatePosixSegfaultHandler(act: ?*std.posix.Sigaction) !void {