From edeaab1cf2065ccf24a1ee11cb0bb26d34317c07 Mon Sep 17 00:00:00 2001 From: Don Isaac Date: Sun, 12 Jan 2025 20:06:10 -0800 Subject: [PATCH] fix(cli/install): `--silent` disables summary (#16321) Co-authored-by: Dylan Conway Co-authored-by: Michael H --- src/install/install.zig | 2 +- test/cli/install/bun-install-registry.test.ts | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/install/install.zig b/src/install/install.zig index 400b5a0c12..a0cb3cc60c 100644 --- a/src/install/install.zig +++ b/src/install/install.zig @@ -7567,7 +7567,7 @@ pub const PackageManager = struct { this.do.save_lockfile = false; } - if (cli.no_summary) { + if (cli.no_summary or cli.silent) { this.do.summary = false; } diff --git a/test/cli/install/bun-install-registry.test.ts b/test/cli/install/bun-install-registry.test.ts index 99a3089e50..8a97ed54f6 100644 --- a/test/cli/install/bun-install-registry.test.ts +++ b/test/cli/install/bun-install-registry.test.ts @@ -1970,6 +1970,25 @@ test("--lockfile-only", async () => { expect((await Bun.file(join(packageDir, "bun.lock")).text()).replaceAll(/localhost:\d+/g, "localhost:1234")).toBe( firstLockfile, ); + + // --silent works + const { + stdout, + stderr, + exited: exited2, + } = spawn({ + cmd: [bunExe(), "install", "--lockfile-only", "--silent"], + cwd: packageDir, + stdout: "pipe", + stderr: "pipe", + env, + }); + + expect(await exited2).toBe(0); + const out = await Bun.readableStreamToText(stdout); + const err = await Bun.readableStreamToText(stderr); + expect(out).toBe(""); + expect(err).toBe(""); }); describe("bundledDependencies", () => {