diff --git a/src/bun.js/bindings/ZigGlobalObject.cpp b/src/bun.js/bindings/ZigGlobalObject.cpp index 3186f135f3..78a03d935b 100644 --- a/src/bun.js/bindings/ZigGlobalObject.cpp +++ b/src/bun.js/bindings/ZigGlobalObject.cpp @@ -4328,13 +4328,6 @@ napi_env GlobalObject::makeNapiEnvForFFI() return out; } -void GlobalObject::finishNapiFinalizers() -{ - for (const auto& env : m_napiEnvs) { - env->finishFinalizers(); - } -} - extern "C" bool Bun__isNapiFinalizerQueueEmpty(const JSGlobalObject*); bool GlobalObject::hasNapiFinalizers() const diff --git a/src/bun.js/bindings/ZigGlobalObject.h b/src/bun.js/bindings/ZigGlobalObject.h index c6c1bb3f7c..d47b51ee4e 100644 --- a/src/bun.js/bindings/ZigGlobalObject.h +++ b/src/bun.js/bindings/ZigGlobalObject.h @@ -600,7 +600,6 @@ public: WTF::Vector> m_napiEnvs; napi_env makeNapiEnv(const napi_module&); napi_env makeNapiEnvForFFI(); - void finishNapiFinalizers(); bool hasNapiFinalizers() const; private: diff --git a/src/bun.js/bindings/napi.h b/src/bun.js/bindings/napi.h index 15dfd94903..a3814afce2 100644 --- a/src/bun.js/bindings/napi.h +++ b/src/bun.js/bindings/napi.h @@ -72,12 +72,6 @@ public: delete[] filename; } - void finishFinalizers() - { - m_isFinishingFinalizers = true; - m_isFinishingFinalizers = false; - } - void cleanup() { while (!m_cleanupHooks.empty()) { diff --git a/test/napi/node-napi.test.ts b/test/napi/node-napi.test.ts index 75bfcc30c3..cb4ccf25b6 100644 --- a/test/napi/node-napi.test.ts +++ b/test/napi/node-napi.test.ts @@ -34,6 +34,7 @@ const failingNodeApiTests = [ "test_threadsafe_function/test.js", "test_threadsafe_function/test_legacy_uncaught_exception.js", "test_worker_buffer_callback/test.js", + "test_worker_buffer_callback/test-free-called.js", // TODO(@heimskr) "test_make_callback_recurse/test.js", "test_buffer/test.js", "test_instance_data/test.js",