mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-15 13:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing ERR_INVALID_ARG_TYPE in 2 buffer methods (#13617)

Browse Source
This commit is contained in:
Jarred Sumner
2024-09-01 04:40:14 -07:00
committed by GitHub
parent ef4bcb314c
commit f123814d87
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/bun.js/modules/NodeBufferModule.h
View File

@@ -3,6 +3,7 @@
#include "root.h"
#include "../bindings/JSBuffer.h"
#include "ErrorCode.h"
#include "JavaScriptCore/PageCount.h"
#include "_NativeModule.h"
#include "wtf/SIMDUTF.h"
@@ -58,10 +59,9 @@ JSC_DEFINE_HOST_FUNCTION(jsBufferConstructorFunction_isUtf8,
ptr = reinterpret_cast<const char *>(impl->data());
} else {
throwVMError(
lexicalGlobalObject, throwScope,
createTypeError(lexicalGlobalObject,
"First argument must be an ArrayBufferView"_s));
Bun::throwError(lexicalGlobalObject, throwScope,
Bun::ErrorCode::ERR_INVALID_ARG_TYPE,
"First argument must be an ArrayBufferView"_s);
return JSValue::encode({});
}
@@ -115,10 +115,9 @@ JSC_DEFINE_HOST_FUNCTION(jsBufferConstructorFunction_isAscii,
ptr = reinterpret_cast<const char *>(impl->data());
} else {
throwVMError(
lexicalGlobalObject, throwScope,
createTypeError(lexicalGlobalObject,
"First argument must be an ArrayBufferView"_s));
Bun::throwError(lexicalGlobalObject, throwScope,
Bun::ErrorCode::ERR_INVALID_ARG_TYPE,
"First argument must be an ArrayBufferView"_s);
return JSValue::encode({});
}