mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-18 23:01:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

rid nearly all use of ExceptionRef in zig (#15100)

Browse Source 
Co-authored-by: nektro <nektro@users.noreply.github.com>
This commit is contained in:
Meghan Denny
2024-11-13 15:23:52 -08:00
committed by GitHub
parent ec91e91fda
commit f8979b05b1
26 changed files with 811 additions and 1932 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/bun.js/node/node_zlib_binding.zig
View File

@@ -12,7 +12,6 @@ pub fn crc32(globalThis: *JSC.JSGlobalObject, callframe: *JSC.CallFrame) callcon
const data: ZigString.Slice = blk: {
const data: JSC.JSValue = arguments[0];
var exceptionref: JSC.C.JSValueRef = null;
if (data == .zero) {
return globalThis.throwInvalidArgumentTypeValue("data", "string or an instance of Buffer, TypedArray, or DataView", .undefined);
@@ -20,16 +19,12 @@ pub fn crc32(globalThis: *JSC.JSGlobalObject, callframe: *JSC.CallFrame) callcon
if (data.isString()) {
break :blk data.asString().toSlice(globalThis, bun.default_allocator);
}
const buffer: JSC.Buffer = JSC.Buffer.fromJS(globalThis, data, &exceptionref) orelse {
const buffer: JSC.Buffer = JSC.Buffer.fromJS(globalThis, data) orelse {
const ty_str = data.jsTypeString(globalThis).toSlice(globalThis, bun.default_allocator);
defer ty_str.deinit();
globalThis.ERR_INVALID_ARG_TYPE("The \"data\" property must be an instance of Buffer, TypedArray, DataView, or ArrayBuffer. Received {s}", .{ty_str.slice()}).throw();
return .zero;
};
if (exceptionref) |ptr| {
globalThis.throwValue(JSC.JSValue.c(ptr));
return .zero;
}
break :blk ZigString.Slice.fromUTF8NeverFree(buffer.slice());
};
defer data.deinit();