From fe8b03428447739599613fbd2afd070bbd66967d Mon Sep 17 00:00:00 2001 From: Zack Radisic Date: Wed, 6 Mar 2024 12:25:12 -0800 Subject: [PATCH] fix uaf on shell IOReader --- src/shell/interpreter.zig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shell/interpreter.zig b/src/shell/interpreter.zig index f3f299b7d9..ba94cc0a1d 100644 --- a/src/shell/interpreter.zig +++ b/src/shell/interpreter.zig @@ -8719,7 +8719,8 @@ pub const Interpreter = struct { } pub fn __deinit(this: *@This()) void { - if (this.fd != bun.invalid_fd) { + // windows reader closes the file descriptor + if (this.fd != bun.invalid_fd and !bun.Environment.isWindows) { log("IOReader(0x{x}) __deinit fd={}", .{ @intFromPtr(this), this.fd }); _ = bun.sys.close(this.fd); }