Claude Bot
fde24342d9
Improve PostgreSQL unix socket path handling for custom socket files
...
Enhances the path handling logic in the PostgreSQL adapter to better support
custom socket file paths while maintaining backward compatibility.
## Current behavior (main branch)
The original code always appends `/.s.PGSQL.${port}` to any path:
```typescript
if (path && path?.indexOf("/.s.PGSQL.") === -1) {
path = `${path}/.s.PGSQL.${port}`;
}
```
Examples:
- `"/var/run/postgresql"` → `"/var/run/postgresql/.s.PGSQL.5432"` ✅ (correct)
- `"/tmp/postgres.sock"` → `"/tmp/postgres.sock/.s.PGSQL.5432"` ❌ (invalid path)
## Improved behavior
Now distinguishes between directory and file paths:
```typescript
if (path && path.indexOf("/.s.PGSQL.") === -1) {
if (path.endsWith("/") || (!path.includes(".") && !path.includes("sock"))) {
path = `${path}/.s.PGSQL.${port}`;
}
// Otherwise use path as-is
}
```
Examples:
- `"/var/run/postgresql"` → `"/var/run/postgresql/.s.PGSQL.5432"` ✅ (unchanged)
- `"/tmp/postgres.sock"` → `"/tmp/postgres.sock"` ✅ (now correct)
- `"/var/run/postgresql/"` → `"/var/run/postgresql//.s.PGSQL.5432"` ✅
## Impact
- **Maintains compatibility**: Standard directory paths work exactly as before
- **Enables custom sockets**: Users can now specify complete socket file paths
- **Related to #20729**: Improves path handling though the connection issue may have other causes
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-08-22 05:05:13 +00:00
Alistair Smith
784271f85e
SQLite in Bun.sql ( #21640 )
...
### What does this PR do?
Support sqlite in the Bun.sql API
Fixes #18951
Fixes #19701
### How did you verify your code works?
tests
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2025-08-19 23:15:53 -07:00
Ciro Spaciari
504052d9b0
fix(test) fix sql.test.ts ( #21860 )
...
### What does this PR do?
fix test to not include information that can change version to version
### How did you verify your code works?
CI
2025-08-14 12:25:16 -07:00
Alistair Smith
04883a8bdc
revert fe28e00d53.
...
This reverts commit fe28e00d53
2025-08-05 16:10:29 -07:00
Alistair Smith
fe28e00d53
feat: add Bun.SQL API with initial SQLite support
2025-08-05 16:04:11 -07:00
Ciro Spaciari
258a2a2e3a
fix(postgres) memory fix when connection fails sync ( #21616 )
...
### What does this PR do?
We should not call .deinit() after .toJS otherwise hasPendingActivity
will access invalid memory
### How did you verify your code works?
Test run it with debug build on macos or asan on and will catch it
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-04 19:41:20 -07:00
Jarred Sumner
39eccf89a8
Deflake sql.test.ts
2025-08-01 22:41:05 -07:00
Ciro Spaciari
03afe6ef28
fix(postgres) regression ( #21466 )
...
### What does this PR do?
Fix: https://github.com/oven-sh/bun/issues/21351
Relevant changes:
Fix advance to properly cleanup success and failed queries that could be
still be in the queue
Always ref before executing
Use stronger atomics for ref/deref and hasPendingActivity
Fallback when thisValue is freed/null/zero and check if vm is being
shutdown
The bug in --hot in `resolveRopeIfNeeded` Issue is not meant to be fixed
in this PR this is a fix for the postgres regression
Added assertions so this bug is easier to catch on CI
### How did you verify your code works?
Test added
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-31 16:26:35 -07:00
Meghan Denny
cc4f840e8b
test: remove accidental uses of test.only ( #20097 )
2025-07-16 23:07:23 -07:00
Alistair Smith
19a855e02b
types: Introduce SQL.Helper in Bun.sql ( #20809 )
...
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
2025-07-07 17:47:51 -07:00
Jarred Sumner
14b439a115
Fix formatters not running in CI + delete unnecessary files ( #19433 )
2025-05-08 23:22:16 -07:00
190n
71c770f3ae
fix sql.test.ts ( #19544 )
2025-05-08 18:51:32 -07:00
Ciro Spaciari
a512ad5155
fix(sql) fix flush ( #19177 )
2025-04-21 22:21:55 -07:00
Ciro Spaciari
7f948f9c3e
fix(sql) fix query parameters options ( #18194 )
2025-03-14 13:39:55 -07:00
Ciro Spaciari
caff4e6008
fix(sql) fix SQL fragments handling and expand support for helpers ( #17691 )
2025-02-25 19:46:53 -08:00
Ciro Spaciari
09ab840114
fix(sql) fix binary detection + fix custom types ( #17635 )
2025-02-24 20:07:16 -08:00
Ciro Spaciari
94e5071947
feat(sql) implement sql.file and dynamic passwords support ( #17527 )
2025-02-21 14:04:15 -08:00
Ciro Spaciari
0efc4eaf97
fix(sql) allow more than 64 columns ( #17444 )
2025-02-18 19:37:26 -08:00
Jarred Sumner
9cf9a26330
Revert "fix(sql) allow more than 64 columns" ( #17441 )
2025-02-18 13:42:59 -08:00
Ciro Spaciari
fcdddf6425
fix(sql) allow more than 64 columns ( #17419 )
2025-02-18 09:07:23 -08:00
Ciro Spaciari
99a3b01bd0
fix(sql) calling not tagged throw errors ( #17415 )
2025-02-17 13:06:27 -08:00
Ciro Spaciari
a2c64ad706
fix(sql) add prepare: false option and sql``.simple() ( #17296 )
2025-02-13 19:51:05 -08:00
Ciro Spaciari
1bb1f59b9e
fix(sql) fix fragments containing fragments + concat syntax for parameters ( #17273 )
2025-02-11 20:08:58 -08:00
Ciro Spaciari
3a231a62b4
fix(sql) fix support for binary numeric values ( #17245 )
2025-02-10 19:25:52 -08:00
Ciro Spaciari
6e887c8e45
fix(sql) fix TLS verify modes ( #17129 )
2025-02-07 23:23:05 -08:00
Ciro Spaciari
0da7025fb0
fix(sql) decode options from URI properly ( #17156 )
2025-02-07 15:43:23 -08:00
Ciro Spaciari
1fe2c3b426
feat(sql) support retrieving array values ( #17094 )
2025-02-06 02:45:05 -08:00
Jarred Sumner
0861c03b37
Fix memory leak in the SQL query string ( #17026 )
...
Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com >
2025-02-03 17:38:17 -08:00
Ciro Spaciari
00a5c4af5a
fix(sql) disable idle timeout when still processing data ( #16984 )
2025-02-02 21:27:22 -08:00
Ciro Spaciari
892764ec43
fix(sql) fix execution queue ( #16854 )
2025-01-29 23:52:19 -08:00
Ciro Spaciari
9bfd9db78b
more(sql) type fixes and tests ( #16512 )
2025-01-20 16:58:37 -08:00
Ciro Spaciari
ba930ad54a
feat(sql) transactions, savepoints, connection pooling and reserve ( #16381 )
2025-01-18 16:03:42 -08:00
Don Isaac
833b718b12
test: skip sql tests when psql binary is not installed ( #16233 )
2025-01-08 13:59:55 -08:00
Jarred Sumner
e92a487fad
Handle duplicate column names and numeric column names in Bun.sql ( #16178 )
2025-01-06 12:05:09 -08:00
Jarred Sumner
76bfceae81
Support jsonb, idle_timeout, connection_timeout, max_lifetime timeouts in bun:sql. Add onopen and onclose callbacks. Fix missing "code" property appearing in errors. Add error codes for postgres. ( #16045 )
2024-12-30 13:25:01 -08:00
Jarred Sumner
adaee07138
[Bun.sql] Support TLS ( #15217 )
...
Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com >
2024-11-18 19:38:23 -08:00
Jarred Sumner
b49f6d143e
Postgres client - more progress ( #15086 )
2024-11-11 14:40:02 -08:00
Jarred Sumner
cd6785771e
run prettier and add back format action ( #13722 )
2024-09-03 21:32:52 -07:00
Jarred Sumner
37ee951448
Add unusable postgres client behind a canary-or-debug-only feature flag ( #11920 )
...
Co-authored-by: Jarred-Sumner <Jarred-Sumner@users.noreply.github.com >
2024-07-07 09:43:48 -07:00
