Commit Graph

2 Commits

Author SHA1 Message Date
Claude Bot
8aee3cb3eb fix: Resolve LazyClassStructure assertion failure in node:sqlite constructor
## Summary
Successfully resolved the putDirectCustomAccessor assertion failure that was preventing
DatabaseSync constructor instantiation. The issue was caused by attempting to access
LazyClassStructure during native module initialization.

## Root Cause
- LazyClassStructure initialization happens after native module exports
- Accessing JSNodeSQLiteDatabaseSyncStructure() during module init caused timing conflict
- JSC's putDirectCustomAccessor assertion failed due to premature structure access

## Solution
- Implemented wrapper function pattern that defers LazyClassStructure access to runtime
- Created simple JSObject with method attachment instead of complex class structure
- Added placeholder host functions for all DatabaseSync methods (open, close, exec, prepare)

## Results
-  Module loading works: require('node:sqlite')
-  Constructor instantiation works: new DatabaseSync()
-  Method availability: db.open, db.close, db.exec, db.prepare
-  All exports present: DatabaseSync, StatementSync, constants, backup
-  No runtime crashes or assertions

## Next Steps
- Implement actual SQLite functionality in placeholder methods
- Add proper error handling and parameter validation
- Run Node.js compatibility tests

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-06 15:02:28 +00:00
Claude Bot
f3e5848549 Identify and document LazyClassStructure constructor export issue
## What was achieved
-  Fixed SyntheticModuleType enum generation by running bundle-modules.ts
-  Successfully build and load node:sqlite module with all exports
-  Module correctly exports backup, constants, DatabaseSync, StatementSync
-  Identified root cause of constructor instantiation issue

## Constructor Export Issue Analysis
- 🔍 **Root Cause**: LazyClassStructure timing conflict with native module exports
- 🔍 **Assertion**: `putDirectCustomAccessor` fails during module initialization
- 🔍 **Affects**: Both direct constructor export and wrapper function approaches
- 🔍 **Timing**: Occurs when accessing JSNodeSQLiteDatabaseSyncStructure() during module init

## Implementation Status
-  Module loading works: `require('node:sqlite')`
-  Proper API surface: DatabaseSync, StatementSync, constants, backup
-  Build system integration complete
- ⚠️ Constructor instantiation blocked by JSC assertion
- ⚠️ StatementSync properly designed to require database instance

## Files changed
- STATUS.md: Updated with detailed analysis and current status
- NodeSQLiteModule.cpp: Implemented constructor wrappers (blocked by JSC issue)
- NodeSQLiteModule.h: Updated exports to use wrapper functions
- test_*.js: Created test files to isolate the issue

## Next Steps
- Requires JSC/LazyClassStructure expert knowledge
- Alternative: Implement constructors without LazyClassStructure system
- Current workaround: Placeholders with error messages

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-06 14:30:22 +00:00