Dylan Conway
085e25d5d1
fix: protect StringOrBuffer from GC in async operations ( #25594 )
...
## Summary
- Fix use-after-free crash in async zstd compression, scrypt, and
JSTranspiler operations
- When `StringOrBuffer.fromJSMaybeAsync` is called with `is_async=true`,
the buffer's JSValue is now protected from garbage collection
- Previously, the buffer could be GC'd while a worker thread was still
accessing it, causing segfaults in zstd's `HIST_count_simple` and
similar functions
Fixes BUN-167Z
## Changes
- `fromJSMaybeAsync`: Call `protect()` on buffer when `is_async=true`
- `fromJSWithEncodingMaybeAsync`: Same protection for the early return
path
- `Scrypt`: Fix cleanup to use `deinitAndUnprotect()` for async path,
add missing `deinit()` in sync path
- `JSTranspiler`: Use new protection mechanism instead of manual
`protect()`/`unprotect()` calls
- Simplify `createOnJSThread` signatures to not return errors (OOM is
handled internally)
- Update all callers to use renamed/simplified APIs
## Test plan
- [x] Code review of all callsites to verify correct protect/unprotect
pairing
- [ ] Run existing zstd tests
- [ ] Run existing scrypt tests
- [ ] Run existing transpiler tests
🤖 Generated with [Claude Code](https://claude.com/claude-code )
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2025-12-19 17:30:26 -08:00
pfg
05d0475c6c
Update to zig 0.15.2 ( #24204 )
...
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com >
Co-authored-by: Meghan Denny <meghan@bun.com >
Co-authored-by: tayor.fish <contact@taylor.fish >
2025-11-10 14:38:26 -08:00
Jarred Sumner
e1505b7143
Use JSC::Integrity:: auditCellFully in bindings ( #22538 )
...
### What does this PR do?
### How did you verify your code works?
2025-09-10 00:31:54 -07:00
taylor.fish
437e15bae5
Replace catch bun.outOfMemory() with safer alternatives ( #22141 )
...
Replace `catch bun.outOfMemory()`, which can accidentally catch
non-OOM-related errors, with either `bun.handleOom` or a manual `catch
|err| switch (err)`.
(For internal tracking: fixes STAB-1070)
---------
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com >
2025-08-26 12:50:25 -07:00
Meghan Denny
e8d0935717
zig: delete deprecated some bun.jsc apis ( #21309 )
2025-07-23 17:10:58 -07:00
taylor.fish
07cd45deae
Refactor Zig imports and file structure (part 1) ( #21270 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-22 17:51:38 -07:00
pfg
83760fc446
Sort imports in all files ( #21119 )
...
Co-authored-by: taylor.fish <contact@taylor.fish >
2025-07-21 13:26:47 -07:00
Meghan Denny
875604a42b
safety: a lot more exception checker progress ( #20956 )
2025-07-16 00:11:19 -07:00
Meghan Denny
6c5b863530
safety: a lot more exception checker progress ( #20817 )
2025-07-10 15:34:51 -07:00
Meghan Denny
068997b529
make node:dns,net,cluster,tls exception checker clear ( #20658 )
...
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com >
2025-07-03 18:28:38 -07:00
Jarred Sumner
5a7b5ceb33
Fix several missing async context tracking callbacks ( #20759 )
...
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com >
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com >
2025-07-02 17:45:00 -07:00
Meghan Denny
6b4662ff55
zig: .jsUndefined -> .js_undefined ( #20377 )
...
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com >
2025-06-13 16:14:57 -07:00
Meghan Denny
dedd433cbf
zig: prefer .jsUndefined() over .undefined for JSValue ( #20332 )
2025-06-12 13:18:46 -07:00
Meghan Denny
284de53f26
safety: audit and add missing exception checks to JSC::constructArray+constructEmptyArray ( #20119 )
2025-05-31 20:05:02 -07:00
Jarred Sumner
3ea6133c46
CI: Remove unused top-level decls in formatter in zig ( #19879 )
...
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com >
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
2025-05-23 22:49:48 -07:00
chloe caruso
80aff24951
fix: require.extensions uses Strong instead of being clever ( #19231 )
2025-04-23 17:52:41 -07:00
Dylan Conway
7e8e559fce
Pass test-crypto-keygen-* tests ( #19040 )
...
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
Co-authored-by: Dave Caruso <me@paperdave.net >
2025-04-19 00:25:30 -07:00
chloe caruso
7d7512076b
remove more usingnamespace ( #19042 )
2025-04-17 19:04:05 -07:00
chloe caruso
4ec410e0d7
internal: make @import("bun") work in zig ( #19096 )
2025-04-17 12:32:47 -07:00
Dylan Conway
c21fca08e2
fix node:crypto hash name regression ( #18481 )
2025-03-25 20:43:41 -07:00
Dylan Conway
687a0ab5a4
node:crypto: fix test-crypto-scrypt.js (#18396 )
...
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2025-03-22 01:18:27 -07:00
Dylan Conway
a3585ff961
node:crypto: implement hkdf and hkdfSync (#18312 )
2025-03-21 01:03:01 -07:00
Dylan Conway
c820b0c5e1
node:crypto: implement generatePrime(Sync) and checkPrime(Sync) (#18268 )
2025-03-18 11:48:24 -07:00
Dylan Conway
4214cc0aaa
followup #18044 and #17850 ( #18205 )
2025-03-14 21:26:12 -07:00
Dylan Conway
ddfc8555f7
crypto: fix test-crypto-random.js ( #18044 )
...
Co-authored-by: Meghan Denny <meghan@bun.sh >
2025-03-11 18:21:20 -07:00
Dylan Conway
1a68ce05dc
Add a few passing tests for node:crypto ( #17987 )
2025-03-07 20:53:06 -08:00
Dylan Conway
48df26462d
fix test-crypto-randomuuid.js ( #17955 )
2025-03-07 17:05:17 -08:00
chloe caruso
1a6a34700f
chore: less usingnamespace, deprecate bun.C in favor of automatic translate-c ( #17830 )
2025-03-03 15:04:21 -08:00
Jarred Sumner
7242c1b670
Implement X509Certificate in node:crypto ( #16173 )
...
Co-authored-by: Jarred-Sumner <Jarred-Sumner@users.noreply.github.com >
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com >
Co-authored-by: dylan-conway <35280289+dylan-conway@users.noreply.github.com >
2025-01-17 05:24:45 -08:00
Meghan Denny
2d441d868b
zig: make throw use JSError ( #15444 )
2024-12-02 14:19:18 -08:00
Meghan Denny
663f00b62b
zig: make throwOutOfMemory use JSError ( #15413 )
2024-11-26 12:58:43 -08:00
Meghan Denny
0e3e33072b
zig: rename CallFrame.arguments to .arguments_old to free up decl name ( #15296 )
2024-11-20 16:18:56 -08:00
Meghan Denny
befb269b2d
zig: align fromJS methods to using JSError ( #15165 )
2024-11-15 22:14:18 -08:00
Meghan Denny
fdd8d35845
allow zig js host functions to return JSError ( #15120 )
2024-11-13 21:11:56 -08:00
Meghan Denny
80db770521
rework node:zlib to match internal js api and properly support async writes ( #14079 )
...
Co-authored-by: nektro <nektro@users.noreply.github.com >
2024-09-25 15:55:53 -07:00
Jarred Sumner
cd6785771e
run prettier and add back format action ( #13722 )
2024-09-03 21:32:52 -07:00
Ciro Spaciari
11d7a9d5e9
fix(randomInt) allow negatives and improve args validation ( #13527 )
2024-08-25 23:16:25 -07:00
Jarred Sumner
b0018465cc
WebKit upgrade ( #12246 )
...
Co-authored-by: Jarred-Sumner <Jarred-Sumner@users.noreply.github.com >
2024-07-01 23:27:59 -07:00
Jarred Sumner
1b8a72e724
Fixes #11703 ( #11776 )
2024-06-11 03:52:40 -07:00
Meghan Denny
c6187e3e3a
correct node:crypto.randomInt behavior and accept a callback ( #11505 )
...
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2024-06-06 18:24:26 -07:00
