Jarred Sumner
2eebcee522
Fix DevServer HMR sourcemap offset issues ( #22739 )
...
## Summary
Fixes sourcemap offset issues in DevServer HMR mode that were causing
incorrect line number mappings when debugging.
## Problem
When using DevServer with HMR enabled, sourcemap line numbers were
consistently off by one or more lines when shown in Chrome DevTools. In
some cases, they were off when shown in the terminal as well.
## Solution
### 1. Remove magic +2 offset
Removed an arbitrary "+2" that was added to `runtime.line_count` in
SourceMapStore.zig. The comment said "magic fairy in my dreams said it
would align the source maps" - this was causing positions to be
incorrectly offset.
### 2. Fix double-increment bug
ErrorReportRequest.zig was incorrectly adding 1 to line numbers that
were already 1-based from the browser, causing an off-by-one error.
### 3. Improve type safety
Converted all line/column handling to use `bun.Ordinal` type instead of
raw `i32`, ensuring consistent 0-based vs 1-based conversions throughout
the codebase.
## Test plan
- [x] Added comprehensive sourcemap tests for complex error scenarios
- [x] Tested with React applications in dev mode
- [x] Verified line numbers match correctly in browser dev tools
- [x] Existing sourcemap tests continue to pass
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-authored-by: Claude <noreply@anthropic.com >
2025-09-17 15:37:09 -07:00
taylor.fish
edf13bd91d
Refactor BabyList ( #22502 )
...
(For internal tracking: fixes STAB-1129, STAB-1145, STAB-1146,
STAB-1150, STAB-1126, STAB-1147, STAB-1148, STAB-1149, STAB-1158)
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-09-09 20:41:10 -07:00
taylor.fish
437e15bae5
Replace catch bun.outOfMemory() with safer alternatives ( #22141 )
...
Replace `catch bun.outOfMemory()`, which can accidentally catch
non-OOM-related errors, with either `bun.handleOom` or a manual `catch
|err| switch (err)`.
(For internal tracking: fixes STAB-1070)
---------
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com >
2025-08-26 12:50:25 -07:00
taylor.fish
41b1efe12c
Rename disabled parameter in Output.scoped ( #21769 )
...
It's very confusing.
(For internal tracking: fixes STAB-977)
2025-08-11 20:19:34 -07:00
Zack Radisic
2ed5b0ffad
Switch to bun.Ordinal for LineColumnOffset ( #21658 )
...
### What does this PR do?
It is easy to confuse `lines` and `columns` fields in `LineColumnOffset`
struct inside of `src/sourcemap/sourcemap.zig` as being either one or
zero based. The sourcemap spec says line and column offsets are zero
based. There was a place that was incorrectly assuming it was one based.
This PR switches it to use `bun.Ordinal` instead of bare `u32` integers
to prevent bugs and from this happening again.
2025-08-07 16:43:27 -07:00
Jarred Sumner
80c46b1607
Disable findSourceMap when --enable-source-maps is not passed ( #21478 )
...
### What does this PR do?
Fixes the error printed:
```js
❯ bun --bun dev
$ next dev --turbopack
▲ Next.js 15.4.5 (Turbopack)
- Local: http://localhost:3000
- Network: http://192.168.1.250:3000
✓ Starting...
✓ Ready in 637ms
○ Compiling / ...
✓ Compiled / in 1280ms
/private/tmp/empty/my-app/.next/server/chunks/ssr/[root-of-the-server]__012ba519._.js: Invalid source map. Only conformant source maps can be used to filter stack frames. Cause: TypeError: payload is not an Object. (evaluating '"sections" in payload')
/private/tmp/empty/my-app/.next/server/chunks/ssr/[root-of-the-server]__93bf7db5._.js: Invalid source map. Only conformant source maps can be used to filter stack frames. Cause: TypeError: payload is not an Object. (evaluating '"sections" in payload')
GET / 200 in 1416ms
^C^[[A
```
### How did you verify your code works?
2025-07-30 00:09:42 -07:00
Jarred Sumner
93f92658b3
Try mimalloc v3 ( #17378 )
...
(For internal tracking: fixes ENG-19852)
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com >
Co-authored-by: Kai Tamkun <kai@tamkun.io >
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: taylor.fish <contact@taylor.fish >
2025-07-29 18:07:15 -07:00
taylor.fish
07cd45deae
Refactor Zig imports and file structure (part 1) ( #21270 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-22 17:51:38 -07:00
pfg
83760fc446
Sort imports in all files ( #21119 )
...
Co-authored-by: taylor.fish <contact@taylor.fish >
2025-07-21 13:26:47 -07:00
Zack Radisic
f4339df16b
SSG stuff ( #20998 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2025-07-20 22:37:50 -07:00
Zack Radisic
ac61b1d471
Use better function names for bun.String ( #20999 )
2025-07-12 18:19:16 -07:00
Meghan Denny
6c5b863530
safety: a lot more exception checker progress ( #20817 )
2025-07-10 15:34:51 -07:00
Dylan Conway
f24e8cb98a
implement "nodeLinker": "isolated" in bun install ( #20440 )
...
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2025-07-09 00:19:57 -07:00
Jarred Sumner
454316ffc3
Implement "node:module"'s findSourceMap and SourceMap class ( #20863 )
...
Co-authored-by: Claude <claude@anthropic.ai >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com >
2025-07-07 23:08:12 -07:00
Zack Radisic
0b9bab34d8
SSG ( #20745 )
...
Co-authored-by: Alistair Smith <hi@alistair.sh >
2025-07-02 20:06:43 -07:00
Jarred Sumner
498186764a
Remove a memcpy ( #20261 )
...
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com >
2025-06-08 05:07:09 -07:00
Jarred Sumner
3ea6133c46
CI: Remove unused top-level decls in formatter in zig ( #19879 )
...
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com >
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
2025-05-23 22:49:48 -07:00
chloe caruso
4ec410e0d7
internal: make @import("bun") work in zig ( #19096 )
2025-04-17 12:32:47 -07:00
chloe caruso
c1dc5f1b73
remove some usingnamespaces ( #18765 )
2025-04-10 14:16:30 -07:00
Jarred Sumner
4806e84cc1
Revert "remove many usingnamespace, introduce new ref count and ref leak debugging tools ( #18353 )"
...
This reverts commit a199b85f2b . It does not compile on Windows.
2025-04-01 08:35:51 -07:00
chloe caruso
a199b85f2b
remove many usingnamespace, introduce new ref count and ref leak debugging tools ( #18353 )
2025-03-31 17:17:38 -07:00
Jarred Sumner
cef38030df
Micro-optimize sourcemaps ( #17757 )
...
Co-authored-by: chloe caruso <git@paperclover.net >
2025-02-27 16:25:49 -08:00
chloe caruso
cbeffe1b48
hmr7 ( #17641 )
2025-02-24 20:02:38 -08:00
chloe caruso
b082572dcb
DevServer: source map and error modal improvements ( #17476 )
2025-02-20 16:40:57 -08:00
Don Isaac
32c17d8656
fix: memory leak in code coverage ( #17399 )
2025-02-17 03:42:01 -08:00
chloe caruso
2b97d61deb
chore: remove some trivial usage of usingnamespace ( #17268 )
2025-02-11 19:38:52 -08:00
chloe caruso
f912e0abc4
hot module reloading for HTML import development mode ( #16955 )
2025-02-08 00:31:30 -08:00
Meghan Denny
26d3688e53
zig: update to 0.14.0-dev ( #16862 )
...
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com >
2025-02-01 01:11:02 -08:00
Jarred Sumner
ccb094b7a8
Fix under-reporting memory usage for strings ( #16737 )
2025-01-24 20:45:34 -08:00
dave caruso
8aa451c2dc
bake(dev): plugins in dev server, with other fixes ( #15467 )
...
Co-authored-by: paperdave <paperdave@users.noreply.github.com >
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2024-11-29 19:07:56 -08:00
Meghan Denny
663f00b62b
zig: make throwOutOfMemory use JSError ( #15413 )
2024-11-26 12:58:43 -08:00
pfg
56f7c8887b
Fix unicode imports, unicode-escaped variable names, and printClauseAlias not working for utf-8 ( #15009 )
2024-11-11 13:27:42 -08:00
Jarred Sumner
c77fc5daa0
Implement --drop ( #14492 )
...
Co-authored-by: dave caruso <me@paperdave.net >
2024-10-11 20:52:23 -07:00
Dylan Conway
f374ae6db1
add bun publish ( #14215 )
2024-10-02 20:47:22 -07:00
snwy
af12ff104a
fix utf8 handling when importing json ( #14168 )
2024-09-25 17:50:11 -07:00
Félix C. Morency
5650ed470c
fix: lcov non-hit executable lines reporting ( #13633 )
2024-08-30 16:08:23 -07:00
dave caruso
2680deb5d3
feat: bun build --compile --sourcemap ( #13047 )
2024-08-06 13:51:11 -07:00
dave caruso
02b589b2ce
fix a crash in remapping stacks ( #12477 )
...
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2024-07-10 16:39:05 -07:00
dave caruso
688ddbda74
feat(bundler): implement enum inlining / more constant folding ( #12144 )
...
Co-authored-by: paperdave <paperdave@users.noreply.github.com >
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
Co-authored-by: Jarred-Sumner <Jarred-Sumner@users.noreply.github.com >
2024-07-03 04:23:17 -07:00
Jarred Sumner
1a8ec98fd0
Rename code coverage reporter for console -> text ( #12054 )
2024-06-22 14:46:40 -07:00
TATSUNO “Taz” Yasuhiro
4830e2d817
Implement initial LCOV reporter (no function names support) ( #11883 )
...
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
Co-authored-by: dave caruso <me@paperdave.net >
2024-06-22 02:03:19 -07:00
dave caruso
b76376f8a6
chore: upgrade zig to 0.13.0 ( #9965 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
Co-authored-by: Grigory <grigory.orlov.set@gmail.com >
Co-authored-by: Dylan Conway <35280289+dylan-conway@users.noreply.github.com >
Co-authored-by: Meghan Denny <hello@nektro.net >
Co-authored-by: Kenta Iwasaki <63115601+lithdew@users.noreply.github.com >
Co-authored-by: John-David Dalton <john.david.dalton@gmail.com >
Co-authored-by: Dale Seo <5466341+DaleSeo@users.noreply.github.com >
Co-authored-by: Zack Radisic <56137411+zackradisic@users.noreply.github.com >
Co-authored-by: paperdave <paperdave@users.noreply.github.com >
Co-authored-by: Georgijs Vilums <georgijs.vilums@gmail.com >
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com >
2024-06-20 13:48:39 -07:00
dave caruso
e58cf69f94
feat(bundler): Add --sourcemap=linked for //# sourceMappingURL comments ( #11983 )
...
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
2024-06-20 13:46:49 -07:00
Jarred Sumner
a0032d1b5c
Replace libbase64 with simdutf ( #11982 )
2024-06-19 23:02:56 -07:00
Ciro Spaciari
1d89c5988e
refactor OOM errors ( #11540 )
2024-06-02 22:56:26 -07:00
dave caruso
18bba0dc44
revert sourcemap-related logging change ( #11510 )
2024-05-31 23:26:43 -07:00
dave caruso
0a5fa2dd8c
fix sourcemap printing with multiple chunks sharing the same file ( #11509 )
2024-05-31 23:10:02 -07:00
dave caruso
96f29e8555
fix(bundler): some sourcemap generation bugs ( #11344 )
...
Co-authored-by: paperdave <paperdave@users.noreply.github.com >
Co-authored-by: Meghan Denny <meghan@bun.sh >
Co-authored-by: nektro <nektro@users.noreply.github.com >
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com >
Co-authored-by: Le Michel <95184938+Ptitet@users.noreply.github.com >
Co-authored-by: Дмитрий Заводской <zawodskoj2@gmail.com >
Co-authored-by: Dylan Conway <35280289+dylan-conway@users.noreply.github.com >
Co-authored-by: HUMORCE <humorce@outlook.com >
Co-authored-by: huseeiin <122984423+huseeiin@users.noreply.github.com >
2024-05-28 16:51:35 -07:00
dave caruso
ec082db67c
fix: fix sourcemap generation (rewrites bun.StringJoiner) ( #11288 )
2024-05-23 23:30:11 -07:00
Meghan Denny
ecb6c810c8
replace [bun.MAX_PATH_BYTES]u8 with bun.PathBuffer ( #11162 )
2024-05-21 15:55:49 -07:00