mirror of
https://github.com/oven-sh/bun
synced 2026-02-10 02:48:50 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
375 lines
11 KiB
Zig
375 lines
11 KiB
Zig
pub fn OptionalChild(comptime T: type) type {
|
|
const tyinfo = @typeInfo(T);
|
|
if (tyinfo != .pointer) @compileError("OptionalChild(T) requires that T be a pointer to an optional type.");
|
|
const child = @typeInfo(tyinfo.pointer.child);
|
|
if (child != .Optional) @compileError("OptionalChild(T) requires that T be a pointer to an optional type.");
|
|
return child.Optional.child;
|
|
}
|
|
|
|
pub fn EnumFields(comptime T: type) []const std.builtin.Type.EnumField {
|
|
const tyinfo = @typeInfo(T);
|
|
return switch (tyinfo) {
|
|
.@"union" => std.meta.fields(tyinfo.@"union".tag_type.?),
|
|
.@"enum" => tyinfo.@"enum".fields,
|
|
else => {
|
|
@compileError("Used `EnumFields(T)` on a type that is not an `enum` or a `union(enum)`");
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn ReturnOfMaybe(comptime function: anytype) type {
|
|
const Func = @TypeOf(function);
|
|
const typeinfo: std.builtin.Type.Fn = @typeInfo(Func).@"fn";
|
|
const MaybeType = typeinfo.return_type orelse @compileError("Expected the function to have a return type");
|
|
return MaybeResult(MaybeType);
|
|
}
|
|
|
|
pub fn MaybeResult(comptime MaybeType: type) type {
|
|
const maybe_ty_info = @typeInfo(MaybeType);
|
|
|
|
const maybe = maybe_ty_info.@"union";
|
|
if (maybe.fields.len != 2) @compileError("Expected the Maybe type to be a union(enum) with two variants");
|
|
|
|
if (!std.mem.eql(u8, maybe.fields[0].name, "err")) {
|
|
@compileError("Expected the first field of the Maybe type to be \"err\", got: " ++ maybe.fields[0].name);
|
|
}
|
|
|
|
if (!std.mem.eql(u8, maybe.fields[1].name, "result")) {
|
|
@compileError("Expected the second field of the Maybe type to be \"result\"" ++ maybe.fields[1].name);
|
|
}
|
|
|
|
return maybe.fields[1].type;
|
|
}
|
|
|
|
pub fn ReturnOf(comptime function: anytype) type {
|
|
return ReturnOfType(@TypeOf(function));
|
|
}
|
|
|
|
pub fn ReturnOfType(comptime Type: type) type {
|
|
const typeinfo: std.builtin.Type.Fn = @typeInfo(Type).@"fn";
|
|
return typeinfo.return_type orelse void;
|
|
}
|
|
|
|
pub fn typeName(comptime Type: type) []const u8 {
|
|
const name = @typeName(Type);
|
|
return typeBaseName(name);
|
|
}
|
|
|
|
/// partially emulates behaviour of @typeName in previous Zig versions,
|
|
/// converting "some.namespace.MyType" to "MyType"
|
|
pub inline fn typeBaseName(comptime fullname: [:0]const u8) [:0]const u8 {
|
|
@setEvalBranchQuota(1_000_000);
|
|
// leave type name like "namespace.WrapperType(namespace.MyType)" as it is
|
|
const baseidx = comptime std.mem.indexOf(u8, fullname, "(");
|
|
if (baseidx != null) return comptime fullname;
|
|
|
|
const idx = comptime std.mem.lastIndexOf(u8, fullname, ".");
|
|
|
|
const name = if (idx == null) fullname else fullname[(idx.? + 1)..];
|
|
return comptime name;
|
|
}
|
|
|
|
pub fn enumFieldNames(comptime Type: type) []const []const u8 {
|
|
var names: [std.meta.fields(Type).len][]const u8 = std.meta.fieldNames(Type).*;
|
|
var i: usize = 0;
|
|
for (names) |name| {
|
|
// zig seems to include "_" or an empty string in the list of enum field names
|
|
// it makes sense, but humans don't want that
|
|
if (bun.strings.eqlAnyComptime(name, &.{ "_none", "", "_" })) {
|
|
continue;
|
|
}
|
|
names[i] = name;
|
|
i += 1;
|
|
}
|
|
return names[0..i];
|
|
}
|
|
|
|
pub fn banFieldType(comptime Container: type, comptime T: type) void {
|
|
comptime {
|
|
for (std.meta.fields(Container)) |field| {
|
|
if (field.type == T) {
|
|
@compileError(std.fmt.comptimePrint(typeName(T) ++ " field \"" ++ field.name ++ "\" not allowed in " ++ typeName(Container), .{}));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// []T -> T
|
|
// *const T -> T
|
|
// *[n]T -> T
|
|
pub fn Item(comptime T: type) type {
|
|
switch (@typeInfo(T)) {
|
|
.pointer => |ptr| {
|
|
if (ptr.size == .one) {
|
|
switch (@typeInfo(ptr.child)) {
|
|
.array => |array| {
|
|
return array.child;
|
|
},
|
|
else => {},
|
|
}
|
|
}
|
|
return ptr.child;
|
|
},
|
|
else => return std.meta.Child(T),
|
|
}
|
|
}
|
|
|
|
/// Returns .{a, ...args_}
|
|
pub fn ConcatArgs1(
|
|
comptime func: anytype,
|
|
a: anytype,
|
|
args_: anytype,
|
|
) std.meta.ArgsTuple(@TypeOf(func)) {
|
|
var args: std.meta.ArgsTuple(@TypeOf(func)) = undefined;
|
|
args[0] = a;
|
|
|
|
inline for (args_, 1..) |arg, i| {
|
|
args[i] = arg;
|
|
}
|
|
|
|
return args;
|
|
}
|
|
|
|
/// Returns .{a, b, ...args_}
|
|
pub inline fn ConcatArgs2(
|
|
comptime func: anytype,
|
|
a: anytype,
|
|
b: anytype,
|
|
args_: anytype,
|
|
) std.meta.ArgsTuple(@TypeOf(func)) {
|
|
var args: std.meta.ArgsTuple(@TypeOf(func)) = undefined;
|
|
args[0] = a;
|
|
args[1] = b;
|
|
|
|
inline for (args_, 2..) |arg, i| {
|
|
args[i] = arg;
|
|
}
|
|
|
|
return args;
|
|
}
|
|
|
|
/// Returns .{a, b, c, d, ...args_}
|
|
pub inline fn ConcatArgs4(
|
|
comptime func: anytype,
|
|
a: anytype,
|
|
b: anytype,
|
|
c: anytype,
|
|
d: anytype,
|
|
args_: anytype,
|
|
) std.meta.ArgsTuple(@TypeOf(func)) {
|
|
var args: std.meta.ArgsTuple(@TypeOf(func)) = undefined;
|
|
args[0] = a;
|
|
args[1] = b;
|
|
args[2] = c;
|
|
args[3] = d;
|
|
|
|
inline for (args_, 4..) |arg, i| {
|
|
args[i] = arg;
|
|
}
|
|
|
|
return args;
|
|
}
|
|
|
|
// Copied from std.meta
|
|
fn CreateUniqueTuple(comptime N: comptime_int, comptime types: [N]type) type {
|
|
var tuple_fields: [types.len]std.builtin.Type.StructField = undefined;
|
|
inline for (types, 0..) |T, i| {
|
|
@setEvalBranchQuota(10_000);
|
|
var num_buf: [128]u8 = undefined;
|
|
tuple_fields[i] = .{
|
|
.name = std.fmt.bufPrintZ(&num_buf, "{d}", .{i}) catch unreachable,
|
|
.type = T,
|
|
.default_value_ptr = null,
|
|
.is_comptime = false,
|
|
.alignment = if (@sizeOf(T) > 0) @alignOf(T) else 0,
|
|
};
|
|
}
|
|
|
|
return @Type(.{
|
|
.@"struct" = .{
|
|
.is_tuple = true,
|
|
.layout = .auto,
|
|
.decls = &.{},
|
|
.fields = &tuple_fields,
|
|
},
|
|
});
|
|
}
|
|
|
|
pub const TaggedUnion = @import("./meta/tagged_union.zig").TaggedUnion;
|
|
|
|
pub fn hasStableMemoryLayout(comptime T: type) bool {
|
|
const tyinfo = @typeInfo(T);
|
|
return switch (tyinfo) {
|
|
.Type => true,
|
|
.Void => true,
|
|
.Bool => true,
|
|
.Int => true,
|
|
.Float => true,
|
|
.@"enum" => {
|
|
// not supporting this rn
|
|
if (tyinfo.@"enum".is_exhaustive) return false;
|
|
return hasStableMemoryLayout(tyinfo.@"enum".tag_type);
|
|
},
|
|
.@"struct" => switch (tyinfo.@"struct".layout) {
|
|
.auto => {
|
|
inline for (tyinfo.@"struct".fields) |field| {
|
|
if (!hasStableMemoryLayout(field.field_type)) return false;
|
|
}
|
|
return true;
|
|
},
|
|
.@"extern" => true,
|
|
.@"packed" => false,
|
|
},
|
|
.@"union" => switch (tyinfo.@"union".layout) {
|
|
.auto => {
|
|
if (tyinfo.@"union".tag_type == null or !hasStableMemoryLayout(tyinfo.@"union".tag_type.?)) return false;
|
|
|
|
inline for (tyinfo.@"union".fields) |field| {
|
|
if (!hasStableMemoryLayout(field.type)) return false;
|
|
}
|
|
|
|
return true;
|
|
},
|
|
.@"extern" => true,
|
|
.@"packed" => false,
|
|
},
|
|
else => true,
|
|
};
|
|
}
|
|
|
|
pub fn isSimpleCopyType(comptime T: type) bool {
|
|
@setEvalBranchQuota(1_000_000);
|
|
const tyinfo = @typeInfo(T);
|
|
return switch (tyinfo) {
|
|
.void => true,
|
|
.bool => true,
|
|
.int => true,
|
|
.float => true,
|
|
.@"enum" => true,
|
|
.@"struct" => {
|
|
inline for (tyinfo.@"struct".fields) |field| {
|
|
if (!isSimpleCopyType(field.type)) return false;
|
|
}
|
|
return true;
|
|
},
|
|
.@"union" => {
|
|
inline for (tyinfo.@"union".fields) |field| {
|
|
if (!isSimpleCopyType(field.type)) return false;
|
|
}
|
|
return true;
|
|
},
|
|
.optional => return isSimpleCopyType(tyinfo.optional.child),
|
|
else => false,
|
|
};
|
|
}
|
|
|
|
pub fn isScalar(comptime T: type) bool {
|
|
return switch (T) {
|
|
i32, u32, i64, u64, f32, f64, bool => true,
|
|
else => {
|
|
const tyinfo = @typeInfo(T);
|
|
if (tyinfo == .@"enum") return true;
|
|
return false;
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn isSimpleEqlType(comptime T: type) bool {
|
|
const tyinfo = @typeInfo(T);
|
|
return switch (tyinfo) {
|
|
.type => true,
|
|
.void => true,
|
|
.bool => true,
|
|
.int => true,
|
|
.float => true,
|
|
.@"enum" => true,
|
|
.@"struct" => |struct_info| struct_info.layout == .@"packed",
|
|
else => false,
|
|
};
|
|
}
|
|
|
|
pub const ListContainerType = enum {
|
|
array_list,
|
|
baby_list,
|
|
small_list,
|
|
};
|
|
pub fn looksLikeListContainerType(comptime T: type) ?struct { list: ListContainerType, child: type } {
|
|
const tyinfo = @typeInfo(T);
|
|
if (tyinfo == .@"struct") {
|
|
const fields = tyinfo.@"struct".fields;
|
|
|
|
// Looks like array list
|
|
if (fields.len == 2 and
|
|
std.mem.eql(u8, fields[0].name, "items") and
|
|
std.mem.eql(u8, fields[1].name, "capacity"))
|
|
return .{ .list = .array_list, .child = std.meta.Child(fields[0].type) };
|
|
|
|
// Looks like babylist
|
|
if (@hasDecl(T, "looksLikeContainerTypeBabyList")) {
|
|
return .{ .list = .baby_list, .child = T.looksLikeContainerTypeBabyList };
|
|
}
|
|
|
|
// Looks like SmallList
|
|
if (@hasDecl(T, "looksLikeContainerTypeSmallList")) {
|
|
return .{ .list = .small_list, .child = T.looksLikeContainerTypeSmallList };
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
pub fn Tagged(comptime U: type, comptime T: type) type {
|
|
var info: std.builtin.Type.Union = @typeInfo(U).@"union";
|
|
info.tag_type = T;
|
|
info.decls = &.{};
|
|
info.layout = .auto;
|
|
return @Type(.{ .@"union" = info });
|
|
}
|
|
|
|
pub fn SliceChild(comptime T: type) type {
|
|
const tyinfo = @typeInfo(T);
|
|
if (tyinfo == .pointer and tyinfo.pointer.size == .slice) {
|
|
return tyinfo.pointer.child;
|
|
}
|
|
return T;
|
|
}
|
|
|
|
/// userland implementation of https://github.com/ziglang/zig/issues/21879
|
|
pub fn useAllFields(comptime T: type, _: VoidFields(T)) void {}
|
|
|
|
fn VoidFields(comptime T: type) type {
|
|
const fields = @typeInfo(T).@"struct".fields;
|
|
var new_fields = fields[0..fields.len].*;
|
|
for (&new_fields) |*field| {
|
|
field.type = void;
|
|
field.default_value_ptr = null;
|
|
}
|
|
return @Type(.{ .@"struct" = .{
|
|
.layout = .auto,
|
|
.fields = &new_fields,
|
|
.decls = &.{},
|
|
.is_tuple = false,
|
|
} });
|
|
}
|
|
|
|
pub fn voidFieldTypeDiscardHelper(data: anytype) void {
|
|
_ = data;
|
|
}
|
|
|
|
pub fn hasDecl(comptime T: type, comptime name: []const u8) bool {
|
|
return switch (@typeInfo(T)) {
|
|
.@"struct", .@"union", .@"enum", .@"opaque" => @hasDecl(T, name),
|
|
else => false,
|
|
};
|
|
}
|
|
|
|
pub fn hasField(comptime T: type, comptime name: []const u8) bool {
|
|
return switch (@typeInfo(T)) {
|
|
.@"struct", .@"union", .@"enum" => @hasField(T, name),
|
|
else => false,
|
|
};
|
|
}
|
|
|
|
const bun = @import("bun");
|
|
const std = @import("std");
|