mirror of
https://github.com/oven-sh/bun
synced 2026-02-02 15:08:46 +00:00
2b7fc18092
## Summary Fixes all oxlint `no-unused-expressions` violations across the codebase by: - Adding an oxlint override to disable the rule for `src/js/builtins/**`, where special syntax markers like `$getter`, `$constructor`, etc. are intentionally used as standalone expressions - Converting short-circuit expressions (`condition && fn()`) to proper if statements for improved code clarity - Wrapping intentional property access side effects (e.g., `this.stdio;`, `err.stack;`) with the `void` operator - Converting ternary expressions used for control flow to if/else statements ## Test plan - [x] `bun lint` passes with no errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
90 lines
2.6 KiB
JSON
90 lines
2.6 KiB
JSON
{
|
|
"$schema": "https://raw.githubusercontent.com/oxc-project/oxc/refs/heads/main/npm/oxlint/configuration_schema.json",
|
|
"categories": {
|
|
"correctness": "error"
|
|
},
|
|
"rules": {
|
|
"const-comparisons": "error",
|
|
"no-cond-assign": "error",
|
|
"no-const-assign": "error",
|
|
"no-debugger": "error",
|
|
"no-dupe-class-members": "error",
|
|
"no-dupe-keys": "error",
|
|
"no-empty-pattern": "error",
|
|
"import/no-duplicates": "error",
|
|
|
|
"no-control-regex": "off",
|
|
|
|
"no-useless-escape": "off",
|
|
"no-this-alias": "off", // many intentional this aliases
|
|
"triple-slash-reference": "off", // many intentional triple slash references
|
|
|
|
// This rule is dumb.
|
|
// Array.from is MUCH slower than new Array(size).
|
|
"no-new-array": "off",
|
|
|
|
// We have custom thenables. This is not a bug.
|
|
"no-thenable": "off",
|
|
|
|
"no-undef-init": "error",
|
|
|
|
// We use this in some cases. The ordering is deliberate.
|
|
"no-unsafe-finally": "off",
|
|
|
|
// We use !!$debug to check if the debugger is enabled.
|
|
// Boolean() is also generally slower than !!.
|
|
"no-extra-boolean-cast": "off",
|
|
|
|
// Eslint is not a type checker.
|
|
"no-throw-literal": "off"
|
|
},
|
|
"ignorePatterns": [
|
|
"vendor",
|
|
"build",
|
|
"bench",
|
|
"bench/react-hello-world/*.js",
|
|
"bun.lock",
|
|
|
|
"test/js/node/**/parallel/**",
|
|
"test/js/node/test/fixtures", // full of JS with intentional syntax errors
|
|
"test/snippets/**",
|
|
"test/regression/issue/14477/*.tsx",
|
|
"test/js/**/*bad.js",
|
|
"test/bundler/transpiler/decorators.test.ts", // uses `arguments` as decorator
|
|
"test/bundler/native-plugin.test.ts", // parser doesn't handle import metadata
|
|
"test/bundler/transpiler/with-statement-works.js", // parser doesn't allow `with` statement
|
|
"test/js/node/module/extensions-fixture", // these files are not meant to be linted
|
|
"test/cli/run/module-type-fixture",
|
|
"test/bundler/transpiler/with-statement-works.js", // parser doesn't allow `with` statement
|
|
|
|
// TODO: fix these
|
|
"src/js/node/http2.ts",
|
|
"src/js/node/http.ts"
|
|
],
|
|
|
|
"overrides": [
|
|
{
|
|
"files": ["test/**", "examples/**", "packages/bun-internal/test/runners/**"],
|
|
"rules": {
|
|
"no-unused-vars": "off",
|
|
"no-unused-private-class-members": "off",
|
|
"no-unnecessary-await": "off"
|
|
}
|
|
},
|
|
{
|
|
"files": ["test/**", "bench/**"],
|
|
"rules": {
|
|
"no-shadow-restricted-names": "off",
|
|
"no-empty-file": "off",
|
|
"no-unnecessary-await": "off"
|
|
}
|
|
},
|
|
{
|
|
"files": ["src/js/builtins/**"],
|
|
"rules": {
|
|
"no-unused-expressions": "off"
|
|
}
|
|
}
|
|
]
|
|
}
|