Files
bun.sh/test
Claude Bot 91d061de25 Fix JSX transform not respecting NODE_ENV=production (#23959)
## Summary

Fixes a bug where `Bun.build` would use development JSX transforms (`jsxDEV` from `react/jsx-dev-runtime`) even when `NODE_ENV=production` was set, instead of using production JSX transforms (`jsx` from `react/jsx-runtime`).

## Root Causes

1. **Missing force_node_env flag for production**: When `NODE_ENV=production` was set, the transpiler set `jsx.development = false` but did not set `force_node_env = .production`. This meant that later code couldn't distinguish between "production due to NODE_ENV" vs "default settings", causing tsconfig jsx settings to incorrectly override NODE_ENV.

2. **Incorrect RuntimeMap for react-jsx**: The `RuntimeMap` mapped `"react-jsx"` (production mode) to `.development = true`, which is incorrect. It should map to `.development = false`.

3. **Wrong fallback in bundle_v2**: When `force_node_env` was `.unspecified`, the bundler used the global `transpiler.options.jsx.development` instead of the per-module `task.jsx.development` which includes tsconfig settings.

## Changes

1. **src/transpiler.zig**: Set `force_node_env = .production` when `NODE_ENV=production` is detected, matching the behavior for `NODE_ENV=development`.

2. **src/options.zig**: Fix RuntimeMap to correctly map `"react-jsx"` to `.development = false` (production mode) instead of `.development = true`.

3. **src/bundler/bundle_v2.zig**: When `force_node_env` is `.unspecified`, use `task.jsx.development` (which includes per-module tsconfig settings) instead of the global `transpiler.options.jsx.development`.

## Configuration Priority

The correct priority is now enforced:
1. `NODE_ENV=production/development` (highest - overrides all)
2. `--production` flag (sets NODE_ENV internally)
3. tsconfig.json `compilerOptions.jsx` (lowest - default fallback)

## Test Plan

Added comprehensive regression tests in `test/regression/issue/23959.test.ts`:
-  `NODE_ENV=production` uses production JSX (`jsx`)
-  `NODE_ENV=development` uses development JSX (`jsxDEV`)
-  No NODE_ENV defaults to development JSX (`jsxDEV`)
-  `--production` flag uses production JSX (`jsx`)

Fixes #23959
2025-10-25 23:22:42 +00:00
..
2025-09-26 03:06:18 -07:00
2025-09-30 05:26:32 -07:00
2025-10-11 18:16:43 -07:00
2025-09-30 05:26:32 -07:00
2025-09-30 05:26:32 -07:00

Tests

Finding tests

Tests are located in the test/ directory and are organized using the following structure:

  • test/
    • js/ - tests for JavaScript APIs.
    • cli/ - tests for commands, configs, and stdout.
    • bundler/ - tests for the transpiler/bundler.
    • regression/ - tests that reproduce a specific issue.
    • harness.ts - utility functions that can be imported from any test.

The tests in test/js/ directory are further categorized by the type of API.

  • test/js/
    • bun/ - tests for Bun-specific APIs.
    • node/ - tests for Node.js APIs.
    • web/ - tests for Web APIs, like fetch().
    • first_party/ - tests for npm packages that are built-in, like undici.
    • third_party/ - tests for npm packages that are not built-in, but are popular, like esbuild.

Running tests

To run a test, use Bun's built-in test command: bun test.

bun test # Run all tests
bun test js/bun # Only run tests in a directory
bun test sqlite.test.ts # Only run a specific test

If you encounter lots of errors, try running bun install, then trying again.

Writing tests

Tests are written in TypeScript (preferred) or JavaScript using Jest's describe(), test(), and expect() APIs.

import { describe, test, expect } from "bun:test";
import { gcTick } from "harness";

describe("TextEncoder", () => {
  test("can encode a string", async () => {
    const encoder = new TextEncoder();
    const actual = encoder.encode("bun");
    await gcTick();
    expect(actual).toBe(new Uint8Array([0x62, 0x75, 0x6E]));
  });
});

If you are fixing a bug that was reported from a GitHub issue, remember to add a test in the test/regression/ directory.

// test/regression/issue/02005.test.ts

import { it, expect } from "bun:test";

it("regex literal should work with non-latin1", () => {
  const text = "这是一段要替换的文字";
  expect(text.replace(new RegExp("要替换"), "")).toBe("这是一段的文字");
  expect(text.replace(/要替换/, "")).toBe("这是一段的文字");
});

In the future, a bot will automatically close or re-open issues when a regression is detected or resolved.

Zig tests

These tests live in various .zig files throughout Bun's codebase, leveraging Zig's builtin test keyword.

Currently, they're not run automatically nor is there a simple way to run all of them. We will make this better soon.

TypeScript

Test files should be written in TypeScript. The types in packages/bun-types should be updated to support all new APIs. Changes to the .d.ts files in packages/bun-types will be immediately reflected in test files; no build step is necessary.

Writing a test will often require using invalid syntax, e.g. when checking for errors when an invalid input is passed to a function. TypeScript provides a number of escape hatches here.

  • // @ts-expect-error - This should be your first choice. It tells TypeScript that the next line should fail typechecking.
  • // @ts-ignore - Ignore the next line entirely.
  • // @ts-nocheck - Put this at the top of the file to disable typechecking on the entire file. Useful for autogenerated test files, or when ignoring/disabling type checks an a per-line basis is too onerous.