mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 18:38:55 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
237 lines
7.4 KiB
Zig
237 lines
7.4 KiB
Zig
const Global = @This();
|
|
|
|
/// Does not have the canary tag, because it is exposed in `Bun.version`
|
|
/// "1.0.0" or "1.0.0-debug"
|
|
pub const package_json_version = if (Environment.isDebug)
|
|
version_string ++ "-debug"
|
|
else
|
|
version_string;
|
|
|
|
/// This is used for `bun` without any arguments, it `package_json_version` but with canary if it is a canary build.
|
|
/// like "1.0.0-canary.12"
|
|
pub const package_json_version_with_canary = if (Environment.isDebug)
|
|
version_string ++ "-debug"
|
|
else if (Environment.is_canary)
|
|
std.fmt.comptimePrint("{s}-canary.{d}", .{ version_string, Environment.canary_revision })
|
|
else
|
|
version_string;
|
|
|
|
/// The version and a short hash in parenthesis.
|
|
pub const package_json_version_with_sha = if (Environment.git_sha.len == 0)
|
|
package_json_version
|
|
else if (Environment.isDebug)
|
|
std.fmt.comptimePrint("{s} ({s})", .{ version_string, Environment.git_sha[0..@min(Environment.git_sha.len, 8)] })
|
|
else if (Environment.is_canary)
|
|
std.fmt.comptimePrint("{s}-canary.{d} ({s})", .{ version_string, Environment.canary_revision, Environment.git_sha[0..@min(Environment.git_sha.len, 8)] })
|
|
else
|
|
std.fmt.comptimePrint("{s} ({s})", .{ version_string, Environment.git_sha[0..@min(Environment.git_sha.len, 8)] });
|
|
|
|
/// What is printed by `bun --revision`
|
|
/// "1.0.0+abcdefghi" or "1.0.0-canary.12+abcdefghi"
|
|
pub const package_json_version_with_revision = if (Environment.git_sha.len == 0)
|
|
package_json_version
|
|
else if (Environment.isDebug)
|
|
std.fmt.comptimePrint(version_string ++ "-debug+{s}", .{Environment.git_sha_short})
|
|
else if (Environment.is_canary)
|
|
std.fmt.comptimePrint(version_string ++ "-canary.{d}+{s}", .{ Environment.canary_revision, Environment.git_sha_short })
|
|
else
|
|
std.fmt.comptimePrint(version_string ++ "+{s}", .{Environment.git_sha_short});
|
|
|
|
pub const os_name = Environment.os.nameString();
|
|
|
|
// Bun v1.0.0 (Linux x64 baseline)
|
|
// Bun v1.0.0-debug (Linux x64)
|
|
// Bun v1.0.0-canary.0+44e09bb7f (Linux x64)
|
|
pub const unhandled_error_bun_version_string = "Bun v" ++
|
|
(if (Environment.is_canary) package_json_version_with_revision else package_json_version) ++
|
|
" (" ++ Environment.os.displayString() ++ " " ++ arch_name ++
|
|
(if (Environment.baseline) " baseline)" else ")");
|
|
|
|
pub const arch_name = if (Environment.isX64)
|
|
"x64"
|
|
else if (Environment.isX86)
|
|
"x86"
|
|
else if (Environment.isAarch64)
|
|
"arm64"
|
|
else
|
|
"unknown";
|
|
|
|
pub inline fn getStartTime() i128 {
|
|
return bun.start_time;
|
|
}
|
|
|
|
extern "kernel32" fn SetThreadDescription(thread: std.os.windows.HANDLE, name: [*:0]const u16) callconv(.winapi) std.os.windows.HRESULT;
|
|
|
|
pub fn setThreadName(name: [:0]const u8) void {
|
|
if (Environment.isLinux) {
|
|
_ = std.posix.prctl(.SET_NAME, .{@intFromPtr(name.ptr)}) catch 0;
|
|
} else if (Environment.isMac) {
|
|
_ = std.c.pthread_setname_np(name);
|
|
} else if (Environment.isWindows) {
|
|
// TODO: use SetThreadDescription or NtSetInformationThread with 0x26 (ThreadNameInformation)
|
|
// without causing exit code 0xC0000409 (stack buffer overrun) in child process
|
|
}
|
|
}
|
|
|
|
const ExitFn = *const fn () callconv(.c) void;
|
|
|
|
var on_exit_callbacks = std.ArrayListUnmanaged(ExitFn){};
|
|
export fn Bun__atexit(function: ExitFn) void {
|
|
if (std.mem.indexOfScalar(ExitFn, on_exit_callbacks.items, function) == null) {
|
|
on_exit_callbacks.append(bun.default_allocator, function) catch {};
|
|
}
|
|
}
|
|
|
|
pub fn addExitCallback(function: ExitFn) void {
|
|
Bun__atexit(function);
|
|
}
|
|
|
|
pub fn runExitCallbacks() void {
|
|
for (on_exit_callbacks.items) |callback| {
|
|
callback();
|
|
}
|
|
on_exit_callbacks.items.len = 0;
|
|
}
|
|
|
|
var is_exiting = std.atomic.Value(bool).init(false);
|
|
export fn bun_is_exiting() c_int {
|
|
return @intFromBool(isExiting());
|
|
}
|
|
pub fn isExiting() bool {
|
|
return is_exiting.load(.monotonic);
|
|
}
|
|
|
|
/// Flushes stdout and stderr (in exit/quick_exit callback) and exits with the given code.
|
|
pub fn exit(code: u32) noreturn {
|
|
is_exiting.store(true, .monotonic);
|
|
_ = @atomicRmw(usize, &bun.analytics.Features.exited, .Add, 1, .monotonic);
|
|
|
|
// If we are crashing, allow the crash handler to finish it's work.
|
|
bun.crash_handler.sleepForeverIfAnotherThreadIsCrashing();
|
|
|
|
if (Environment.isDebug) {
|
|
bun.assert(bun.debug_allocator_data.backing.?.deinit() == .ok);
|
|
bun.debug_allocator_data.backing = null;
|
|
}
|
|
|
|
// Flush output before exiting to ensure all messages are visible
|
|
Output.flush();
|
|
|
|
switch (Environment.os) {
|
|
.mac => std.c.exit(@bitCast(code)),
|
|
.windows => {
|
|
Bun__onExit();
|
|
std.os.windows.kernel32.ExitProcess(code);
|
|
},
|
|
else => {
|
|
if (Environment.enable_asan) {
|
|
std.c.exit(@bitCast(code));
|
|
std.c.abort(); // exit should be noreturn
|
|
}
|
|
bun.c.quick_exit(@bitCast(code));
|
|
std.c.abort(); // quick_exit should be noreturn
|
|
},
|
|
}
|
|
}
|
|
|
|
pub fn raiseIgnoringPanicHandler(sig: bun.SignalCode) noreturn {
|
|
Output.flush();
|
|
Output.Source.Stdio.restore();
|
|
|
|
// clear segfault handler
|
|
bun.crash_handler.resetSegfaultHandler();
|
|
|
|
// clear signal handler
|
|
if (bun.Environment.os != .windows) {
|
|
var sa: std.c.Sigaction = .{
|
|
.handler = .{ .handler = std.posix.SIG.DFL },
|
|
.mask = std.posix.sigemptyset(),
|
|
.flags = std.posix.SA.RESETHAND,
|
|
};
|
|
_ = std.c.sigaction(@intFromEnum(sig), &sa, null);
|
|
}
|
|
|
|
// kill self
|
|
_ = std.c.raise(@intFromEnum(sig));
|
|
std.c.abort();
|
|
}
|
|
|
|
pub const AllocatorConfiguration = struct {
|
|
verbose: bool = false,
|
|
long_running: bool = false,
|
|
};
|
|
|
|
pub inline fn mimalloc_cleanup(force: bool) void {
|
|
if (comptime use_mimalloc) {
|
|
Mimalloc.mi_collect(force);
|
|
}
|
|
}
|
|
// Versions are now handled by CMake-generated header (bun_dependency_versions.h)
|
|
|
|
// Enabling huge pages slows down bun by 8x or so
|
|
// Keeping this code for:
|
|
// 1. documentation that an attempt was made
|
|
// 2. if I want to configure allocator later
|
|
pub inline fn configureAllocator(_: AllocatorConfiguration) void {}
|
|
|
|
pub fn notimpl() noreturn {
|
|
@branchHint(.cold);
|
|
Output.panic("Not implemented yet!!!!!", .{});
|
|
}
|
|
|
|
// Make sure we always print any leftover
|
|
pub fn crash() noreturn {
|
|
@branchHint(.cold);
|
|
Global.exit(1);
|
|
}
|
|
|
|
pub const BunInfo = struct {
|
|
bun_version: string,
|
|
platform: analytics.GenerateHeader.GeneratePlatform.Platform,
|
|
|
|
const analytics = bun.analytics;
|
|
const JSON = bun.json;
|
|
const JSAst = bun.ast;
|
|
pub fn generate(comptime Bundler: type, _: Bundler, allocator: std.mem.Allocator) !JSAst.Expr {
|
|
const info = BunInfo{
|
|
.bun_version = Global.package_json_version,
|
|
.platform = analytics.GenerateHeader.GeneratePlatform.forOS(),
|
|
};
|
|
|
|
return try JSON.toAST(allocator, BunInfo, info);
|
|
}
|
|
};
|
|
|
|
pub const user_agent = "Bun/" ++ Global.package_json_version;
|
|
pub export const Bun__userAgent: [*:0]const u8 = Global.user_agent;
|
|
|
|
comptime {
|
|
_ = Bun__userAgent;
|
|
}
|
|
|
|
pub export fn Bun__onExit() void {
|
|
bun.jsc.Node.FSEvents.closeAndWait();
|
|
|
|
runExitCallbacks();
|
|
Output.flush();
|
|
std.mem.doNotOptimizeAway(&Bun__atexit);
|
|
|
|
Output.Source.Stdio.restore();
|
|
}
|
|
|
|
comptime {
|
|
_ = Bun__onExit;
|
|
}
|
|
|
|
const string = []const u8;
|
|
|
|
const Output = @import("./output.zig");
|
|
const std = @import("std");
|
|
|
|
const Environment = @import("./env.zig");
|
|
const version_string = Environment.version_string;
|
|
|
|
const bun = @import("bun");
|
|
const Mimalloc = bun.mimalloc;
|
|
const use_mimalloc = bun.use_mimalloc;
|