mirror of
https://github.com/oven-sh/bun
synced 2026-02-11 03:18:53 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
308 lines
7.5 KiB
Zig
308 lines
7.5 KiB
Zig
extern "c" fn highway_char_frequency(
|
|
text: [*]const u8,
|
|
text_len: usize,
|
|
freqs: [*]i32,
|
|
delta: i32,
|
|
) void;
|
|
|
|
extern "c" fn highway_index_of_char(
|
|
haystack: [*]const u8,
|
|
haystack_len: usize,
|
|
needle: u8,
|
|
) usize;
|
|
|
|
extern "c" fn highway_index_of_interesting_character_in_string_literal(
|
|
noalias text: [*]const u8,
|
|
text_len: usize,
|
|
quote: u8,
|
|
) usize;
|
|
|
|
extern "c" fn highway_index_of_newline_or_non_ascii(
|
|
noalias haystack: [*]const u8,
|
|
haystack_len: usize,
|
|
) usize;
|
|
|
|
extern "c" fn highway_index_of_newline_or_non_ascii_or_ansi(
|
|
noalias haystack: [*]const u8,
|
|
haystack_len: usize,
|
|
) usize;
|
|
|
|
extern "c" fn highway_index_of_newline_or_non_ascii_or_hash_or_at(
|
|
noalias haystack: [*]const u8,
|
|
haystack_len: usize,
|
|
) usize;
|
|
|
|
extern "c" fn highway_index_of_space_or_newline_or_non_ascii(
|
|
noalias haystack: [*]const u8,
|
|
haystack_len: usize,
|
|
) usize;
|
|
|
|
extern "c" fn highway_contains_newline_or_non_ascii_or_quote(
|
|
noalias text: [*]const u8,
|
|
text_len: usize,
|
|
) bool;
|
|
|
|
extern "c" fn highway_index_of_needs_escape_for_javascript_string(
|
|
noalias text: [*]const u8,
|
|
text_len: usize,
|
|
quote_char: u8,
|
|
) usize;
|
|
|
|
extern "c" fn highway_index_of_any_char(
|
|
noalias text: [*]const u8,
|
|
text_len: usize,
|
|
noalias chars: [*]const u8,
|
|
chars_len: usize,
|
|
) usize;
|
|
|
|
extern "c" fn highway_fill_with_skip_mask(
|
|
mask: [*]const u8,
|
|
mask_len: usize,
|
|
output: [*]u8,
|
|
input: [*]const u8,
|
|
length: usize,
|
|
skip_mask: bool,
|
|
) void;
|
|
|
|
/// Count frequencies of [a-zA-Z0-9_$] characters in a string
|
|
/// Updates the provided frequency array with counts (adds delta for each occurrence)
|
|
pub fn scanCharFrequency(text: string, freqs: *[64]i32, delta: i32) void {
|
|
if (text.len == 0 or delta == 0) {
|
|
return;
|
|
}
|
|
|
|
highway_char_frequency(
|
|
text.ptr,
|
|
text.len,
|
|
freqs.ptr,
|
|
delta,
|
|
);
|
|
}
|
|
|
|
pub fn indexOfChar(haystack: string, needle: u8) ?usize {
|
|
if (haystack.len == 0) {
|
|
return null;
|
|
}
|
|
|
|
const result = highway_index_of_char(
|
|
haystack.ptr,
|
|
haystack.len,
|
|
needle,
|
|
);
|
|
|
|
if (result == haystack.len) {
|
|
return null;
|
|
}
|
|
|
|
bun.debugAssert(haystack[result] == needle);
|
|
|
|
return result;
|
|
}
|
|
|
|
pub fn indexOfInterestingCharacterInStringLiteral(slice: string, quote_type: u8) ?usize {
|
|
if (slice.len == 0) {
|
|
return null;
|
|
}
|
|
|
|
const result = highway_index_of_interesting_character_in_string_literal(
|
|
slice.ptr,
|
|
slice.len,
|
|
quote_type,
|
|
);
|
|
|
|
if (result == slice.len) {
|
|
return null;
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
pub fn indexOfNewlineOrNonASCII(haystack: string) ?usize {
|
|
bun.debugAssert(haystack.len > 0);
|
|
|
|
const result = highway_index_of_newline_or_non_ascii(
|
|
haystack.ptr,
|
|
haystack.len,
|
|
);
|
|
|
|
if (result == haystack.len) {
|
|
return null;
|
|
}
|
|
if (comptime Environment.isDebug) {
|
|
const haystack_char = haystack[result];
|
|
if (!(haystack_char > 127 or haystack_char < 0x20 or haystack_char == '\r' or haystack_char == '\n')) {
|
|
@panic("Invalid character found in indexOfNewlineOrNonASCII");
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
pub fn indexOfNewlineOrNonASCIIOrANSI(haystack: string) ?usize {
|
|
bun.debugAssert(haystack.len > 0);
|
|
|
|
const result = highway_index_of_newline_or_non_ascii_or_ansi(
|
|
haystack.ptr,
|
|
haystack.len,
|
|
);
|
|
|
|
if (result == haystack.len) {
|
|
return null;
|
|
}
|
|
if (comptime Environment.isDebug) {
|
|
const haystack_char = haystack[result];
|
|
if (!(haystack_char > 127 or haystack_char < 0x20 or haystack_char == '\r' or haystack_char == '\n')) {
|
|
@panic("Invalid character found in indexOfNewlineOrNonASCIIOrANSI");
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
/// Checks if the string contains any newlines, non-ASCII characters, or quotes
|
|
pub fn containsNewlineOrNonASCIIOrQuote(text: string) bool {
|
|
if (text.len == 0) {
|
|
return false;
|
|
}
|
|
|
|
return highway_contains_newline_or_non_ascii_or_quote(
|
|
text.ptr,
|
|
text.len,
|
|
);
|
|
}
|
|
|
|
/// Finds the first character that needs escaping in a JavaScript string
|
|
/// Looks for characters above ASCII (> 127), control characters (< 0x20),
|
|
/// backslash characters (`\`), the quote character itself, and for backtick
|
|
/// strings also the dollar sign (`$`)
|
|
pub fn indexOfNeedsEscapeForJavaScriptString(slice: string, quote_char: u8) ?u32 {
|
|
if (slice.len == 0) {
|
|
return null;
|
|
}
|
|
|
|
const result = highway_index_of_needs_escape_for_javascript_string(
|
|
slice.ptr,
|
|
slice.len,
|
|
quote_char,
|
|
);
|
|
|
|
if (result == slice.len) {
|
|
return null;
|
|
}
|
|
|
|
if (comptime Environment.isDebug) {
|
|
const haystack_char = slice[result];
|
|
if (!(haystack_char >= 127 or haystack_char < 0x20 or haystack_char == '\\' or haystack_char == quote_char or haystack_char == '$' or haystack_char == '\r' or haystack_char == '\n')) {
|
|
std.debug.panic("Invalid character found in indexOfNeedsEscapeForJavaScriptString: U+{x}. Full string: \"{f}\"", .{ haystack_char, std.zig.fmtString(slice) });
|
|
}
|
|
}
|
|
|
|
return @truncate(result);
|
|
}
|
|
|
|
pub fn indexOfAnyChar(haystack: string, chars: string) ?usize {
|
|
if (haystack.len == 0 or chars.len == 0) {
|
|
return null;
|
|
}
|
|
|
|
const result = highway_index_of_any_char(haystack.ptr, haystack.len, chars.ptr, chars.len);
|
|
|
|
if (result == haystack.len) {
|
|
return null;
|
|
}
|
|
|
|
if (comptime Environment.isDebug) {
|
|
const haystack_char = haystack[result];
|
|
var found = false;
|
|
for (chars) |c| {
|
|
if (c == haystack_char) {
|
|
found = true;
|
|
break;
|
|
}
|
|
}
|
|
if (!found) {
|
|
@panic("Invalid character found in indexOfAnyChar");
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
extern "c" fn highway_copy_u16_to_u8(
|
|
input: [*]align(1) const u16,
|
|
count: usize,
|
|
output: [*]u8,
|
|
) void;
|
|
|
|
pub fn copyU16ToU8(input: []align(1) const u16, output: []u8) void {
|
|
highway_copy_u16_to_u8(input.ptr, input.len, output.ptr);
|
|
}
|
|
|
|
/// Apply a WebSocket mask to data using SIMD acceleration
|
|
/// If skip_mask is true, data is copied without masking
|
|
pub fn fillWithSkipMask(mask: [4]u8, output: []u8, input: []const u8, skip_mask: bool) void {
|
|
if (input.len == 0) {
|
|
return;
|
|
}
|
|
|
|
highway_fill_with_skip_mask(
|
|
&mask,
|
|
4,
|
|
output.ptr,
|
|
input.ptr,
|
|
input.len,
|
|
skip_mask,
|
|
);
|
|
}
|
|
|
|
/// Useful for single-line JavaScript comments.
|
|
/// Scans for:
|
|
/// - `\n`, `\r`
|
|
/// - Non-ASCII characters (which implicitly include `\n`, `\r`)
|
|
/// - `#`
|
|
/// - `@`
|
|
pub fn indexOfNewlineOrNonASCIIOrHashOrAt(haystack: string) ?usize {
|
|
if (haystack.len == 0) {
|
|
return null;
|
|
}
|
|
|
|
const result = highway_index_of_newline_or_non_ascii_or_hash_or_at(
|
|
haystack.ptr,
|
|
haystack.len,
|
|
);
|
|
|
|
if (result == haystack.len) {
|
|
return null;
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
/// Scans for:
|
|
/// - " "
|
|
/// - Non-ASCII characters (which implicitly include `\n`, `\r`, '\t')
|
|
pub fn indexOfSpaceOrNewlineOrNonASCII(haystack: string) ?usize {
|
|
if (haystack.len == 0) {
|
|
return null;
|
|
}
|
|
|
|
const result = highway_index_of_space_or_newline_or_non_ascii(
|
|
haystack.ptr,
|
|
haystack.len,
|
|
);
|
|
|
|
if (result == haystack.len) {
|
|
return null;
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
const string = []const u8;
|
|
|
|
const std = @import("std");
|
|
|
|
const bun = @import("bun");
|
|
const Environment = bun.Environment;
|
|
const strings = bun.strings;
|