robobun 9907c2e9fa fix(patch): add bounds checking to prevent segfault during patch application (#21939) ...

## Summary

- Fixes segmentation fault when applying patches with out-of-bounds line
numbers
- Adds comprehensive bounds checking in patch application logic
- Includes regression tests to prevent future issues

## Problem

Previously, malformed patches with line numbers beyond file bounds could
cause segmentation faults by attempting to access memory beyond
allocated array bounds in `addManyAt()` and `replaceRange()` calls.

## Solution

Added bounds validation at four key points in `src/patch.zig`:

1. **Hunk start position validation** (line 283-286) - Ensures hunk
starts within file bounds
2. **Context line validation** (line 294-297) - Validates context lines
exist within bounds
3. **Insertion position validation** (line 302-305) - Checks insertion
position is valid
4. **Deletion range validation** (line 317-320) - Ensures deletion range
is within bounds

All bounds violations now return `EINVAL` error gracefully instead of
crashing.

## Test Coverage

Added comprehensive regression tests in
`test/regression/issue/patch-bounds-check.test.ts`:

- ✅ Out-of-bounds insertion attempts
- ✅ Out-of-bounds deletion attempts  
- ✅ Out-of-bounds context line validation
- ✅ Valid patch application (positive test case)

Tests verify that `bun install` completes gracefully when encountering
malformed patches, with no crashes or memory corruption.

## Test Results

```
bun test v1.2.21
✅ Bounds checking working: bun install completed gracefully despite malformed patch
✅ Bounds checking working: bun install completed gracefully despite deletion beyond bounds
✅ Bounds checking working: bun install completed gracefully despite context lines beyond bounds

 4 pass
 0 fail
 22 expect() calls
Ran 4 tests across 1 file. [4.70s]
```

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: Zack Radisic <56137411+zackradisic@users.noreply.github.com>

2025-09-12 23:44:48 -07:00

..

__snapshots__

fix: CSS parser crashes with calc() NaN values and system colors in color-mix() (#21079)

2025-07-15 22:02:03 -07:00

02499

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

03844

framework api: init / work in progress (#13215)

2024-09-12 16:44:03 -07:00

04298

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

06946

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07500

Fix ReadFileUV not reading to the end of a non-regular file on Windows (#13900)

2024-09-11 17:33:01 -07:00

07917

Fix fetch with formdata on some servers (#16947)

2025-01-31 22:39:43 -08:00

08964

pm: print command name to stdout (#14266)

2024-10-02 02:24:37 -07:00

08965

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

09041

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

09563

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

10380

Update bun:test diff (#21158)

2025-08-06 06:44:46 -07:00

11297

Rewrite internal Web Streams to use less memory (#16860)

2025-02-15 01:16:28 -08:00

12034

Fix Jest globals not being available in non-entrypoint files (#17734)

2025-02-26 16:02:15 -08:00

12910

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

14477

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

14976

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

14982

Use ReadableStream.prototype.* in tests instead of new Response(...).* (#20937)

2025-07-14 00:47:53 -07:00

16476

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

16702

Regression test for 16702 (#16853)

2025-01-28 17:23:57 -08:00

17454

Fix hosting destructured decl with movable initializer (#17468)

2025-02-19 20:21:52 -08:00

18159

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

18239

Fixes #18239 (#20152)

2025-06-03 13:23:12 -07:00

19850

fix nonsense test name and elapsed time when beforeEach callback has thrown (#21118)

2025-07-17 02:02:57 -07:00

20144

Add test for #20144 (#20171)

2025-06-03 23:41:37 -07:00

napi-exception-pending-crash

fix: napi_is_exception_pending crash during cleanup (#21961)

2025-08-18 16:47:45 -07:00

246-child_process_object_assign_compatibility.test.ts

Fix child_process stdio properties not enumerable for Object.assign() compatibility (#22322)

2025-09-06 01:40:36 -07:00

5228.test.js

Implement xit/xtest/xdescribe aliases (#21529)

2025-08-25 17:37:12 -07:00

00631.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

01466.test.ts

Fix AES-GCM encryption of empty messages (#13646)

2024-08-31 02:29:16 -07:00

02005.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

02367.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

02368.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

02369.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

03091.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

03216.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

03830.test.ts

Fix expect toMatchSnapshot not working for some strings (#15183)

2024-11-21 17:46:45 -08:00

04011.test.ts

Get Bun.write tests to pass on Windows and bun:sqlite tests to pass (#8393)

2024-01-23 20:03:56 -08:00

04893.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

04947.test.js

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

06443.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

06467.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07001.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07261.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07263.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07324.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07397.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07736.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07740.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

07827.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

08040.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

08093.test.ts

Use ReadableStream.prototype.* in tests instead of new Response(...).* (#20937)

2025-07-14 00:47:53 -07:00

08095.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

08757.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

08794.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

09041.test.ts

Use ReadableStream.prototype.* in tests instead of new Response(...).* (#20937)

2025-07-14 00:47:53 -07:00

09279.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

09340.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

09469.test.ts

Return expected data when using Promises with crypto.generateKeyPair (#13600)

2024-08-30 20:14:47 -07:00

09555.test.ts

feat: new binding generator (#15638)

2024-12-10 12:43:17 -08:00

09559.test.ts

feat: new binding generator (#15638)

2024-12-10 12:43:17 -08:00

09739.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

09748.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

09778.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

10132.test.ts

Fix bun run folder (#15117)

2025-01-17 22:08:07 -08:00

10139.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

10170.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

10887.test.ts

fix segfault when decorating computed property #10887 (#14304)

2024-10-04 18:14:20 -07:00

11029-crypto-verify-null-algorithm.test.ts

Fix crypto.verify() with null/undefined algorithm for RSA keys (#22331)

2025-09-02 23:30:52 -07:00

11664.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

11677.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

11806.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

11866.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

11866.ts

Fixes #11866 (#11867)

2024-06-14 01:50:36 -07:00

12548.test.ts

Fix TypeScript syntax not working with 'ts' loader in BunPlugin (#22460)

2025-09-07 21:43:38 -07:00

12650.test.js

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

14029.test.ts

bun run prettier (#14153)

2024-09-24 22:46:18 -07:00

14338.test.ts

Fix WebSocket to emit error event before close on handshake failure (#22325)

2025-09-02 03:26:51 -07:00

14515.test.tsx

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

14945-lifecycle-script-crash.test.ts

fix(install): handle lifecycle script spawn failures gracefully instead of crashing (#21054)

2025-07-14 20:50:32 -07:00

15276.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

15314.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

15326.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

16007.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

16312.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

16474.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

17327.test.ts

Fix extra bracket in template literal syntax highlighting (#17327) (#21187)

2025-07-20 23:38:24 -07:00

17605.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

17766.test.ts

upgrade webkit (#17889)

2025-03-03 21:38:05 -08:00

18413-all-compressions.test.ts

fix: handle empty chunked gzip responses correctly (#22360)

2025-09-03 18:57:39 -07:00

18413-deflate-semantics.test.ts

fix: handle empty chunked gzip responses correctly (#22360)

2025-09-03 18:57:39 -07:00

18413-truncation.test.ts

fix: handle empty chunked gzip responses correctly (#22360)

2025-09-03 18:57:39 -07:00

18413.test.ts

fix: handle empty chunked gzip responses correctly (#22360)

2025-09-03 18:57:39 -07:00

18547.test.ts

perf_hooks.Histogram (#19920)

2025-05-26 21:18:22 -07:00

18595.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

18820.test.ts

Add clearAllMocks to mock. (#21555)

2025-08-01 19:30:51 -07:00

19107.test.ts

Fix expect(() => { throw undefined; }).toThrow(TypeError) (#21637)

2025-08-06 06:39:25 -07:00

19219.test.ts

Fix HTMLRewriter error handling (issue #19219) (#22326)

2025-09-02 01:59:06 -07:00

19661.test.ts

ReadableStream & ReadableByteStream fixes (#19683)

2025-05-16 22:30:58 -07:00

20321.test.ts

Fix spawnSync crash when stdio is set to process.stderr (#22329)

2025-09-02 03:26:25 -07:00

20753.test.js

Fixes #20753 (#20789)

2025-07-03 01:06:22 -07:00

21274.test.ts

fixes #21274 (#21278)

2025-07-23 22:31:42 -07:00

21311.test.ts

Fix: Make SQL connection string parsing more sensible (#22260)

2025-09-08 20:59:24 -07:00

21677.test.ts

fix: prevent duplicate Date headers in HTTP responses (#21677) (#21836)

2025-08-14 16:34:38 -07:00

21680.test.ts

fix: HTMLRewriter no longer crashes when element handlers throw exceptions (#21848)

2025-08-15 22:35:38 -07:00

21792.test.ts

fix(serve): correct TLS array validation for SNI (#21796)

2025-08-15 21:25:54 -07:00

21907.test.ts

Fix CSS parser crash with large floating-point values (#21907) (#21909)

2025-08-15 20:59:50 -07:00

22157.test.ts

Fix argv handling for standalone binaries - remove extra executable name (#22157) (#22169)

2025-08-27 15:31:28 -07:00

22475.test.ts

Fix cookie.isExpired() returning false for Unix epoch (#22478)

2025-09-07 17:42:09 -07:00

22481.test.ts

Fix: Socket.write() fails with Uint8Array (#22482)

2025-09-08 14:12:00 -07:00

012039.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

012040.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

012360.test.ts

run prettier and add back format action (#13722)

2024-09-03 21:32:52 -07:00

013880-fixture.cjs

Fix several bugs when printing exceptions from Error.captureStackTrace (#14548)

2024-10-14 13:43:06 -07:00

013880.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

014187.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

014865.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

015201.test.ts

Fix setTimeout with node:util.promisify (#15230)

2024-11-18 19:29:55 -08:00

abort-controller-fixture.js

Fixes #9739 (#9752)

2024-03-30 20:57:40 -07:00

bundler-plugin-onresolve-entrypoint.test.ts

fix: support virtual entrypoints in onResolve() (#22144)

2025-08-26 16:51:41 -07:00

comma-operator-this-binding.test.ts

Fix comma operator optimization to preserve 'this' binding semantics (#21653)

2025-08-09 05:11:50 -07:00

compile-outfile-subdirs.test.ts

Fix Windows compilation issues with embedded resources and relative paths (#22365)

2025-09-04 18:17:14 -07:00

crypto-names.test.ts

Fix formatters not running in CI + delete unnecessary files (#19433)

2025-05-08 23:22:16 -07:00

css-system-color-contexts.test.ts

fix: CSS parser crashes with calc() NaN values and system colors in color-mix() (#21079)

2025-07-15 22:02:03 -07:00

css-system-color-mix-crash.test.ts

fix: CSS parser crashes with calc() NaN values and system colors in color-mix() (#21079)

2025-07-15 22:02:03 -07:00

ctrl-c.test.ts

feat: support Svelte in bundler and dev server (#17735)

2025-03-04 14:16:18 -08:00

cyclic-imports-async-bundler.test.js

Fix bundler cyclic imports with async dependencies (#21423)

2025-07-28 00:09:16 -07:00

hashbang-still-works.test.ts

Fix bounds check in lexer for single # character (#21341)

2025-07-25 13:59:33 -07:00

htmlrewriter-additional-bugs.test.ts

fix: HTMLRewriter no longer crashes when element handlers throw exceptions (#21848)

2025-08-15 22:35:38 -07:00

issue-1825-jest-mock-functions.test.ts

Fix missing Jest mock functions in bun:test (#22306)

2025-09-02 01:53:39 -07:00

issue-12276.test.ts

Fix toIncludeRepeated (#21366)

2025-07-25 22:22:04 -07:00

jsx-template-string-crash.test.ts

Fix panic in JavaScript lexer when parsing invalid template strings in JSX (#21967)

2025-08-19 18:47:04 -07:00

malformed-integrity-base64.test.ts

fix(install): prevent base64 integrity parsing panic on oversized input (#21936)

2025-08-18 03:04:37 -07:00

napi-exception-pending-crash.test.ts

fix: napi_is_exception_pending crash during cleanup (#21961)

2025-08-18 16:47:45 -07:00

patch-bounds-check.test.ts

fix(patch): add bounds checking to prevent segfault during patch application (#21939)

2025-09-12 23:44:48 -07:00

pe-codesigning-integrity.test.ts

Add Windows PE codesigning support for standalone executables (#21091)

2025-07-15 22:31:54 -07:00

postgres-stringbuilder-assertion-aggressive.test.ts

Fix PostgreSQL StringBuilder assertion failure with empty error messages (#22558)

2025-09-10 18:47:50 -07:00

prepare-stack-trace-crash.test.ts

Fix issue with Error.prepareStackTrace (#21829)

2025-08-19 18:08:00 -07:00

s3-signature-order.test.ts

fix(s3): ensure correct alphabetical query parameter order in presigned URLs (#21050)

2025-07-15 16:20:34 -07:00

s3-signature-performance.test.ts

fix(s3): ensure correct alphabetical query parameter order in presigned URLs (#21050)

2025-07-15 16:20:34 -07:00

server-stop-with-pending-requests.test.ts

fix: prevent assertion failure when stopping server with pending requests (#22070)

2025-08-22 22:39:47 -07:00

test_env_loader_threading.test.ts

Fix env_loader allocator threading issue with BUN_INSPECT_CONNECT_TO (#22206)

2025-08-28 17:16:37 -07:00

test-21049.test.ts

Deflake test-21049.test.ts

2025-07-20 23:02:10 -07:00

test-process-stdout-async-iterator.test.ts

Fix process.stdout/stderr missing Symbol.asyncIterator (#21720)

2025-08-09 06:40:36 -07:00

text-chunk-null-access.test.ts

Fix HTMLRewriter TextChunk null pointer crash (#22254)

2025-08-30 01:05:51 -07:00

update-interactive-formatting.test.ts

Introduce bun update --interactive (#20850)

2025-07-17 04:33:30 -07:00

utf16-encoding-crash.test.ts

Fix UTF-16 encoding crash with odd-length byte arrays (#21966)

2025-08-20 00:02:14 -07:00