mirror of
https://github.com/oven-sh/bun
synced 2026-02-02 15:08:46 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
170 lines
5.8 KiB
Zig
170 lines
5.8 KiB
Zig
pub const SignalCode = enum(u8) {
|
|
SIGHUP = 1,
|
|
SIGINT = 2,
|
|
SIGQUIT = 3,
|
|
SIGILL = 4,
|
|
SIGTRAP = 5,
|
|
SIGABRT = 6,
|
|
SIGBUS = 7,
|
|
SIGFPE = 8,
|
|
SIGKILL = 9,
|
|
SIGUSR1 = 10,
|
|
SIGSEGV = 11,
|
|
SIGUSR2 = 12,
|
|
SIGPIPE = 13,
|
|
SIGALRM = 14,
|
|
SIGTERM = 15,
|
|
SIG16 = 16,
|
|
SIGCHLD = 17,
|
|
SIGCONT = 18,
|
|
SIGSTOP = 19,
|
|
SIGTSTP = 20,
|
|
SIGTTIN = 21,
|
|
SIGTTOU = 22,
|
|
SIGURG = 23,
|
|
SIGXCPU = 24,
|
|
SIGXFSZ = 25,
|
|
SIGVTALRM = 26,
|
|
SIGPROF = 27,
|
|
SIGWINCH = 28,
|
|
SIGIO = 29,
|
|
SIGPWR = 30,
|
|
SIGSYS = 31,
|
|
_,
|
|
|
|
// The `subprocess.kill()` method sends a signal to the child process. If no
|
|
// argument is given, the process will be sent the 'SIGTERM' signal.
|
|
pub const default = SignalCode.SIGTERM;
|
|
pub const Map = ComptimeEnumMap(SignalCode);
|
|
pub fn name(value: SignalCode) ?[]const u8 {
|
|
if (@intFromEnum(value) <= @intFromEnum(SignalCode.SIGSYS)) {
|
|
return asByteSlice(@tagName(value));
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
pub fn valid(value: SignalCode) bool {
|
|
return @intFromEnum(value) <= @intFromEnum(SignalCode.SIGSYS) and @intFromEnum(value) >= @intFromEnum(SignalCode.SIGHUP);
|
|
}
|
|
|
|
/// Shell scripts use exit codes 128 + signal number
|
|
/// https://tldp.org/LDP/abs/html/exitcodes.html
|
|
pub fn toExitCode(value: SignalCode) ?u8 {
|
|
return switch (@intFromEnum(value)) {
|
|
1...31 => 128 +% @intFromEnum(value),
|
|
else => null,
|
|
};
|
|
}
|
|
|
|
pub fn description(signal: SignalCode) ?[]const u8 {
|
|
// Description names copied from fish
|
|
// https://github.com/fish-shell/fish-shell/blob/00ffc397b493f67e28f18640d3de808af29b1434/fish-rust/src/signal.rs#L420
|
|
return switch (signal) {
|
|
.SIGHUP => "Terminal hung up",
|
|
.SIGINT => "Quit request",
|
|
.SIGQUIT => "Quit request",
|
|
.SIGILL => "Illegal instruction",
|
|
.SIGTRAP => "Trace or breakpoint trap",
|
|
.SIGABRT => "Abort",
|
|
.SIGBUS => "Misaligned address error",
|
|
.SIGFPE => "Floating point exception",
|
|
.SIGKILL => "Forced quit",
|
|
.SIGUSR1 => "User defined signal 1",
|
|
.SIGUSR2 => "User defined signal 2",
|
|
.SIGSEGV => "Address boundary error",
|
|
.SIGPIPE => "Broken pipe",
|
|
.SIGALRM => "Timer expired",
|
|
.SIGTERM => "Polite quit request",
|
|
.SIGCHLD => "Child process status changed",
|
|
.SIGCONT => "Continue previously stopped process",
|
|
.SIGSTOP => "Forced stop",
|
|
.SIGTSTP => "Stop request from job control (^Z)",
|
|
.SIGTTIN => "Stop from terminal input",
|
|
.SIGTTOU => "Stop from terminal output",
|
|
.SIGURG => "Urgent socket condition",
|
|
.SIGXCPU => "CPU time limit exceeded",
|
|
.SIGXFSZ => "File size limit exceeded",
|
|
.SIGVTALRM => "Virtual timefr expired",
|
|
.SIGPROF => "Profiling timer expired",
|
|
.SIGWINCH => "Window size change",
|
|
.SIGIO => "I/O on asynchronous file descriptor is possible",
|
|
.SIGSYS => "Bad system call",
|
|
.SIGPWR => "Power failure",
|
|
else => null,
|
|
};
|
|
}
|
|
|
|
pub fn from(value: anytype) SignalCode {
|
|
return @enumFromInt(std.mem.asBytes(&value)[0]);
|
|
}
|
|
|
|
// This wrapper struct is lame, what if bun's color formatter was more versatile
|
|
const Fmt = struct {
|
|
signal: SignalCode,
|
|
enable_ansi_colors: bool,
|
|
pub fn format(this: Fmt, writer: *std.Io.Writer) !void {
|
|
const signal = this.signal;
|
|
switch (this.enable_ansi_colors) {
|
|
inline else => |enable_ansi_colors| {
|
|
if (signal.name()) |str| if (signal.description()) |desc| {
|
|
try writer.print(Output.prettyFmt("{s} <d>({s})<r>", enable_ansi_colors), .{ str, desc });
|
|
return;
|
|
};
|
|
try writer.print("code {d}", .{@intFromEnum(signal)});
|
|
},
|
|
}
|
|
}
|
|
};
|
|
|
|
pub fn fmt(signal: SignalCode, enable_ansi_colors: bool) Fmt {
|
|
return .{ .signal = signal, .enable_ansi_colors = enable_ansi_colors };
|
|
}
|
|
|
|
pub fn fromJS(arg: jsc.JSValue, globalThis: *jsc.JSGlobalObject) !SignalCode {
|
|
if (arg.getNumber()) |sig64| {
|
|
// Node does this:
|
|
if (std.math.isNan(sig64)) {
|
|
return SignalCode.default;
|
|
}
|
|
|
|
// This matches node behavior, minus some details with the error messages: https://gist.github.com/Jarred-Sumner/23ba38682bf9d84dff2f67eb35c42ab6
|
|
if (std.math.isInf(sig64) or @trunc(sig64) != sig64) {
|
|
return globalThis.throwInvalidArguments("Unknown signal", .{});
|
|
}
|
|
|
|
if (sig64 < 0) {
|
|
return globalThis.throwInvalidArguments("Invalid signal: must be >= 0", .{});
|
|
}
|
|
|
|
if (sig64 > 31) {
|
|
return globalThis.throwInvalidArguments("Invalid signal: must be < 32", .{});
|
|
}
|
|
|
|
const code: SignalCode = @enumFromInt(@as(u8, @intFromFloat(sig64)));
|
|
return code;
|
|
} else if (arg.isString()) {
|
|
if (arg.asString().length() == 0) {
|
|
return SignalCode.default;
|
|
}
|
|
const signal_code = try arg.toEnum(globalThis, "signal", SignalCode);
|
|
return signal_code;
|
|
} else if (!arg.isEmptyOrUndefinedOrNull()) {
|
|
return globalThis.throwInvalidArguments("Invalid signal: must be a string or an integer", .{});
|
|
}
|
|
|
|
return SignalCode.default;
|
|
}
|
|
};
|
|
|
|
const std = @import("std");
|
|
|
|
const bun = @import("bun");
|
|
const ComptimeEnumMap = bun.ComptimeEnumMap;
|
|
const Output = bun.Output;
|
|
const asByteSlice = bun.asByteSlice;
|
|
|
|
const jsc = bun.jsc;
|
|
const JSGlobalObject = jsc.JSGlobalObject;
|
|
const JSValue = jsc.JSValue;
|