mirror of
https://github.com/oven-sh/bun
synced 2026-02-16 05:42:43 +00:00
## Summary - Refactor 16 test files to use async `Bun.spawn` instead of `Bun.spawnSync` - Wrap tests in `describe.concurrent` blocks for parallel execution - Use `await using` for automatic resource cleanup ## Performance Improvement | Test File | Before | After | Improvement | |-----------|--------|-------|-------------| | `node-module-module.test.js` (28 tests) | ~325ms | ~185ms | **43% faster** | | `non-english-import.test.js` (3 tests) | ~238ms | ~157ms | **34% faster** | ## Files Changed - `test/cli/run/commonjs-invalid.test.ts` - `test/cli/run/commonjs-no-export.test.ts` - `test/cli/run/empty-file.test.ts` - `test/cli/run/jsx-symbol-collision.test.ts` - `test/cli/run/run-cjs.test.ts` - `test/cli/run/run-extensionless.test.ts` - `test/cli/run/run-shell.test.ts` - `test/cli/run/run-unicode.test.ts` - `test/js/bun/resolve/non-english-import.test.js` - `test/js/node/module/node-module-module.test.js` - `test/regression/issue/00631.test.ts` - `test/regression/issue/03216.test.ts` - `test/regression/issue/03830.test.ts` - `test/regression/issue/04011.test.ts` - `test/regression/issue/04893.test.ts` - `test/regression/issue/hashbang-still-works.test.ts` ## Test plan - [x] All refactored tests pass with `USE_SYSTEM_BUN=1 bun test <file>` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com>
103 lines
3.4 KiB
JavaScript
103 lines
3.4 KiB
JavaScript
// We do not make these files imports in the codebase because non-ascii file paths can cause issues with git
|
|
// Instead, we put them into a temporary directory and run them from there
|
|
import { describe, expect, test } from "bun:test";
|
|
import { bunEnv, bunExe } from "harness";
|
|
import { mkdirSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
|
|
describe.concurrent("non-english-import", () => {
|
|
test("latin1 entry point", async () => {
|
|
const latin1Char = String.fromCharCode(0xc7);
|
|
const latin1Chars = latin1Char + latin1Char + latin1Char + latin1Char;
|
|
const prefix = join(tmpdir(), "bun-test-non-english-import-latin1");
|
|
|
|
for (let variation of [latin1Chars + "-latin1-prefix.js", "latin1-suffix-" + latin1Chars + ".js"]) {
|
|
const inputPath = join(prefix, variation);
|
|
try {
|
|
mkdirSync(prefix, { recursive: true });
|
|
} catch (e) {}
|
|
await Bun.write(inputPath, `console.log(42);`);
|
|
|
|
await using proc = Bun.spawn({
|
|
cmd: [bunExe(), "run", inputPath],
|
|
stderr: "inherit",
|
|
stdout: "pipe",
|
|
env: bunEnv,
|
|
cwd: prefix,
|
|
});
|
|
|
|
const stdout = await proc.stdout.text();
|
|
expect(stdout).toBe("42\n");
|
|
expect(await proc.exited).toBe(0);
|
|
}
|
|
});
|
|
|
|
test("utf16 entry point", async () => {
|
|
const utf16Char = "\u{1F600}";
|
|
const utf16Chars = utf16Char + utf16Char + utf16Char + utf16Char;
|
|
const prefix = join(tmpdir(), "bun-test-non-english-import-u16");
|
|
|
|
for (let variation of [utf16Chars + "-utf16-prefix.js", "utf16-suffix-" + utf16Chars + ".js"]) {
|
|
const inputPath = join(prefix, variation);
|
|
try {
|
|
mkdirSync(prefix, { recursive: true });
|
|
} catch (e) {}
|
|
await Bun.write(inputPath, `console.log(42);`);
|
|
|
|
await using proc = Bun.spawn({
|
|
cmd: [bunExe(), "run", inputPath],
|
|
stderr: "inherit",
|
|
stdout: "pipe",
|
|
env: bunEnv,
|
|
cwd: prefix,
|
|
});
|
|
|
|
const stdout = await proc.stdout.text();
|
|
expect(stdout).toBe("42\n");
|
|
expect(await proc.exited).toBe(0);
|
|
}
|
|
});
|
|
|
|
test("latin1 & utf16 imports", async () => {
|
|
const prefix = join(tmpdir(), "bun-test-non-english-import-imports");
|
|
const utf16Char = "\u{1F600}";
|
|
const utf16Chars = utf16Char + utf16Char + utf16Char + utf16Char;
|
|
const latin1Char = String.fromCharCode(0xc7);
|
|
const latin1Chars = latin1Char + latin1Char + latin1Char + latin1Char;
|
|
|
|
const imports = [];
|
|
for (let variation of [utf16Chars + "-utf16-prefix.js", "utf16-suffix-" + utf16Chars + ".js"]) {
|
|
imports.push(join(prefix, variation));
|
|
}
|
|
|
|
for (let variation of [latin1Chars + "-latin1-prefix.js", "latin1-suffix-" + latin1Chars + ".js"]) {
|
|
imports.push(join(prefix, variation));
|
|
}
|
|
|
|
const inputPath = join(prefix, "entry.js");
|
|
try {
|
|
mkdirSync(prefix, { recursive: true });
|
|
} catch (e) {}
|
|
|
|
let entryCode = imports.map(i => `import ${JSON.stringify(i)};`).join("\n");
|
|
await Bun.write(inputPath, entryCode);
|
|
|
|
for (let importPath of imports) {
|
|
await Bun.write(importPath, "console.log(42);");
|
|
}
|
|
|
|
await using proc = Bun.spawn({
|
|
cmd: [bunExe(), "run", inputPath],
|
|
stderr: "inherit",
|
|
stdout: "pipe",
|
|
env: bunEnv,
|
|
cwd: prefix,
|
|
});
|
|
|
|
const stdout = await proc.stdout.text();
|
|
expect(stdout).toBe("42\n".repeat(imports.length));
|
|
expect(await proc.exited).toBe(0);
|
|
});
|
|
});
|