mirror of
https://github.com/oven-sh/bun
synced 2026-02-12 03:48:56 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
126 lines
4.4 KiB
Zig
126 lines
4.4 KiB
Zig
pub const linux = struct {
|
|
|
|
// On linux, bun overrides the libc symbols for various functions.
|
|
// This is to compensate for older glibc versions.
|
|
|
|
fn simulateLibcErrno(rc: usize) c_int {
|
|
const signed: isize = @bitCast(rc);
|
|
const int: c_int = @intCast(if (signed > -4096 and signed < 0) -signed else 0);
|
|
std.c._errno().* = int;
|
|
return if (signed > -4096 and signed < 0) -1 else int;
|
|
}
|
|
|
|
pub export fn stat(path: [*:0]const u8, buf: *std.os.linux.Stat) c_int {
|
|
// https://git.musl-libc.org/cgit/musl/tree/src/stat/stat.c
|
|
const rc = std.os.linux.fstatat(std.os.linux.AT.FDCWD, path, buf, 0);
|
|
return simulateLibcErrno(rc);
|
|
}
|
|
|
|
pub const stat64 = stat;
|
|
pub const lstat64 = lstat;
|
|
pub const fstat64 = fstat;
|
|
pub const fstatat64 = fstatat;
|
|
|
|
pub export fn lstat(path: [*:0]const u8, buf: *std.os.linux.Stat) c_int {
|
|
// https://git.musl-libc.org/cgit/musl/tree/src/stat/lstat.c
|
|
const rc = std.os.linux.fstatat(std.os.linux.AT.FDCWD, path, buf, std.os.linux.AT.SYMLINK_NOFOLLOW);
|
|
return simulateLibcErrno(rc);
|
|
}
|
|
|
|
pub export fn fstat(fd: c_int, buf: *std.os.linux.Stat) c_int {
|
|
const rc = std.os.linux.fstat(fd, buf);
|
|
return simulateLibcErrno(rc);
|
|
}
|
|
|
|
pub export fn fstatat(dirfd: i32, path: [*:0]const u8, buf: *std.os.linux.Stat, flags: u32) c_int {
|
|
const rc = std.os.linux.fstatat(dirfd, path, buf, flags);
|
|
return simulateLibcErrno(rc);
|
|
}
|
|
|
|
pub export fn statx(dirfd: i32, path: [*:0]const u8, flags: u32, mask: u32, buf: *std.os.linux.Statx) c_int {
|
|
const rc = std.os.linux.statx(dirfd, path, flags, mask, buf);
|
|
return simulateLibcErrno(rc);
|
|
}
|
|
|
|
pub const memmem = bun.c.memmem;
|
|
|
|
comptime {
|
|
_ = stat;
|
|
_ = stat64;
|
|
_ = lstat;
|
|
_ = lstat64;
|
|
_ = fstat;
|
|
_ = fstat64;
|
|
_ = fstatat;
|
|
_ = statx;
|
|
@export(&stat, .{ .name = "stat64" });
|
|
@export(&lstat, .{ .name = "lstat64" });
|
|
@export(&fstat, .{ .name = "fstat64" });
|
|
@export(&fstatat, .{ .name = "fstatat64" });
|
|
}
|
|
};
|
|
pub const darwin = struct {
|
|
pub const memmem = bun.c.memmem;
|
|
|
|
// The symbol name depends on the arch.
|
|
|
|
pub const lstat = blk: {
|
|
const T = *const fn (?[*:0]const u8, ?*bun.Stat) callconv(.c) c_int;
|
|
break :blk @extern(T, .{ .name = if (bun.Environment.isAarch64) "lstat" else "lstat64" });
|
|
};
|
|
pub const fstat = blk: {
|
|
const T = *const fn (i32, ?*bun.Stat) callconv(.c) c_int;
|
|
break :blk @extern(T, .{ .name = if (bun.Environment.isAarch64) "fstat" else "fstat64" });
|
|
};
|
|
pub const stat = blk: {
|
|
const T = *const fn (?[*:0]const u8, ?*bun.Stat) callconv(.c) c_int;
|
|
break :blk @extern(T, .{ .name = if (bun.Environment.isAarch64) "stat" else "stat64" });
|
|
};
|
|
};
|
|
pub const windows = struct {
|
|
/// Windows doesn't have memmem, so we need to implement it
|
|
/// This is used in src/string/immutable.zig
|
|
pub export fn memmem(haystack: ?[*]const u8, haystacklen: usize, needle: ?[*]const u8, needlelen: usize) ?[*]const u8 {
|
|
// Handle null pointers
|
|
if (haystack == null or needle == null) return null;
|
|
|
|
// Handle empty needle case
|
|
if (needlelen == 0) return haystack;
|
|
|
|
// Handle case where needle is longer than haystack
|
|
if (needlelen > haystacklen) return null;
|
|
|
|
const hay = haystack.?[0..haystacklen];
|
|
const nee = needle.?[0..needlelen];
|
|
|
|
const i = std.mem.indexOf(u8, hay, nee) orelse return null;
|
|
return hay.ptr + i;
|
|
}
|
|
|
|
/// lstat is implemented in workaround-missing-symbols.cpp
|
|
pub const lstat = blk: {
|
|
const T = *const fn ([*c]const u8, [*c]std.c.Stat) callconv(.c) c_int;
|
|
break :blk @extern(T, .{ .name = "lstat64" });
|
|
};
|
|
/// fstat is implemented in workaround-missing-symbols.cpp
|
|
pub const fstat = blk: {
|
|
const T = *const fn ([*c]const u8, [*c]std.c.Stat) callconv(.c) c_int;
|
|
break :blk @extern(T, .{ .name = "fstat64" });
|
|
};
|
|
/// stat is implemented in workaround-missing-symbols.cpp
|
|
pub const stat = blk: {
|
|
const T = *const fn ([*c]const u8, [*c]std.c.Stat) callconv(.c) c_int;
|
|
break :blk @extern(T, .{ .name = "stat64" });
|
|
};
|
|
};
|
|
|
|
pub const current = switch (bun.Environment.os) {
|
|
.linux => linux,
|
|
.windows => windows,
|
|
.mac => darwin,
|
|
else => struct {},
|
|
};
|
|
|
|
const bun = @import("bun");
|
|
const std = @import("std");
|