mirror of
https://github.com/oven-sh/bun
synced 2026-02-10 02:48:50 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
194 lines
5.5 KiB
Zig
194 lines
5.5 KiB
Zig
//! When cloning large amounts of data potentially multiple times, we can
|
|
//! leverage copy-on-write memory to avoid actually copying the data. To do that
|
|
//! on Linux, we need to use a memfd, which is a Linux-specific feature.
|
|
//!
|
|
//! The steps are roughly:
|
|
//!
|
|
//! 1. Create a memfd
|
|
//! 2. Write the data to the memfd
|
|
//! 3. Map the memfd into memory
|
|
//!
|
|
//! Then, to clone the data later, we can just call `mmap` again.
|
|
//!
|
|
//! The big catch is that mmap(), memfd_create(), write() all have overhead. And
|
|
//! often we will re-use virtual memory within the process. This does not reuse
|
|
//! the virtual memory. So we should only really use this for large blobs of
|
|
//! data that we expect to be cloned multiple times. Such as Blob in FormData.
|
|
|
|
const Self = @This();
|
|
|
|
const RefCount = bun.ptr.ThreadSafeRefCount(@This(), "ref_count", deinit, .{});
|
|
|
|
pub const new = bun.TrivialNew(@This());
|
|
pub const ref = RefCount.ref;
|
|
pub const deref = RefCount.deref;
|
|
|
|
ref_count: RefCount,
|
|
fd: bun.FileDescriptor = .invalid,
|
|
size: usize = 0,
|
|
|
|
var memfd_counter = std.atomic.Value(usize).init(0);
|
|
|
|
fn deinit(self: *Self) void {
|
|
self.fd.close();
|
|
bun.destroy(self);
|
|
}
|
|
|
|
pub fn allocator(self: *Self) std.mem.Allocator {
|
|
return .{
|
|
.ptr = self,
|
|
.vtable = AllocatorInterface.VTable,
|
|
};
|
|
}
|
|
|
|
pub fn from(allocator_: std.mem.Allocator) ?*Self {
|
|
if (allocator_.vtable == AllocatorInterface.VTable) {
|
|
return @ptrCast(@alignCast(allocator_.ptr));
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
const AllocatorInterface = struct {
|
|
fn alloc(_: *anyopaque, _: usize, _: std.mem.Alignment, _: usize) ?[*]u8 {
|
|
// it should perform no allocations or resizes
|
|
return null;
|
|
}
|
|
|
|
fn free(
|
|
ptr: *anyopaque,
|
|
buf: []u8,
|
|
_: std.mem.Alignment,
|
|
_: usize,
|
|
) void {
|
|
var self: *Self = @ptrCast(@alignCast(ptr));
|
|
defer self.deref();
|
|
bun.sys.munmap(@ptrCast(@alignCast(buf))).unwrap() catch |err| {
|
|
bun.Output.debugWarn("Failed to munmap memfd: {}", .{err});
|
|
};
|
|
}
|
|
|
|
pub const VTable = &std.mem.Allocator.VTable{
|
|
.alloc = &AllocatorInterface.alloc,
|
|
.resize = &std.mem.Allocator.noResize,
|
|
.remap = &std.mem.Allocator.noRemap,
|
|
.free = &free,
|
|
};
|
|
};
|
|
|
|
pub fn alloc(self: *Self, len: usize, offset: usize, flags: std.posix.MAP) bun.sys.Maybe(bun.webcore.Blob.Store.Bytes) {
|
|
var size = len;
|
|
|
|
// size rounded up to nearest page
|
|
size = std.mem.alignForward(usize, size, std.heap.pageSize());
|
|
|
|
var flags_mut = flags;
|
|
flags_mut.TYPE = .SHARED;
|
|
|
|
switch (bun.sys.mmap(
|
|
null,
|
|
@min(size, self.size),
|
|
std.posix.PROT.READ | std.posix.PROT.WRITE,
|
|
flags_mut,
|
|
self.fd,
|
|
offset,
|
|
)) {
|
|
.result => |slice| {
|
|
return .{
|
|
.result = bun.webcore.Blob.Store.Bytes{
|
|
.cap = @truncate(slice.len),
|
|
.ptr = slice.ptr,
|
|
.len = @truncate(len),
|
|
.allocator = self.allocator(),
|
|
},
|
|
};
|
|
},
|
|
.err => |errno| {
|
|
return .{ .err = errno };
|
|
},
|
|
}
|
|
}
|
|
|
|
pub fn shouldUse(bytes: []const u8) bool {
|
|
if (comptime !bun.Environment.isLinux) {
|
|
return false;
|
|
}
|
|
|
|
if (bun.jsc.VirtualMachine.is_smol_mode) {
|
|
return bytes.len >= 1024 * 1024 * 1;
|
|
}
|
|
|
|
// This is a net 2x - 4x slowdown to new Blob([huge])
|
|
// so we must be careful
|
|
return bytes.len >= 1024 * 1024 * 8;
|
|
}
|
|
|
|
pub fn create(bytes: []const u8) bun.sys.Maybe(bun.webcore.Blob.Store.Bytes) {
|
|
if (comptime !bun.Environment.isLinux) {
|
|
unreachable;
|
|
}
|
|
|
|
var label_buf: [128]u8 = undefined;
|
|
const label = std.fmt.bufPrintZ(&label_buf, "memfd-num-{d}", .{memfd_counter.fetchAdd(1, .monotonic)}) catch "";
|
|
|
|
// Using huge pages was slower.
|
|
const fd = switch (bun.sys.memfd_create(label, std.os.linux.MFD.CLOEXEC)) {
|
|
.err => |err| return .{ .err = bun.sys.Error.fromCode(err.getErrno(), .open) },
|
|
.result => |fd| fd,
|
|
};
|
|
|
|
if (bytes.len > 0)
|
|
// Hint at the size of the file
|
|
_ = bun.sys.ftruncate(fd, @intCast(bytes.len));
|
|
|
|
// Dump all the bytes in there
|
|
var written: isize = 0;
|
|
|
|
var remain = bytes;
|
|
while (remain.len > 0) {
|
|
switch (bun.sys.pwrite(fd, remain, written)) {
|
|
.err => |err| {
|
|
if (err.getErrno() == .AGAIN) {
|
|
continue;
|
|
}
|
|
|
|
bun.Output.debugWarn("Failed to write to memfd: {f}", .{err});
|
|
fd.close();
|
|
return .{ .err = err };
|
|
},
|
|
.result => |result| {
|
|
if (result == 0) {
|
|
bun.Output.debugWarn("Failed to write to memfd: EOF", .{});
|
|
fd.close();
|
|
return .{ .err = bun.sys.Error.fromCode(.NOMEM, .write) };
|
|
}
|
|
written += @intCast(result);
|
|
remain = remain[result..];
|
|
},
|
|
}
|
|
}
|
|
|
|
var linux_memfd_allocator = Self.new(.{
|
|
.fd = fd,
|
|
.ref_count = .init(),
|
|
.size = bytes.len,
|
|
});
|
|
|
|
switch (linux_memfd_allocator.alloc(bytes.len, 0, .{ .TYPE = .SHARED })) {
|
|
.result => |res| {
|
|
return .{ .result = res };
|
|
},
|
|
.err => |err| {
|
|
linux_memfd_allocator.deref();
|
|
return .{ .err = err };
|
|
},
|
|
}
|
|
}
|
|
|
|
pub fn isInstance(allocator_: std.mem.Allocator) bool {
|
|
return allocator_.vtable == AllocatorInterface.VTable;
|
|
}
|
|
|
|
const bun = @import("bun");
|
|
const std = @import("std");
|