mirror of
https://github.com/oven-sh/bun
synced 2026-02-11 11:29:02 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
178 lines
5.6 KiB
Zig
178 lines
5.6 KiB
Zig
pub const BuildTarget = enum { native, wasm, wasi };
|
|
pub const build_target: BuildTarget = brk: {
|
|
if (builtin.cpu.arch.isWasm()) {
|
|
break :brk BuildTarget.wasm;
|
|
} else {
|
|
break :brk BuildTarget.native;
|
|
}
|
|
};
|
|
|
|
pub const isWasm = build_target == .wasm;
|
|
pub const isNative = build_target == .native;
|
|
pub const isWasi = build_target == .wasi;
|
|
pub const isMac = build_target == .native and builtin.target.os.tag == .macos;
|
|
pub const isBrowser = !isWasi and isWasm;
|
|
pub const isWindows = builtin.target.os.tag == .windows;
|
|
pub const isPosix = !isWindows and !isWasm;
|
|
pub const isDebug = builtin.mode == .Debug;
|
|
pub const isTest = builtin.is_test;
|
|
pub const isLinux = builtin.target.os.tag == .linux;
|
|
pub const isAarch64 = builtin.target.cpu.arch.isAARCH64();
|
|
pub const isX86 = builtin.target.cpu.arch.isX86();
|
|
pub const isX64 = builtin.target.cpu.arch == .x86_64;
|
|
pub const isMusl = builtin.target.abi.isMusl();
|
|
pub const allow_assert = isDebug or isTest or std.builtin.OptimizeMode.ReleaseSafe == builtin.mode;
|
|
pub const ci_assert = isDebug or isTest or enable_asan or (std.builtin.OptimizeMode.ReleaseSafe == builtin.mode and is_canary);
|
|
pub const show_crash_trace = isDebug or isTest or enable_asan;
|
|
/// All calls to `@export` should be gated behind this check, so that code
|
|
/// generators that compile Zig code know not to reference and compile a ton of
|
|
/// unused code.
|
|
pub const export_cpp_apis = if (build_options.override_no_export_cpp_apis) false else (builtin.output_mode == .Obj or isTest);
|
|
|
|
/// Whether or not to enable allocation tracking when the `AllocationScope`
|
|
/// allocator is used.
|
|
pub const enableAllocScopes = isDebug or enable_asan;
|
|
|
|
pub const build_options = @import("build_options");
|
|
|
|
/// Set if compiling with `-Dno_llvm`
|
|
/// All places this is used is working around a Zig bug.
|
|
pub const zig_self_hosted_backend = build_options.zig_self_hosted_backend;
|
|
|
|
pub const reported_nodejs_version = build_options.reported_nodejs_version;
|
|
pub const baseline = build_options.baseline;
|
|
pub const enableSIMD: bool = !baseline and !zig_self_hosted_backend;
|
|
pub const git_sha = build_options.sha;
|
|
pub const git_sha_short = if (build_options.sha.len > 0) build_options.sha[0..9] else "";
|
|
pub const git_sha_shorter = if (build_options.sha.len > 0) build_options.sha[0..6] else "";
|
|
pub const is_canary = build_options.is_canary;
|
|
pub const canary_revision = if (is_canary) build_options.canary_revision else "";
|
|
pub const dump_source = isDebug and !isTest;
|
|
pub const base_path = build_options.base_path;
|
|
pub const enable_logs = build_options.enable_logs;
|
|
pub const enable_asan = build_options.enable_asan;
|
|
pub const codegen_path = build_options.codegen_path;
|
|
pub const codegen_embed = build_options.codegen_embed;
|
|
|
|
pub const version: std.SemanticVersion = build_options.version;
|
|
pub const version_string = std.fmt.comptimePrint("{d}.{d}.{d}", .{ version.major, version.minor, version.patch });
|
|
|
|
pub inline fn onlyMac() void {
|
|
if (comptime !isMac) {
|
|
unreachable;
|
|
}
|
|
}
|
|
|
|
pub const OperatingSystem = enum {
|
|
mac,
|
|
linux,
|
|
windows,
|
|
// wAsM is nOt aN oPeRaTiNg SyStEm
|
|
wasm,
|
|
|
|
pub const names = bun.ComptimeStringMap(OperatingSystem, &.{
|
|
.{ "windows", .windows },
|
|
.{ "win32", .windows },
|
|
.{ "win", .windows },
|
|
.{ "win64", .windows },
|
|
.{ "win_x64", .windows },
|
|
.{ "darwin", .mac },
|
|
.{ "macos", .mac },
|
|
.{ "macOS", .mac },
|
|
.{ "mac", .mac },
|
|
.{ "apple", .mac },
|
|
.{ "linux", .linux },
|
|
.{ "Linux", .linux },
|
|
.{ "linux-gnu", .linux },
|
|
.{ "gnu/linux", .linux },
|
|
.{ "wasm", .wasm },
|
|
});
|
|
|
|
/// user-facing name with capitalization
|
|
pub fn displayString(self: OperatingSystem) []const u8 {
|
|
return switch (self) {
|
|
.mac => "macOS",
|
|
.linux => "Linux",
|
|
.windows => "Windows",
|
|
.wasm => "WASM",
|
|
};
|
|
}
|
|
|
|
/// same format as `process.platform`
|
|
pub fn nameString(self: OperatingSystem) []const u8 {
|
|
return switch (self) {
|
|
.mac => "darwin",
|
|
.linux => "linux",
|
|
.windows => "win32",
|
|
.wasm => "wasm",
|
|
};
|
|
}
|
|
|
|
pub fn stdOSTag(self: OperatingSystem) std.Target.Os.Tag {
|
|
return switch (self) {
|
|
.mac => .macos,
|
|
.linux => .linux,
|
|
.windows => .windows,
|
|
.wasm => unreachable,
|
|
};
|
|
}
|
|
|
|
/// npm package name, `@oven-sh/bun-{os}-{arch}`
|
|
pub fn npmName(self: OperatingSystem) []const u8 {
|
|
return switch (self) {
|
|
.mac => "darwin",
|
|
.linux => "linux",
|
|
.windows => "windows",
|
|
.wasm => "wasm",
|
|
};
|
|
}
|
|
};
|
|
|
|
pub const os: OperatingSystem = if (isMac)
|
|
.mac
|
|
else if (isLinux)
|
|
.linux
|
|
else if (isWindows)
|
|
.windows
|
|
else if (isWasm)
|
|
.wasm
|
|
else
|
|
@compileError("Please add your OS to the OperatingSystem enum");
|
|
|
|
pub const Architecture = enum {
|
|
x64,
|
|
arm64,
|
|
wasm,
|
|
|
|
/// npm package name, `@oven-sh/bun-{os}-{arch}`
|
|
pub fn npmName(this: Architecture) []const u8 {
|
|
return switch (this) {
|
|
.x64 => "x64",
|
|
.arm64 => "aarch64",
|
|
.wasm => "wasm",
|
|
};
|
|
}
|
|
|
|
pub const names = bun.ComptimeStringMap(Architecture, &.{
|
|
.{ "x86_64", .x64 },
|
|
.{ "x64", .x64 },
|
|
.{ "amd64", .x64 },
|
|
.{ "aarch64", .arm64 },
|
|
.{ "arm64", .arm64 },
|
|
.{ "wasm", .wasm },
|
|
});
|
|
};
|
|
|
|
pub const arch: Architecture = if (isWasm)
|
|
.wasm
|
|
else if (isX64)
|
|
.x64
|
|
else if (isAarch64)
|
|
.arm64
|
|
else
|
|
@compileError("Please add your architecture to the Architecture enum");
|
|
|
|
const builtin = @import("builtin");
|
|
const bun = @import("bun");
|
|
const std = @import("std");
|