mirror of
https://github.com/oven-sh/bun
synced 2026-02-15 05:12:29 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
61 lines
2.4 KiB
Zig
61 lines
2.4 KiB
Zig
/// After running `convertEnvToWTF8`, the pointers in `std.os.environ` will point into this buffer.
|
|
pub var wtf8_env_buf: ?[]const u8 = null;
|
|
/// `convertEnvToWTF8` will set this to the original value of `std.os.environ`.
|
|
pub var orig_environ: ?[][*:0]u8 = null;
|
|
|
|
var env_converted: if (Environment.ci_assert) bool else void = if (Environment.ci_assert) false;
|
|
|
|
/// Converts all strings in `std.os.environ` to WTF-8.
|
|
///
|
|
/// This function should be called only once, at program startup, before any code that needs to
|
|
/// access the environment runs.
|
|
///
|
|
/// This function is Windows-only.
|
|
pub fn convertEnvToWTF8() bun.OOM!void {
|
|
if (comptime Environment.ci_assert) {
|
|
bun.assertf(!env_converted, "convertEnvToWTF8 may only be called once", .{});
|
|
env_converted = true;
|
|
}
|
|
errdefer if (comptime Environment.ci_assert) {
|
|
env_converted = false;
|
|
};
|
|
|
|
var num_vars: usize = 0;
|
|
const wtf8_buf: []u8 = blk: {
|
|
var wtf16_buf: [*:0]u16 = try bun.windows.GetEnvironmentStringsW();
|
|
defer bun.windows.FreeEnvironmentStringsW(wtf16_buf);
|
|
var len: usize = 0;
|
|
while (true) {
|
|
const str_len = std.mem.len(wtf16_buf[len..]);
|
|
len += str_len + 1; // each string is null-terminated
|
|
if (str_len == 0) break; // array ends with empty null-terminated string
|
|
num_vars += 1;
|
|
}
|
|
break :blk try bun.strings.toUTF8AllocWithType(bun.default_allocator, wtf16_buf[0..len]);
|
|
};
|
|
errdefer bun.default_allocator.free(wtf8_buf);
|
|
var len: usize = 0;
|
|
|
|
var envp: bun.collections.ArrayListDefault(?[*:0]u8) = try .initCapacity(num_vars + 1);
|
|
errdefer envp.deinit();
|
|
while (true) {
|
|
const str_len = std.mem.indexOfScalar(u8, wtf8_buf[len..], 0).?;
|
|
defer len += str_len + 1; // each string is null-terminated
|
|
if (str_len == 0) break; // array ends with empty null-terminated string
|
|
const str_ptr: [*:0]u8 = @ptrCast(wtf8_buf[len..].ptr);
|
|
try envp.append(str_ptr);
|
|
}
|
|
try envp.append(null);
|
|
|
|
const envp_slice: []?[*:0]u8 = try envp.toOwnedSlice();
|
|
const envp_nonnull_slice: [][*:0]u8 = @ptrCast(envp_slice[0 .. envp_slice.len - 1]);
|
|
wtf8_env_buf = wtf8_buf;
|
|
orig_environ = std.os.environ;
|
|
std.os.environ = envp_nonnull_slice;
|
|
}
|
|
|
|
const std = @import("std");
|
|
|
|
const bun = @import("bun");
|
|
const Environment = bun.Environment;
|