mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 18:38:55 +00:00
3315ade0e9
## Summary Fixes the broken update hdrhistogram GitHub Action workflow that was failing due to multiple issues. ## Issues Fixed 1. **Tag SHA resolution failure**: The workflow failed when trying to resolve commit SHA from lightweight tags, causing the error "Could not fetch SHA for tag 0.11.8 @ 8dcce8f68512fca460b171bccc3a5afce0048779" 2. **Branch naming bug**: The workflow was creating branches named `deps/update-cares-*` instead of `deps/update-hdrhistogram-*` 3. **Wrong workflow link**: PR body was linking to `update-cares.yml` instead of `update-hdrhistogram.yml` ## Fix Details - **Improved tag SHA resolution**: Updated logic to handle both lightweight and annotated tags: - Try to get commit SHA from tag object (for annotated tags) - If that fails, use the tag SHA directly (for lightweight tags) - Uses jq's `// empty` operator and proper error handling with `2>/dev/null` - **Fixed branch naming**: Changed from `deps/update-cares-*` to `deps/update-hdrhistogram-*` - **Updated workflow link**: Fixed PR body to link to correct workflow file ## Test Plan - [x] Verified current workflow logs show the exact error being fixed - [x] Tested API calls locally to confirm the new logic works with latest tag (0.11.8) - [x] Confirmed the latest tag is a lightweight tag pointing directly to commit The workflow should now run successfully on the next scheduled execution or manual trigger. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com>