mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-15 05:12:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
576b21f2ff7470f73a133beb624b8d6e706f261d
bun.sh/src
History
robobun 576b21f2ff fix(test): prevent integer overflow in pretty_format writeIndent (#23843) 
## Summary

Fixes a panic that occurred when formatting deeply nested objects with
many properties in test output.

## Problem

The `writeIndent()` function in `pretty_format.zig:648` performed
`written * 2` which triggered integer overflow checking in debug builds
when formatting complex nested structures.

**Original crash:**
```
panic: integer overflow
writeIndent at bun.js/test/pretty_format.zig:648
```

**Platform:** Windows x86_64_baseline, Bun v1.3.0

## Solution

Changed from:
```zig
try writer.writeAll(buf[0 .. written * 2]);
```

To:
```zig
const byte_count = @min(buf.len, written *% 2);
try writer.writeAll(buf[0..byte_count]);
```

- Used wrapping multiplication (`*%`) to prevent overflow panic
- Added bounds checking with `@min(buf.len, ...)` for safety
- Maintains correct behavior while preventing crashes

## Test

Added regression test at
`test/js/bun/test/pretty-format-overflow.test.ts` that:
- Creates deeply nested objects (500 levels with 50 properties each)
- Verifies no panic/overflow/crash occurs when formatting
- Uses exact configuration that triggered the original crash

## Verification

- ✅ Test passes with the fix
- ✅ Test would crash without the fix (in debug builds)
- ✅ No changes to behavior, only safety improvement

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
2025-10-19 21:20:56 -07:00
..
allocators
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
analytics
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
api
fix loaders used by Module._extensions (#23291)
2025-10-06 06:40:15 -07:00
ast
fix(bundler): import.meta.url and esm wrapper fixes (#23803)
2025-10-18 20:49:57 -07:00
async
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
bake
Remove unused EventLoopTimer.Arm return type (#23765)
2025-10-18 17:04:47 -07:00
base64
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bun.js
fix(test): prevent integer overflow in pretty_format writeIndent (#23843)
2025-10-19 21:20:56 -07:00
bundler
fix(bundler): import.meta.url and esm wrapper fixes (#23803)
2025-10-18 20:49:57 -07:00
cli
Add --pass-with-no-tests flag to test runner (#23424)
2025-10-15 17:38:02 -07:00
codegen
Port SocketConfig to bindings generator (#23755)
2025-10-18 18:14:01 -07:00
collections
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
create
Fix Windows shell crash with && operator and external commands (#22651)
2025-09-14 04:14:48 -07:00
css
Passthrough anyerror when using handleOom (#23176)
2025-10-02 14:11:29 -07:00
deps
Remove unused EventLoopTimer.Arm return type (#23765)
2025-10-18 17:04:47 -07:00
errno
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
fs
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
glob
Add missing error handling for directory entries errors (#23511)
2025-10-11 19:21:14 -07:00
http
Revert "Add support for localAddress and localPort in TCP connections" (#23675)
2025-10-14 19:46:47 -07:00
init
fix: fix broken scripts in the React templates after the index.ts rename (#23472)
2025-10-10 22:49:45 -07:00
install
fix(install): EXDEV handling with linker: "isolated" (#23587)
2025-10-13 11:19:17 -07:00
interchange
Bring Bun.YAML to 90% passing yaml-test-suite (#23265)
2025-10-05 17:23:59 -07:00
io
Fix: after pausing stdin, a subprocess should be able to read from stdin (#23341)
2025-10-09 19:04:41 -07:00
js
Revert "Add support for localAddress and localPort in TCP connections" (#23675)
2025-10-14 19:46:47 -07:00
js_lexer
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
libarchive
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
meta
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
napi
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
node-fallbacks
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
paths
Make --linker=isolated the default for bun install (#23311)
2025-10-08 18:00:38 -07:00
ptr
Add .cloneUpgrade() to fix clone-upgrade (#23201)
2025-10-03 16:13:06 -07:00
resolver
Eliminates special handling for bun:test in the transpiler (#22888)
2025-10-14 20:51:34 -07:00
s3
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
safety
Refactor BabyList (#22502)
2025-09-09 20:41:10 -07:00
semver
Make --linker=isolated the default for bun install (#23311)
2025-10-08 18:00:38 -07:00
shell
bun.shell: Add .quiet(boolean)
2025-10-14 17:43:38 -07:00
sourcemap
fix(test): lcov reporter now counts only executable lines (#23320)
2025-10-06 19:47:24 -07:00
sql
Remove unused EventLoopTimer.Arm return type (#23765)
2025-10-18 17:04:47 -07:00
string
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
sys
Preserve original types in PosixStat
2025-10-16 21:52:22 -04:00
test
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
threading
Require deinit function for memory.deinit() (#22923)
2025-09-26 13:47:24 -07:00
valkey
Remove unused EventLoopTimer.Arm return type (#23765)
2025-10-18 17:04:47 -07:00
vm
Add support for node:vm.SyntheticModule (#19878)
2025-06-04 19:41:26 -07:00
watcher
Add BUN_WATCHER_TRACE environment variable for debugging file watcher events (#23533)
2025-10-12 11:29:48 -07:00
.clang-format
…
AGENTS.md
update CLAUDE.md
2025-10-04 02:17:55 -07:00
allocators.zig
Require deinit function for memory.deinit() (#22923)
2025-09-26 13:47:24 -07:00
analytics.zig
implement pnpm migration (#22262)
2025-09-27 00:45:29 -07:00
asan-config.c
Fix Linux ASan debug builds (#19657)
2025-05-14 18:42:42 -07:00
asan.zig
Add asan checks to HiveArray (#21449)
2025-07-29 19:35:46 -07:00
ast.zig
fix(bundler): import.meta.url and esm wrapper fixes (#23803)
2025-10-18 20:49:57 -07:00
bake.bind.ts
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bake.zig
ssg 3 (#22138)
2025-09-30 05:26:32 -07:00
bits.zig
…
boringssl.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
brotli.zig
fix: handle empty chunked gzip responses correctly (#22360)
2025-09-03 18:57:39 -07:00
btjs.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bun.exe.manifest
Enable Windows long path support (#21244)
2025-07-20 23:04:17 -07:00
bun.ico
…
bun.js.zig
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
bun.zig
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
bunfig.zig
Add bunfig.toml support for test randomize, seed, and rerunEach options (#23286)
2025-10-06 19:48:16 -07:00
c-headers-for-zig.h
node:zlib: add zstd (#20313)
2025-06-12 14:20:28 -07:00
cache.zig
zig: remove bun.fs_allocator alias (#22782)
2025-09-18 19:37:24 -07:00
ci_info.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
CLAUDE.md
fix(watcher): handle vim atomic save race on macOS (#23566)
2025-10-14 16:33:30 -07:00
cli.zig
Add --pass-with-no-tests flag to test runner (#23424)
2025-10-15 17:38:02 -07:00
collections.zig
Add generic-allocator ArrayList (#22917)
2025-09-26 15:19:45 -07:00
compile_target.zig
Make --linker=isolated the default for bun install (#23311)
2025-10-08 18:00:38 -07:00
comptime_string_map.zig
Delete incorrect assertion in ComptimeStringMap (#21504)
2025-07-31 00:56:50 -07:00
copy_file.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
crash_handler.zig
Fix crash handler not dumping stack traces on Linux aarch64 (#23549)
2025-10-12 14:00:11 -07:00
csrf.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
darwin.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
defines-table.zig
fix(build): Promise.all() async module dependencies (#22704)
2025-09-26 22:21:00 -07:00
defines.zig
ci: instrument being able to run leaksanitizer (#21142)
2025-09-19 02:06:02 -07:00
dir.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
dns.zig
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
env_loader.zig
Fix env loader buffer overflow by using stack fallback allocator (#21416)
2025-07-28 00:13:17 -07:00
env.zig
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
fallback-backend.html
Fix formatters not running in CI + delete unnecessary files (#19433)
2025-05-08 23:22:16 -07:00
fallback.html
Fix formatters not running in CI + delete unnecessary files (#19433)
2025-05-08 23:22:16 -07:00
fallback.ts
…
favicon.png
…
fd.zig
Fix pipeline stack errors on Windows (#21800)
2025-08-14 18:03:26 -07:00
feature_flags.zig
Enable breaking_changes_1_3 (#23308)
2025-10-07 12:07:29 -07:00
fixtures_example.com.html
Fix formatters not running in CI + delete unnecessary files (#19433)
2025-05-08 23:22:16 -07:00
fmt.bind.ts
…
fmt.zig
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
fs.zig
fix(watcher): handle vim atomic save race on macOS (#23566)
2025-10-14 16:33:30 -07:00
generated_perf_trace_events.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
glob.zig
fix(install): make negative workspace patterns work (#23229)
2025-10-04 00:31:47 -07:00
Global.zig
lsan: fix reporting on linux ci (#22806)
2025-09-24 00:47:52 -07:00
handle_oom.zig
Passthrough anyerror when using handleOom (#23176)
2025-10-02 14:11:29 -07:00
heap_breakdown.zig
disable heap_breakdown when asan is enabled
2025-09-19 02:38:38 -07:00
highway.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
hmac.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
HTMLScanner.zig
Refactor BabyList (#22502)
2025-09-09 20:41:10 -07:00
http.zig
fix streaming issue (#23289)
2025-10-06 05:39:22 -07:00
identity_context.zig
implement "nodeLinker": "isolated" in bun install (#20440)
2025-07-09 00:19:57 -07:00
import_record.zig
Eliminates special handling for bun:test in the transpiler (#22888)
2025-10-14 20:51:34 -07:00
ini.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
interchange.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
js_lexer_tables.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
js_lexer.zig
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
js_parser.zig
'vi' was missing from bun test globals (#23674)
2025-10-15 14:31:27 -07:00
js_printer.zig
fix(bundler): import.meta.url and esm wrapper fixes (#23803)
2025-10-18 20:49:57 -07:00
jsc_stub.zig
…
linear_fifo.zig
Fix linear_fifo (#22590)
2025-09-11 23:29:53 -07:00
linker.lds
…
linker.zig
Eliminates special handling for bun:test in the transpiler (#22888)
2025-10-14 20:51:34 -07:00
linux.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
logger.zig
Fix segmentation fault during building stack traces string (#22902)
2025-10-04 01:56:42 -07:00
logo.svg
…
macho.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
main_test.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
main_wasm.zig
Replace catch bun.outOfMemory() with safer alternatives (#22141)
2025-08-26 12:50:25 -07:00
main.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
memory.zig
Port SocketConfig to bindings generator (#23755)
2025-10-18 18:14:01 -07:00
meta.zig
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
node_fallbacks.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
open.zig
Fix Windows shell crash with && operator and external commands (#22651)
2025-09-14 04:14:48 -07:00
options.zig
Eliminates special handling for bun:test in the transpiler (#22888)
2025-10-14 20:51:34 -07:00
output.zig
bun test dots reporter (#22919)
2025-10-03 17:13:22 -07:00
OutputFile.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
patch.zig
patch: make Header struct use one-based line indexing by default (#21995)
2025-09-12 23:59:24 -07:00
paths.zig
fix(pnpm migration): correctly resolve link: dependencies on the root package (#23111)
2025-09-30 00:10:15 -07:00
pe.zig
feat(windows): implement authenticode stripping for --compile (#22960)
2025-09-25 18:03:27 -07:00
perf.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
pool.zig
Refactor BabyList (#22502)
2025-09-09 20:41:10 -07:00
Progress.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
ptr.zig
Add ExternalShared and RawRefCount (#23013)
2025-09-26 15:15:58 -07:00
renamer.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
result.zig
…
router.zig
Replace catch bun.outOfMemory() with safer alternatives (#22141)
2025-08-26 12:50:25 -07:00
runtime.bun.js
…
runtime.js
fix(build): Promise.all() async module dependencies (#22704)
2025-09-26 22:21:00 -07:00
runtime.zig
fix(build): Promise.all() async module dependencies (#22704)
2025-09-26 22:21:00 -07:00
safety.zig
Static allocator polymorphism (#22227)
2025-09-03 15:40:44 -07:00
semver.zig
fix(install): change semver core numbers to u64 (#22889)
2025-09-22 19:28:26 -07:00
sha.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
StandaloneModuleGraph.zig
fix #23470 (#23471)
2025-10-11 08:23:25 -07:00
StaticHashMap.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
string.zig
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
symbols.def
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
symbols.dyn
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
symbols.txt
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
sys_uv.zig
Implement birthtime support on Linux using statx syscall (#23209)
2025-10-04 04:57:29 -07:00
sys.zig
fix(watcher): handle vim atomic save race on macOS (#23566)
2025-10-14 16:33:30 -07:00
system_timer.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
threading.zig
Static allocator polymorphism (#22227)
2025-09-03 15:40:44 -07:00
tmp.zig
zig: delete deprecated bun.jsc.Maybe (#21327)
2025-07-25 12:38:06 -07:00
tracy.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
trait.zig
…
transpiler.zig
ci: instrument being able to run leaksanitizer (#21142)
2025-09-19 02:06:02 -07:00
tsconfig.json
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
unit_test.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
url.zig
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
util.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
walker_skippable.zig
fix(install): isolated install with file dependency resolving to root package (#23204)
2025-10-03 02:38:55 -07:00
Watcher.zig
fix(watcher): handle vim atomic save race on macOS (#23566)
2025-10-14 16:33:30 -07:00
which_npm_client.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
which.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
windows-app-info.rc
Enable Windows long path support (#21244)
2025-07-20 23:04:17 -07:00
windows.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
work_pool.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
workaround_missing_symbols.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
wyhash.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
zlib.test.gz
…
zlib.test.txt
…
zlib.zig
fix: handle empty chunked gzip responses correctly (#22360)
2025-09-03 18:57:39 -07:00