mirror of
https://github.com/oven-sh/bun
synced 2026-02-16 13:51:47 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
113 lines
3.8 KiB
Zig
113 lines
3.8 KiB
Zig
/// Optional trace file for debugging watcher events
|
|
var trace_file: ?bun.sys.File = null;
|
|
|
|
/// Initialize trace file if BUN_WATCHER_TRACE env var is set.
|
|
/// Only checks once on first call.
|
|
pub fn init() void {
|
|
if (trace_file != null) return;
|
|
|
|
if (bun.env_var.BUN_WATCHER_TRACE.get()) |trace_path| {
|
|
if (trace_path.len > 0) {
|
|
const flags = bun.O.WRONLY | bun.O.CREAT | bun.O.APPEND;
|
|
const mode = 0o644;
|
|
switch (bun.sys.openA(trace_path, flags, mode)) {
|
|
.result => |fd| {
|
|
trace_file = bun.sys.File{ .handle = fd };
|
|
},
|
|
.err => {
|
|
// Silently ignore errors opening trace file
|
|
},
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Write trace events to the trace file if enabled.
|
|
/// This is called from the watcher thread, so no locking is needed.
|
|
/// Events are assumed to be already deduped by path.
|
|
pub fn writeEvents(watcher: *Watcher, events: []Watcher.WatchEvent, changed_files: []?[:0]u8) void {
|
|
const file = trace_file orelse return;
|
|
|
|
var buffer: [4096]u8 = undefined;
|
|
var buffered = file.writer().adaptToNewApi(&buffer);
|
|
defer buffered.new_interface.flush() catch |err| {
|
|
bun.Output.err(err, "Failed to flush watcher trace file", .{});
|
|
};
|
|
const writer = &buffered.new_interface;
|
|
|
|
// Get current timestamp
|
|
const timestamp = std.time.milliTimestamp();
|
|
|
|
// Write: { "timestamp": number, "files": { ... } }
|
|
writer.writeAll("{\"timestamp\":") catch return;
|
|
writer.print("{d}", .{timestamp}) catch return;
|
|
writer.writeAll(",\"files\":{") catch return;
|
|
|
|
const watchlist_slice = watcher.watchlist.slice();
|
|
const file_paths = watchlist_slice.items(.file_path);
|
|
|
|
var first_file = true;
|
|
for (events) |event| {
|
|
const file_path = if (event.index < file_paths.len) file_paths[event.index] else "(unknown)";
|
|
const names = event.names(changed_files);
|
|
|
|
if (!first_file) writer.writeAll(",") catch return;
|
|
first_file = false;
|
|
|
|
// Write path as key
|
|
writer.print("{f}", .{bun.fmt.formatJSONStringUTF8(file_path, .{})}) catch return;
|
|
writer.writeAll(":{\"events\":[") catch return;
|
|
|
|
// Write array of event types using comptime reflection
|
|
const fields = std.meta.fields(@TypeOf(event.op));
|
|
var first = true;
|
|
inline for (fields) |field| {
|
|
// Only process bool fields (skip _padding and other non-bool fields)
|
|
if (field.type == bool and @field(event.op, field.name)) {
|
|
if (!first) writer.writeAll(",") catch return;
|
|
writer.print("\"{s}\"", .{field.name}) catch return;
|
|
first = false;
|
|
}
|
|
}
|
|
writer.writeAll("]") catch return;
|
|
|
|
// Only write "changed" field if there are changed files
|
|
var has_changed = false;
|
|
for (names) |name_opt| {
|
|
if (name_opt != null) {
|
|
has_changed = true;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (has_changed) {
|
|
writer.writeAll(",\"changed\":[") catch return;
|
|
first = true;
|
|
for (names) |name_opt| {
|
|
if (name_opt) |name| {
|
|
if (!first) writer.writeAll(",") catch return;
|
|
first = false;
|
|
writer.print("{f}", .{bun.fmt.formatJSONStringUTF8(name, .{})}) catch return;
|
|
}
|
|
}
|
|
writer.writeAll("]") catch return;
|
|
}
|
|
|
|
writer.writeAll("}") catch return;
|
|
}
|
|
|
|
writer.writeAll("}}\n") catch return;
|
|
}
|
|
|
|
/// Close the trace file if open
|
|
pub fn deinit() void {
|
|
if (trace_file) |file| {
|
|
file.close();
|
|
trace_file = null;
|
|
}
|
|
}
|
|
|
|
const Watcher = @import("../Watcher.zig");
|
|
const bun = @import("bun");
|
|
const std = @import("std");
|