Files
bun.sh/src/sys_uv.zig
pfg 05d0475c6c Update to zig 0.15.2 (#24204)
Fixes ENG-21287

Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`

|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|

Runtime performance:

- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)

Improvements:

- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests

Still an issue:

- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed

Follow-up:

- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully

Files that add lines:

```
649     src/deprecated.zig
167     scripts/pack-codegen-for-zig-team.ts
54      scripts/cleartrace-impl.js
46      scripts/cleartrace.ts
43      src/windows.zig
18      src/fs.zig
17      src/bun.js/ConsoleObject.zig
16      src/output.zig
12      src/bun.js/test/debug.zig
12      src/bun.js/node/node_fs.zig
8       src/env_loader.zig
7       src/css/printer.zig
7       src/cli/init_command.zig
7       src/bun.js/node.zig
6       src/string/escapeRegExp.zig
6       src/install/PnpmMatcher.zig
5       src/bun.js/webcore/Blob.zig
4       src/crash_handler.zig
4       src/bun.zig
3       src/install/lockfile/bun.lock.zig
3       src/cli/update_interactive_command.zig
3       src/cli/pack_command.zig
3       build.zig
2       src/Progress.zig
2       src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2       src/css/small_list.zig
2       src/bun.js/webcore/prompt.zig
1       test/internal/ban-words.test.ts
1       test/internal/ban-limits.json
1       src/watcher/WatcherTrace.zig
1       src/transpiler.zig
1       src/shell/builtin/cp.zig
1       src/js_printer.zig
1       src/io/PipeReader.zig
1       src/install/bin.zig
1       src/css/selectors/selector.zig
1       src/cli/run_command.zig
1       src/bun.js/RuntimeTranspilerStore.zig
1       src/bun.js/bindings/JSRef.zig
1       src/bake/DevServer.zig
```

Files that remove lines:

```
-1      src/test/recover.zig
-1      src/sql/postgres/SocketMonitor.zig
-1      src/sql/mysql/MySQLRequestQueue.zig
-1      src/sourcemap/CodeCoverage.zig
-1      src/css/values/color_js.zig
-1      src/compile_target.zig
-1      src/bundler/linker_context/convertStmtsForChunk.zig
-1      src/bundler/bundle_v2.zig
-1      src/bun.js/webcore/blob/read_file.zig
-1      src/ast/base.zig
-2      src/sql/postgres/protocol/ArrayList.zig
-2      src/shell/builtin/mkdir.zig
-2      src/install/PackageManager/patchPackage.zig
-2      src/install/PackageManager/PackageManagerDirectories.zig
-2      src/fmt.zig
-2      src/css/declaration.zig
-2      src/css/css_parser.zig
-2      src/collections/baby_list.zig
-2      src/bun.js/bindings/ZigStackFrame.zig
-2      src/ast/E.zig
-3      src/StandaloneModuleGraph.zig
-3      src/deps/picohttp.zig
-3      src/deps/libuv.zig
-3      src/btjs.zig
-4      src/threading/Futex.zig
-4      src/shell/builtin/touch.zig
-4      src/meta.zig
-4      src/install/lockfile.zig
-4      src/css/selectors/parser.zig
-5      src/shell/interpreter.zig
-5      src/css/error.zig
-5      src/bun.js/web_worker.zig
-5      src/bun.js.zig
-6      src/cli/test_command.zig
-6      src/bun.js/VirtualMachine.zig
-6      src/bun.js/uuid.zig
-6      src/bun.js/bindings/JSValue.zig
-9      src/bun.js/test/pretty_format.zig
-9      src/bun.js/api/BunObject.zig
-14     src/install/install_binding.zig
-14     src/fd.zig
-14     src/bun.js/node/path.zig
-14     scripts/pack-codegen-for-zig-team.sh
-17     src/bun.js/test/diff_format.zig
```

`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
2025-11-10 14:38:26 -08:00

390 lines
13 KiB
Zig

//! bun.sys.sys_uv is a polyfill of bun.sys but with libuv.
//! TODO: Probably should merge this into bun.sys itself with isWindows checks
comptime {
bun.assert(Environment.isWindows);
}
pub const log = bun.sys.syslog;
pub const Error = bun.sys.Error;
pub const PosixStat = bun.sys.PosixStat;
// libuv dont support openat (https://github.com/libuv/libuv/issues/4167)
pub const openat = bun.sys.openat;
pub const getFdPath = bun.sys.getFdPath;
pub const setFileOffset = bun.sys.setFileOffset;
pub const openatOSPath = bun.sys.openatOSPath;
pub const mkdirOSPath = bun.sys.mkdirOSPath;
pub const access = bun.sys.access;
// Note: `req = undefined; req.deinit()` has a safety-check in a debug build
pub fn open(file_path: [:0]const u8, c_flags: i32, _perm: bun.Mode) Maybe(bun.FileDescriptor) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const flags = uv.O.fromBunO(c_flags);
var perm = _perm;
if (perm == 0) {
// Set a sensible default, otherwise on windows the file will be unusable
perm = 0o644;
}
const rc = uv.uv_fs_open(uv.Loop.get(), &req, file_path.ptr, flags, perm, null);
log("uv open({s}, {d}, {d}) = {d}", .{ file_path, flags, perm, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .open, .path = file_path } }
else
.{ .result = req.result.toFD() };
}
pub fn mkdir(file_path: [:0]const u8, flags: bun.Mode) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_mkdir(uv.Loop.get(), &req, file_path.ptr, flags, null);
log("uv mkdir({s}, {d}) = {d}", .{ file_path, flags, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .mkdir, .path = file_path } }
else
.success;
}
pub fn chmod(file_path: [:0]const u8, flags: bun.Mode) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_chmod(uv.Loop.get(), &req, file_path.ptr, flags, null);
log("uv chmod({s}, {d}) = {d}", .{ file_path, flags, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .chmod, .path = file_path } }
else
.success;
}
pub fn fchmod(fd: FileDescriptor, flags: bun.Mode) Maybe(void) {
const uv_fd = fd.uv();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_fchmod(uv.Loop.get(), &req, uv_fd, flags, null);
log("uv fchmod({}, {d}) = {d}", .{ uv_fd, flags, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .fchmod, .fd = fd } }
else
.success;
}
pub fn statfs(file_path: [:0]const u8) Maybe(bun.StatFS) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_statfs(uv.Loop.get(), &req, file_path.ptr, null);
log("uv statfs({s}) = {d}", .{ file_path, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .statfs, .path = file_path } }
else
.{ .result = bun.StatFS.init(req.ptrAs(*align(1) bun.StatFS)) };
}
pub fn chown(file_path: [:0]const u8, uid: uv.uv_uid_t, gid: uv.uv_uid_t) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_chown(uv.Loop.get(), &req, file_path.ptr, uid, gid, null);
log("uv chown({s}, {d}, {d}) = {d}", .{ file_path, uid, gid, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .chown, .path = file_path } }
else
.success;
}
pub fn fchown(fd: FileDescriptor, uid: uv.uv_uid_t, gid: uv.uv_uid_t) Maybe(void) {
const uv_fd = fd.uv();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_fchown(uv.Loop.get(), &req, uv_fd, uid, gid, null);
log("uv chown({}, {d}, {d}) = {d}", .{ uv_fd, uid, gid, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .fchown, .fd = fd } }
else
.success;
}
pub fn rmdir(file_path: [:0]const u8) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_rmdir(uv.Loop.get(), &req, file_path.ptr, null);
log("uv rmdir({s}) = {d}", .{ file_path, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .rmdir, .path = file_path } }
else
.success;
}
pub fn unlink(file_path: [:0]const u8) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_unlink(uv.Loop.get(), &req, file_path.ptr, null);
log("uv unlink({s}) = {d}", .{ file_path, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .unlink, .path = file_path } }
else
.success;
}
pub fn readlink(file_path: [:0]const u8, buf: []u8) Maybe([:0]u8) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
// Edge cases: http://docs.libuv.org/en/v1.x/fs.html#c.uv_fs_realpath
const rc = uv.uv_fs_readlink(uv.Loop.get(), &req, file_path.ptr, null);
if (rc.errno()) |errno| {
log("uv readlink({s}) = {d}, [err]", .{ file_path, rc.int() });
return .{ .err = .{ .errno = errno, .syscall = .readlink, .path = file_path } };
} else {
// Seems like `rc` does not contain the size?
bun.assert(rc.int() == 0);
const slice = bun.span(req.ptrAs([*:0]u8));
if (slice.len > buf.len) {
log("uv readlink({s}) = {d}, {s} TRUNCATED", .{ file_path, rc.int(), slice });
return .{ .err = .{ .errno = @intFromEnum(bun.sys.E.NOMEM), .syscall = .readlink, .path = file_path } };
}
log("uv readlink({s}) = {d}, {s}", .{ file_path, rc.int(), slice });
@memcpy(buf[0..slice.len], slice);
buf[slice.len] = 0;
return .{ .result = buf[0..slice.len :0] };
}
}
pub fn rename(from: [:0]const u8, to: [:0]const u8) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_rename(uv.Loop.get(), &req, from.ptr, to.ptr, null);
log("uv rename({s}, {s}) = {d}", .{ from, to, rc.int() });
return if (rc.errno()) |errno|
// which one goes in the .path field?
.{ .err = .{ .errno = errno, .syscall = .rename } }
else
.success;
}
pub fn link(from: [:0]const u8, to: [:0]const u8) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_link(uv.Loop.get(), &req, from.ptr, to.ptr, null);
log("uv link({s}, {s}) = {d}", .{ from, to, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .link, .path = from, .dest = to } }
else
.success;
}
pub fn symlinkUV(target: [:0]const u8, new_path: [:0]const u8, flags: c_int) Maybe(void) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_symlink(uv.Loop.get(), &req, target.ptr, new_path.ptr, flags, null);
log("uv symlink({s}, {s}) = {d}", .{ target, new_path, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .symlink } }
else
.success;
}
pub fn ftruncate(fd: FileDescriptor, size: isize) Maybe(void) {
const uv_fd = fd.uv();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_ftruncate(uv.Loop.get(), &req, uv_fd, size, null);
log("uv ftruncate({}, {d}) = {d}", .{ uv_fd, size, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .ftruncate, .fd = fd } }
else
.success;
}
pub fn fstat(fd: FileDescriptor) Maybe(bun.Stat) {
const uv_fd = fd.uv();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_fstat(uv.Loop.get(), &req, uv_fd, null);
log("uv fstat({}) = {d}", .{ uv_fd, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .fstat, .fd = fd } }
else
.{ .result = req.statbuf };
}
pub fn fdatasync(fd: FileDescriptor) Maybe(void) {
const uv_fd = fd.uv();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_fdatasync(uv.Loop.get(), &req, uv_fd, null);
log("uv fdatasync({}) = {d}", .{ uv_fd, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .fdatasync, .fd = fd } }
else
.success;
}
pub fn fsync(fd: FileDescriptor) Maybe(void) {
const uv_fd = fd.uv();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_fsync(uv.Loop.get(), &req, uv_fd, null);
log("uv fsync({d}) = {d}", .{ uv_fd, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .fsync, .fd = fd } }
else
.success;
}
pub fn stat(path: [:0]const u8) Maybe(bun.Stat) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_stat(uv.Loop.get(), &req, path.ptr, null);
log("uv stat({s}) = {d}", .{ path, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .stat, .path = path } }
else
.{ .result = req.statbuf };
}
pub fn lstat(path: [:0]const u8) Maybe(bun.Stat) {
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_lstat(uv.Loop.get(), &req, path.ptr, null);
log("uv lstat({s}) = {d}", .{ path, rc.int() });
return if (rc.errno()) |errno|
.{ .err = .{ .errno = errno, .syscall = .lstat, .path = path } }
else
.{ .result = req.statbuf };
}
pub fn close(fd: FileDescriptor) ?bun.sys.Error {
return fd.closeAllowingBadFileDescriptor(@returnAddress());
}
pub fn closeAllowingStdoutAndStderr(fd: FileDescriptor) ?bun.sys.Error {
return fd.closeAllowingStandardIo(@returnAddress());
}
pub fn preadv(fd: FileDescriptor, bufs: []const bun.PlatformIOVec, position: i64) Maybe(usize) {
const uv_fd = fd.uv();
comptime bun.assert(bun.PlatformIOVec == uv.uv_buf_t);
const debug_timer = bun.Output.DebugTimer.start();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_read(
uv.Loop.get(),
&req,
uv_fd,
bufs.ptr,
@intCast(bufs.len),
position,
null,
);
if (Environment.isDebug) {
var total_bytes: usize = 0;
for (bufs) |buf| {
total_bytes += buf.len;
}
log("uv read({}, {d} total bytes) = {d} ({f})", .{ uv_fd, total_bytes, rc.int(), debug_timer });
}
if (rc.errno()) |errno| {
return .{ .err = .{ .errno = errno, .fd = fd, .syscall = .read } };
} else {
return .{ .result = @as(usize, @intCast(rc.int())) };
}
}
pub fn pwritev(fd: FileDescriptor, bufs: []const bun.PlatformIOVecConst, position: i64) Maybe(usize) {
const uv_fd = fd.uv();
comptime bun.assert(bun.PlatformIOVec == uv.uv_buf_t);
const debug_timer = bun.Output.DebugTimer.start();
var req: uv.fs_t = uv.fs_t.uninitialized;
defer req.deinit();
const rc = uv.uv_fs_write(
uv.Loop.get(),
&req,
uv_fd,
bufs.ptr,
@intCast(bufs.len),
position,
null,
);
if (Environment.isDebug) {
var total_bytes: usize = 0;
for (bufs) |buf| {
total_bytes += buf.len;
}
log("uv write({}, {d} total bytes) = {d} ({f})", .{ uv_fd, total_bytes, rc.int(), debug_timer });
}
if (rc.errno()) |errno| {
return .{ .err = .{ .errno = errno, .fd = fd, .syscall = .write } };
} else {
return .{ .result = @as(usize, @intCast(rc.int())) };
}
}
pub inline fn readv(fd: FileDescriptor, bufs: []bun.PlatformIOVec) Maybe(usize) {
return preadv(fd, bufs, -1);
}
pub inline fn pread(fd: FileDescriptor, buf: []u8, position: i64) Maybe(usize) {
var bufs: [1]bun.PlatformIOVec = .{bun.platformIOVecCreate(buf)};
return preadv(fd, &bufs, position);
}
pub inline fn read(fd: FileDescriptor, buf: []u8) Maybe(usize) {
var bufs: [1]bun.PlatformIOVec = .{bun.platformIOVecCreate(buf)};
return readv(fd, &bufs);
}
pub inline fn writev(fd: FileDescriptor, bufs: []bun.PlatformIOVec) Maybe(usize) {
return pwritev(fd, bufs, -1);
}
pub inline fn pwrite(fd: FileDescriptor, buf: []const u8, position: i64) Maybe(usize) {
var bufs: [1]bun.PlatformIOVec = .{bun.platformIOVecCreate(buf)};
return pwritev(fd, &bufs, position);
}
pub inline fn write(fd: FileDescriptor, buf: []const u8) Maybe(usize) {
var bufs: [1]bun.PlatformIOVec = .{bun.platformIOVecCreate(buf)};
return writev(fd, &bufs);
}
pub const Tag = @import("./sys.zig").Tag;
const bun = @import("bun");
const Environment = bun.Environment;
const FileDescriptor = bun.FileDescriptor;
const Maybe = bun.sys.Maybe;
const uv = bun.windows.libuv;