mirror of
https://github.com/oven-sh/bun
synced 2026-02-10 10:58:56 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
206 lines
6.2 KiB
Zig
206 lines
6.2 KiB
Zig
pub const bun = @import("./bun.zig");
|
|
|
|
const Output = bun.Output;
|
|
const Environment = bun.Environment;
|
|
|
|
// pub const panic = bun.crash_handler.panic;
|
|
pub const panic = recover.panic;
|
|
pub const std_options = std.Options{
|
|
.enable_segfault_handler = false,
|
|
};
|
|
|
|
pub const io_mode = .blocking;
|
|
|
|
comptime {
|
|
bun.assert(builtin.target.cpu.arch.endian() == .little);
|
|
}
|
|
|
|
pub extern "C" var _environ: ?*anyopaque;
|
|
pub extern "C" var environ: ?*anyopaque;
|
|
|
|
pub fn main() void {
|
|
// This should appear before we make any calls at all to libuv.
|
|
// So it's safest to put it very early in the main function.
|
|
if (Environment.isWindows) {
|
|
_ = bun.windows.libuv.uv_replace_allocator(
|
|
@ptrCast(&bun.mimalloc.mi_malloc),
|
|
@ptrCast(&bun.mimalloc.mi_realloc),
|
|
@ptrCast(&bun.mimalloc.mi_calloc),
|
|
@ptrCast(&bun.mimalloc.mi_free),
|
|
);
|
|
environ = @ptrCast(std.os.environ.ptr);
|
|
_environ = @ptrCast(std.os.environ.ptr);
|
|
}
|
|
|
|
bun.initArgv(bun.default_allocator) catch |err| {
|
|
Output.panic("Failed to initialize argv: {s}\n", .{@errorName(err)});
|
|
};
|
|
|
|
Output.Source.Stdio.init();
|
|
defer Output.flush();
|
|
bun.StackCheck.configureThread();
|
|
const exit_code = runTests();
|
|
bun.Global.exit(exit_code);
|
|
}
|
|
|
|
const Stats = struct {
|
|
pass: u32,
|
|
fail: u32,
|
|
leak: u32,
|
|
panic: u32,
|
|
start: i64,
|
|
|
|
fn init() Stats {
|
|
var stats = std.mem.zeroes(Stats);
|
|
stats.start = std.time.milliTimestamp();
|
|
return stats;
|
|
}
|
|
|
|
/// Time elapsed since start in milliseconds
|
|
fn elapsed(this: *const Stats) i64 {
|
|
return std.time.milliTimestamp() - this.start;
|
|
}
|
|
|
|
/// Total number of tests run
|
|
fn total(this: *const Stats) u32 {
|
|
return this.pass + this.fail + this.leak + this.panic;
|
|
}
|
|
|
|
fn exitCode(this: *const Stats) u8 {
|
|
var result: u8 = 0;
|
|
if (this.fail > 0) result |= 1;
|
|
if (this.leak > 0) result |= 2;
|
|
if (this.panic > 0) result |= 4;
|
|
return result;
|
|
}
|
|
};
|
|
|
|
fn runTests() u8 {
|
|
var stats = Stats.init();
|
|
var stderr = std.fs.File.stderr();
|
|
|
|
namebuf = std.heap.page_allocator.alloc(u8, namebuf_size) catch {
|
|
Output.panic("Failed to allocate name buffer", .{});
|
|
};
|
|
defer std.heap.page_allocator.free(namebuf);
|
|
|
|
const tests: []const TestFn = builtin.test_functions;
|
|
for (tests) |t| {
|
|
std.testing.allocator_instance = .{};
|
|
|
|
var did_lock = true;
|
|
stderr.lock(.exclusive) catch {
|
|
did_lock = false;
|
|
};
|
|
defer if (did_lock) stderr.unlock();
|
|
|
|
const start = std.time.milliTimestamp();
|
|
const result = recover.callForTest(t.func);
|
|
const elapsed = std.time.milliTimestamp() - start;
|
|
|
|
const name = extractName(t);
|
|
const memory_check = std.testing.allocator_instance.deinit();
|
|
|
|
if (result) |_| {
|
|
if (memory_check == .leak) {
|
|
Output.pretty("<yellow>leak</r> - {s} <i>({d}ms)</r>\n", .{ name, elapsed });
|
|
stats.leak += 1;
|
|
} else {
|
|
Output.pretty("<green>pass</r> - {s} <i>({d}ms)</r>\n", .{ name, elapsed });
|
|
stats.pass += 1;
|
|
}
|
|
} else |err| {
|
|
switch (err) {
|
|
error.Panic => {
|
|
Output.pretty("<magenta><b>panic</r> - {s} <i>({d}ms)</r>\n{s}", .{ t.name, elapsed, @errorName(err) });
|
|
stats.panic += 1;
|
|
},
|
|
else => {
|
|
Output.pretty("<red>fail</r> - {s} <i>({d}ms)</r>\n{s}", .{ t.name, elapsed, @errorName(err) });
|
|
stats.fail += 1;
|
|
},
|
|
}
|
|
}
|
|
}
|
|
|
|
const total = stats.total();
|
|
const total_time = stats.elapsed();
|
|
|
|
if (total == stats.pass) {
|
|
Output.pretty("\n<green>All tests passed</r>\n", .{});
|
|
} else {
|
|
Output.pretty("\n<green>{d}</r> passed", .{stats.pass});
|
|
if (stats.fail > 0)
|
|
Output.pretty(", <red>{d}</r> failed", .{stats.fail})
|
|
else
|
|
Output.pretty(", 0 failed", .{});
|
|
if (stats.leak > 0) Output.pretty(", <yellow>{d}</r> leaked", .{stats.leak});
|
|
if (stats.panic > 0) Output.pretty(", <magenta>{d}</r> panicked", .{stats.panic});
|
|
}
|
|
|
|
Output.pretty("\n\tRan <b>{d}</r> tests in <b>{d}</r>ms\n\n", .{ total, total_time });
|
|
return stats.exitCode();
|
|
}
|
|
|
|
// heap-allocated on start to avoid increasing binary size
|
|
threadlocal var namebuf: []u8 = undefined;
|
|
const namebuf_size = 4096;
|
|
comptime {
|
|
std.debug.assert(std.math.isPowerOfTwo(namebuf_size));
|
|
}
|
|
|
|
fn extractName(t: TestFn) []const u8 {
|
|
inline for (.{ ".test.", ".decltest." }) |test_sep| {
|
|
if (std.mem.lastIndexOf(u8, t.name, test_sep)) |marker| {
|
|
const prefix = t.name[0..marker];
|
|
const test_name = t.name[marker + test_sep.len ..];
|
|
const full_name = std.fmt.bufPrint(namebuf, "{s}\t{s}", .{ prefix, test_name }) catch @panic("name buffer too small");
|
|
return full_name;
|
|
}
|
|
}
|
|
|
|
return t.name;
|
|
}
|
|
|
|
pub const overrides = struct {
|
|
pub const mem = struct {
|
|
extern "C" fn wcslen(s: [*:0]const u16) usize;
|
|
|
|
pub fn indexOfSentinel(comptime T: type, comptime sentinel: T, p: [*:sentinel]const T) usize {
|
|
if (comptime T == u16 and sentinel == 0 and Environment.isWindows) {
|
|
return wcslen(p);
|
|
}
|
|
|
|
if (comptime T == u8 and sentinel == 0) {
|
|
return bun.C.strlen(p);
|
|
}
|
|
|
|
var i: usize = 0;
|
|
while (p[i] != sentinel) {
|
|
i += 1;
|
|
}
|
|
return i;
|
|
}
|
|
};
|
|
};
|
|
|
|
pub export fn Bun__panic(msg: [*]const u8, len: usize) noreturn {
|
|
Output.panic("{s}", .{msg[0..len]});
|
|
}
|
|
|
|
comptime {
|
|
_ = bun.bake.production.BakeProdResolve;
|
|
_ = bun.bake.production.BakeProdLoad;
|
|
|
|
_ = bun.bun_js.Bun__onRejectEntryPointResult;
|
|
_ = bun.bun_js.Bun__onResolveEntryPointResult;
|
|
_ = &@import("./bun.js/node/buffer.zig").BufferVectorized;
|
|
@import("./cli/upgrade_command.zig").@"export"();
|
|
@import("./cli/test_command.zig").@"export"();
|
|
}
|
|
|
|
const builtin = @import("builtin");
|
|
const recover = @import("./test/recover.zig");
|
|
const std = @import("std");
|
|
const TestFn = std.builtin.TestFn;
|