mirror of
https://github.com/oven-sh/bun
synced 2026-02-10 02:48:50 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
263 lines
8.6 KiB
Zig
263 lines
8.6 KiB
Zig
fn SinglyLinkedList(comptime T: type, comptime Parent: type) type {
|
|
return struct {
|
|
const Self = @This();
|
|
|
|
/// Node inside the linked list wrapping the actual data.
|
|
pub const Node = struct {
|
|
next: ?*Node = null,
|
|
allocator: std.mem.Allocator,
|
|
data: T,
|
|
|
|
pub const Data = T;
|
|
|
|
/// Insert a new node after the current one.
|
|
///
|
|
/// Arguments:
|
|
/// new_node: Pointer to the new node to insert.
|
|
pub fn insertAfter(node: *Node, new_node: *Node) void {
|
|
new_node.next = node.next;
|
|
node.next = new_node;
|
|
}
|
|
|
|
/// Remove a node from the list.
|
|
///
|
|
/// Arguments:
|
|
/// node: Pointer to the node to be removed.
|
|
/// Returns:
|
|
/// node removed
|
|
pub fn removeNext(node: *Node) ?*Node {
|
|
const next_node = node.next orelse return null;
|
|
node.next = next_node.next;
|
|
return next_node;
|
|
}
|
|
|
|
/// Iterate over the singly-linked list from this node, until the final node is found.
|
|
/// This operation is O(N).
|
|
pub fn findLast(node: *Node) *Node {
|
|
var it = node;
|
|
while (true) {
|
|
it = it.next orelse return it;
|
|
}
|
|
}
|
|
|
|
/// Iterate over each next node, returning the count of all nodes except the starting one.
|
|
/// This operation is O(N).
|
|
pub fn countChildren(node: *const Node) usize {
|
|
var count: usize = 0;
|
|
var it: ?*const Node = node.next;
|
|
while (it) |n| : (it = n.next) {
|
|
count += 1;
|
|
}
|
|
return count;
|
|
}
|
|
|
|
pub inline fn release(node: *Node) void {
|
|
Parent.release(node);
|
|
}
|
|
};
|
|
|
|
first: ?*Node = null,
|
|
|
|
/// Insert a new node at the head.
|
|
///
|
|
/// Arguments:
|
|
/// new_node: Pointer to the new node to insert.
|
|
pub fn prepend(list: *Self, new_node: *Node) void {
|
|
new_node.next = list.first;
|
|
list.first = new_node;
|
|
}
|
|
|
|
/// Remove a node from the list.
|
|
///
|
|
/// Arguments:
|
|
/// node: Pointer to the node to be removed.
|
|
pub fn remove(list: *Self, node: *Node) void {
|
|
if (list.first == node) {
|
|
list.first = node.next;
|
|
} else {
|
|
var current_elm = list.first.?;
|
|
while (current_elm.next != node) {
|
|
current_elm = current_elm.next.?;
|
|
}
|
|
current_elm.next = node.next;
|
|
}
|
|
}
|
|
|
|
/// Remove and return the first node in the list.
|
|
///
|
|
/// Returns:
|
|
/// A pointer to the first node in the list.
|
|
pub fn popFirst(list: *Self) ?*Node {
|
|
const first = list.first orelse return null;
|
|
list.first = first.next;
|
|
return first;
|
|
}
|
|
|
|
/// Iterate over all nodes, returning the count.
|
|
/// This operation is O(N).
|
|
pub fn len(list: Self) usize {
|
|
if (list.first) |n| {
|
|
return 1 + n.countChildren();
|
|
} else {
|
|
return 0;
|
|
}
|
|
}
|
|
};
|
|
}
|
|
|
|
const log_allocations = false;
|
|
|
|
pub fn ObjectPool(
|
|
comptime Type: type,
|
|
comptime Init: (?fn (allocator: std.mem.Allocator) anyerror!Type),
|
|
comptime threadsafe: bool,
|
|
comptime max_count: comptime_int,
|
|
) type {
|
|
return struct {
|
|
const Pool = @This();
|
|
const LinkedList = SinglyLinkedList(Type, Pool);
|
|
pub const List = LinkedList;
|
|
pub const Node = LinkedList.Node;
|
|
const MaxCountInt = std.math.IntFittingRange(0, max_count);
|
|
const DataStruct = struct {
|
|
list: LinkedList = undefined,
|
|
loaded: bool = false,
|
|
count: MaxCountInt = 0,
|
|
};
|
|
|
|
// We want this to be global
|
|
// but we don't want to create 3 global variables per pool
|
|
// instead, we create one global variable per pool
|
|
const DataStructNonThreadLocal = if (threadsafe) void else DataStruct;
|
|
const DataStructThreadLocal = if (!threadsafe) void else DataStruct;
|
|
threadlocal var data_threadlocal: DataStructThreadLocal = DataStructThreadLocal{};
|
|
var data__: DataStructNonThreadLocal = DataStructNonThreadLocal{};
|
|
inline fn data() *DataStruct {
|
|
if (comptime threadsafe) {
|
|
return &data_threadlocal;
|
|
}
|
|
|
|
if (comptime !threadsafe) {
|
|
return &data__;
|
|
}
|
|
|
|
unreachable;
|
|
}
|
|
|
|
pub fn full() bool {
|
|
if (comptime max_count == 0) return false;
|
|
return data().loaded and data().count >= max_count;
|
|
}
|
|
|
|
pub fn has() bool {
|
|
return data().loaded and data().list.first != null;
|
|
}
|
|
|
|
pub fn push(allocator: std.mem.Allocator, pooled: Type) void {
|
|
if (comptime @import("./env.zig").allow_assert)
|
|
bun.assert(!full());
|
|
|
|
const new_node = allocator.create(LinkedList.Node) catch unreachable;
|
|
new_node.* = LinkedList.Node{
|
|
.allocator = allocator,
|
|
.data = pooled,
|
|
};
|
|
release(new_node);
|
|
}
|
|
|
|
pub fn getIfExists() ?*LinkedList.Node {
|
|
if (!data().loaded) {
|
|
return null;
|
|
}
|
|
|
|
var node = data().list.popFirst() orelse return null;
|
|
if (std.meta.hasFn(Type, "reset")) node.data.reset();
|
|
if (comptime max_count > 0) data().count -|= 1;
|
|
|
|
return node;
|
|
}
|
|
|
|
pub fn first(allocator: std.mem.Allocator) *Type {
|
|
return &get(allocator).data;
|
|
}
|
|
|
|
pub fn get(allocator: std.mem.Allocator) *LinkedList.Node {
|
|
if (data().loaded) {
|
|
if (data().list.popFirst()) |node| {
|
|
if (comptime std.meta.hasFn(Type, "reset")) node.data.reset();
|
|
if (comptime max_count > 0) data().count -|= 1;
|
|
return node;
|
|
}
|
|
}
|
|
|
|
if (comptime log_allocations) std.fs.File.stderr().writeAll(comptime std.fmt.comptimePrint("Allocate {s} - {d} bytes\n", .{ @typeName(Type), @sizeOf(Type) })) catch {};
|
|
|
|
const new_node = allocator.create(LinkedList.Node) catch unreachable;
|
|
new_node.* = LinkedList.Node{
|
|
.allocator = allocator,
|
|
.data = if (comptime Init) |init_|
|
|
(init_(
|
|
allocator,
|
|
) catch unreachable)
|
|
else
|
|
undefined,
|
|
};
|
|
|
|
return new_node;
|
|
}
|
|
|
|
pub fn releaseValue(value: *Type) void {
|
|
@as(*LinkedList.Node, @fieldParentPtr("data", value)).release();
|
|
}
|
|
|
|
pub fn release(node: *LinkedList.Node) void {
|
|
if (comptime max_count > 0) {
|
|
if (data().count >= max_count) {
|
|
if (comptime log_allocations) std.fs.File.stderr().writeAll(comptime std.fmt.comptimePrint("Free {s} - {d} bytes\n", .{ @typeName(Type), @sizeOf(Type) })) catch {};
|
|
destroyNode(node);
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (comptime max_count > 0) data().count +|= 1;
|
|
|
|
if (data().loaded) {
|
|
data().list.prepend(node);
|
|
return;
|
|
}
|
|
|
|
data().list = LinkedList{ .first = node };
|
|
data().loaded = true;
|
|
}
|
|
|
|
pub fn deleteAll() void {
|
|
var dat = data();
|
|
if (!dat.loaded) {
|
|
return;
|
|
}
|
|
dat.loaded = false;
|
|
dat.count = 0;
|
|
var next = dat.list.first;
|
|
dat.list.first = null;
|
|
while (next) |node| {
|
|
next = node.next;
|
|
destroyNode(node);
|
|
}
|
|
}
|
|
|
|
fn destroyNode(node: *LinkedList.Node) void {
|
|
// TODO: Once a generic-allocator version of `BabyList` is added, change
|
|
// `ByteListPool` in `bun.js/webcore.zig` to use a managed default-allocator
|
|
// `ByteList` instead, and then get rid of the special-casing for `ByteList`
|
|
// here. This will fix a memory leak.
|
|
if (comptime Type != bun.ByteList) {
|
|
bun.memory.deinit(&node.data);
|
|
}
|
|
node.allocator.destroy(node);
|
|
}
|
|
};
|
|
}
|
|
|
|
const bun = @import("bun");
|
|
const std = @import("std");
|