## Summary - When `http.ClientRequest.write()` was called more than once (streaming data in chunks), Bun was stripping the explicitly-set `Content-Length` header and switching to `Transfer-Encoding: chunked`. Node.js preserves `Content-Length` in all cases when it's explicitly set by the user. - This caused real-world failures (e.g. Vercel CLI file uploads) where large binary files streamed via multiple `write()` calls had their Content-Length stripped, causing server-side "invalid file size" errors. - The fix preserves the user's explicit `Content-Length` for streaming request bodies and skips chunked transfer encoding framing when `Content-Length` is set. Closes #27061 Closes #26976 ## Changes - **`src/http.zig`**: When a streaming request body has an explicit `Content-Length` header set by the user, use that instead of adding `Transfer-Encoding: chunked`. Added `is_streaming_request_body_with_content_length` flag to track this. - **`src/bun.js/webcore/fetch/FetchTasklet.zig`**: Skip chunked transfer encoding framing (`writeRequestData`) and the chunked terminator (`writeEndRequest`) when the request has an explicit `Content-Length`. - **`test/regression/issue/27061.test.ts`**: Regression test covering multiple write patterns (2x write, write+end(data), 3x write) plus validation that chunked encoding is still used when no `Content-Length` is set. ## Test plan - [x] New regression test passes with `bun bd test test/regression/issue/27061.test.ts` - [x] Test fails with `USE_SYSTEM_BUN=1` (confirms the bug exists in current release) - [x] Existing `test/js/node/http/` tests pass (no regressions) - [x] Fetch file upload tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com>
Tests
Finding tests
Tests are located in the test/ directory and are organized using the following structure:
test/js/- tests for JavaScript APIs.cli/- tests for commands, configs, and stdout.bundler/- tests for the transpiler/bundler.regression/- tests that reproduce a specific issue.harness.ts- utility functions that can be imported from any test.
The tests in test/js/ directory are further categorized by the type of API.
test/js/bun/- tests forBun-specific APIs.node/- tests for Node.js APIs.web/- tests for Web APIs, likefetch().first_party/- tests for npm packages that are built-in, likeundici.third_party/- tests for npm packages that are not built-in, but are popular, likeesbuild.
Running tests
To run a test, use Bun's built-in test command: bun test.
bun test # Run all tests
bun test js/bun # Only run tests in a directory
bun test sqlite.test.ts # Only run a specific test
If you encounter lots of errors, try running bun install, then trying again.
Writing tests
Tests are written in TypeScript (preferred) or JavaScript using Jest's describe(), test(), and expect() APIs.
import { describe, test, expect } from "bun:test";
import { gcTick } from "harness";
describe("TextEncoder", () => {
test("can encode a string", async () => {
const encoder = new TextEncoder();
const actual = encoder.encode("bun");
await gcTick();
expect(actual).toBe(new Uint8Array([0x62, 0x75, 0x6E]));
});
});
If you are fixing a bug that was reported from a GitHub issue, remember to add a test in the test/regression/ directory.
// test/regression/issue/02005.test.ts
import { it, expect } from "bun:test";
it("regex literal should work with non-latin1", () => {
const text = "这是一段要替换的文字";
expect(text.replace(new RegExp("要替换"), "")).toBe("这是一段的文字");
expect(text.replace(/要替换/, "")).toBe("这是一段的文字");
});
In the future, a bot will automatically close or re-open issues when a regression is detected or resolved.
Zig tests
These tests live in various .zig files throughout Bun's codebase, leveraging Zig's builtin test keyword.
Currently, they're not run automatically nor is there a simple way to run all of them. We will make this better soon.
TypeScript
Test files should be written in TypeScript. The types in packages/bun-types should be updated to support all new APIs. Changes to the .d.ts files in packages/bun-types will be immediately reflected in test files; no build step is necessary.
Writing a test will often require using invalid syntax, e.g. when checking for errors when an invalid input is passed to a function. TypeScript provides a number of escape hatches here.
// @ts-expect-error- This should be your first choice. It tells TypeScript that the next line should fail typechecking.// @ts-ignore- Ignore the next line entirely.// @ts-nocheck- Put this at the top of the file to disable typechecking on the entire file. Useful for autogenerated test files, or when ignoring/disabling type checks an a per-line basis is too onerous.