Files
bun.sh/src/cli/pm_trusted_command.zig
robobun 7dcd49f832 fix(install): only apply default trusted dependencies to npm packages (#25163)
## Summary
- The default trusted dependencies list should only apply to packages
installed from npm
- Non-npm sources (file:, link:, git:, github:) now require explicit
trustedDependencies
- This prevents malicious packages from spoofing trusted names through
local paths or git repos

## Test plan
- [x] Added test: file: dependency named "esbuild" does NOT auto-run
postinstall scripts
- [x] Added test: file: dependency runs scripts when explicitly added to
trustedDependencies
- [x] Verified tests fail with system bun (old behavior) and pass with
new build
- [x] Build compiles successfully

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
2025-12-11 17:44:41 -08:00

465 lines
19 KiB
Zig

const DepIdSet = std.ArrayHashMapUnmanaged(DependencyID, void, ArrayIdentityContext, false);
pub const DefaultTrustedCommand = struct {
pub fn exec() !void {
Output.print("Default trusted dependencies ({d}):\n", .{Lockfile.default_trusted_dependencies_list.len});
for (Lockfile.default_trusted_dependencies_list) |name| {
Output.pretty(" <d>-<r> {s}\n", .{name});
}
return;
}
};
pub const UntrustedCommand = struct {
pub fn exec(ctx: Command.Context, pm: *PackageManager, args: [][:0]u8) !void {
_ = args;
Output.prettyError("<r><b>bun pm untrusted <r><d>v" ++ Global.package_json_version_with_sha ++ "<r>\n\n", .{});
Output.flush();
const load_lockfile = pm.lockfile.loadFromCwd(pm, ctx.allocator, ctx.log, true);
PackageManagerCommand.handleLoadLockfileErrors(load_lockfile, pm);
try pm.updateLockfileIfNeeded(load_lockfile);
const packages = pm.lockfile.packages.slice();
const scripts: []Lockfile.Package.Scripts = packages.items(.scripts);
const resolutions: []Install.Resolution = packages.items(.resolution);
const buf = pm.lockfile.buffers.string_bytes.items;
var untrusted_dep_ids: std.AutoArrayHashMapUnmanaged(DependencyID, void) = .{};
defer untrusted_dep_ids.deinit(ctx.allocator);
// loop through dependencies and get trusted and untrusted deps with lifecycle scripts
for (pm.lockfile.buffers.dependencies.items, 0..) |dep, i| {
const dep_id: DependencyID = @intCast(i);
const package_id = pm.lockfile.buffers.resolutions.items[dep_id];
if (package_id == Install.invalid_package_id) continue;
// called alias because a dependency name is not always the package name
const alias = dep.name.slice(buf);
const resolution = &resolutions[package_id];
if (!pm.lockfile.hasTrustedDependency(alias, resolution)) {
try untrusted_dep_ids.put(ctx.allocator, dep_id, {});
}
}
if (untrusted_dep_ids.count() == 0) {
printZeroUntrustedDependenciesFound();
return;
}
var untrusted_deps: std.AutoArrayHashMapUnmanaged(DependencyID, Lockfile.Package.Scripts.List) = .{};
defer untrusted_deps.deinit(ctx.allocator);
var tree_iterator = Lockfile.Tree.Iterator(.node_modules).init(pm.lockfile);
var node_modules_path: bun.AbsPath(.{ .sep = .auto }) = .initTopLevelDir();
defer node_modules_path.deinit();
while (tree_iterator.next(null)) |node_modules| {
const node_modules_path_save = node_modules_path.save();
defer node_modules_path_save.restore();
node_modules_path.append(node_modules.relative_path);
for (node_modules.dependencies) |dep_id| {
if (untrusted_dep_ids.contains(dep_id)) {
const dep = pm.lockfile.buffers.dependencies.items[dep_id];
const alias = dep.name.slice(buf);
const package_id = pm.lockfile.buffers.resolutions.items[dep_id];
if (package_id >= packages.len) {
continue;
}
const resolution = &resolutions[package_id];
var package_scripts = scripts[package_id];
const folder_name_save = node_modules_path.save();
defer folder_name_save.restore();
node_modules_path.append(alias);
const maybe_scripts_list = package_scripts.getList(
pm.log,
pm.lockfile,
&node_modules_path,
alias,
resolution,
) catch |err| {
if (err == error.ENOENT) continue;
return err;
};
if (maybe_scripts_list) |scripts_list| {
if (scripts_list.total == 0 or scripts_list.items.len == 0) continue;
try untrusted_deps.put(ctx.allocator, dep_id, scripts_list);
}
}
}
}
if (untrusted_deps.count() == 0) {
printZeroUntrustedDependenciesFound();
return;
}
var iter = untrusted_deps.iterator();
while (iter.next()) |entry| {
const dep_id = entry.key_ptr.*;
const scripts_list = entry.value_ptr.*;
const package_id = pm.lockfile.buffers.resolutions.items[dep_id];
const resolution = pm.lockfile.packages.items(.resolution)[package_id];
scripts_list.printScripts(&resolution, buf, .untrusted);
Output.pretty("\n", .{});
}
Output.pretty(
\\These dependencies had their lifecycle scripts blocked during install.
\\
\\If you trust them and wish to run their scripts, use <d>`<r><blue>bun pm trust<r><d>`<r>.
\\
, .{});
}
fn printZeroUntrustedDependenciesFound() void {
Output.pretty(
\\Found <b>0<r> untrusted dependencies with scripts.
\\
\\This means all packages with scripts are in "trustedDependencies" or none of your dependencies have scripts.
\\
\\For more information, visit <magenta>https://bun.com/docs/install/lifecycle#trusteddependencies<r>
\\
, .{});
}
};
pub const TrustCommand = struct {
pub const Sorter = struct {
pub fn lessThan(_: void, rhs: string, lhs: string) bool {
return std.mem.order(u8, rhs, lhs) == .lt;
}
};
fn errorExpectedArgs() noreturn {
Output.errGeneric("expected package names(s) or --all", .{});
Global.crash();
}
fn printErrorZeroUntrustedDependenciesFound(trust_all: bool, packages_to_trust: []const string) void {
Output.print("\n", .{});
if (trust_all) {
Output.errGeneric("0 scripts ran. This means all dependencies are already trusted or none have scripts.", .{});
} else {
Output.errGeneric("0 scripts ran. The following packages are already trusted, don't have scripts to run, or don't exist:\n\n", .{});
for (packages_to_trust) |arg| {
Output.prettyError(" <d>-<r> {s}\n", .{arg});
}
}
}
pub fn exec(ctx: Command.Context, pm: *PackageManager, args: [][:0]u8) !void {
Output.prettyError("<r><b>bun pm trust <r><d>v" ++ Global.package_json_version_with_sha ++ "<r>\n", .{});
Output.flush();
if (args.len == 2) errorExpectedArgs();
const load_lockfile = pm.lockfile.loadFromCwd(pm, ctx.allocator, ctx.log, true);
PackageManagerCommand.handleLoadLockfileErrors(load_lockfile, pm);
try pm.updateLockfileIfNeeded(load_lockfile);
var packages_to_trust: std.ArrayListUnmanaged(string) = .{};
defer packages_to_trust.deinit(ctx.allocator);
try packages_to_trust.ensureUnusedCapacity(ctx.allocator, args[2..].len);
for (args[2..]) |arg| {
if (arg.len > 0 and arg[0] != '-') packages_to_trust.appendAssumeCapacity(arg);
}
const trust_all = strings.leftHasAnyInRight(args, &.{ "-a", "--all" });
if (!trust_all and packages_to_trust.items.len == 0) errorExpectedArgs();
const buf = pm.lockfile.buffers.string_bytes.items;
const packages = pm.lockfile.packages.slice();
const resolutions: []Install.Resolution = packages.items(.resolution);
const scripts: []Lockfile.Package.Scripts = packages.items(.scripts);
var untrusted_dep_ids: DepIdSet = .{};
defer untrusted_dep_ids.deinit(ctx.allocator);
for (pm.lockfile.buffers.dependencies.items, pm.lockfile.buffers.resolutions.items, 0..) |dep, package_id, i| {
const dep_id: u32 = @intCast(i);
if (package_id == Install.invalid_package_id) continue;
const alias = dep.name.slice(buf);
const resolution = &resolutions[package_id];
if (!pm.lockfile.hasTrustedDependency(alias, resolution)) {
try untrusted_dep_ids.put(ctx.allocator, dep_id, {});
}
}
if (untrusted_dep_ids.count() == 0) {
printErrorZeroUntrustedDependenciesFound(trust_all, packages_to_trust.items);
Global.crash();
}
// Instead of running them right away, we group scripts by depth in the node_modules
// file structure, then run them starting at max depth. This ensures lifecycle scripts are run
// in the correct order as they would during a normal install
var tree_iter = Lockfile.Tree.Iterator(.node_modules).init(pm.lockfile);
var node_modules_path: bun.AbsPath(.{ .sep = .auto }) = .initTopLevelDir();
defer node_modules_path.deinit();
var package_names_to_add: bun.StringArrayHashMapUnmanaged(void) = .{};
var scripts_at_depth: std.AutoArrayHashMapUnmanaged(usize, std.ArrayListUnmanaged(struct {
package_id: PackageID,
scripts_list: Lockfile.Package.Scripts.List,
skip: bool,
})) = .{};
var scripts_count: usize = 0;
while (tree_iter.next(null)) |node_modules| {
const node_modules_path_save = node_modules_path.save();
defer node_modules_path_save.restore();
node_modules_path.append(node_modules.relative_path);
var node_modules_dir = bun.openDir(std.fs.cwd(), node_modules.relative_path) catch |err| {
if (err == error.ENOENT) continue;
return err;
};
defer node_modules_dir.close();
for (node_modules.dependencies) |dep_id| {
if (untrusted_dep_ids.contains(dep_id)) {
const dep = pm.lockfile.buffers.dependencies.items[dep_id];
const alias = dep.name.slice(buf);
const package_id = pm.lockfile.buffers.resolutions.items[dep_id];
if (package_id >= packages.len) {
continue;
}
const resolution = &resolutions[package_id];
var package_scripts = scripts[package_id];
var folder_save = node_modules_path.save();
defer folder_save.restore();
node_modules_path.append(alias);
const maybe_scripts_list = package_scripts.getList(
pm.log,
pm.lockfile,
&node_modules_path,
alias,
resolution,
) catch |err| {
if (err == error.ENOENT) continue;
return err;
};
if (maybe_scripts_list) |scripts_list| {
const skip = brk: {
if (trust_all) break :brk false;
for (packages_to_trust.items) |package_name_from_cli| {
if (strings.eqlLong(package_name_from_cli, alias, true) and !pm.lockfile.hasTrustedDependency(alias, resolution)) {
break :brk false;
}
}
break :brk true;
};
// even if it is skipped we still add to scripts_at_depth for logging later
const entry = try scripts_at_depth.getOrPut(ctx.allocator, node_modules.depth);
if (!entry.found_existing) entry.value_ptr.* = .{};
try entry.value_ptr.append(ctx.allocator, .{
.package_id = package_id,
.scripts_list = scripts_list,
.skip = skip,
});
if (!skip) {
try package_names_to_add.put(ctx.allocator, try ctx.allocator.dupe(u8, alias), {});
scripts_count += scripts_list.total;
}
}
}
}
}
if (scripts_at_depth.count() == 0 or package_names_to_add.count() == 0) {
printErrorZeroUntrustedDependenciesFound(trust_all, packages_to_trust.items);
Global.crash();
}
var root_node: *Progress.Node = undefined;
var scripts_node: Progress.Node = undefined;
var progress = &pm.progress;
if (pm.options.log_level.showProgress()) {
progress.supports_ansi_escape_codes = Output.enable_ansi_colors_stderr;
root_node = progress.start("", 0);
scripts_node = root_node.start(PackageManager.ProgressStrings.script(), scripts_count);
pm.scripts_node = &scripts_node;
}
{
var iter = std.mem.reverseIterator(scripts_at_depth.values());
while (iter.next()) |entry| {
for (entry.items) |info| {
if (info.skip) continue;
while (LifecycleScriptSubprocess.alive_count.load(.monotonic) >= pm.options.max_concurrent_lifecycle_scripts) {
if (pm.options.log_level.isVerbose()) {
if (PackageManager.hasEnoughTimePassedBetweenWaitingMessages()) Output.prettyErrorln("<d>[PackageManager]<r> waiting for {d} scripts\n", .{LifecycleScriptSubprocess.alive_count.load(.monotonic)});
}
pm.sleep();
}
const output_in_foreground = false;
const optional = false;
try pm.spawnPackageLifecycleScripts(
ctx,
info.scripts_list,
optional,
output_in_foreground,
null,
);
if (pm.options.log_level.showProgress()) {
scripts_node.activate();
progress.refresh();
}
}
while (pm.pending_lifecycle_script_tasks.load(.monotonic) > 0) {
pm.sleep();
}
}
}
if (pm.options.log_level.showProgress()) {
progress.root.end();
progress.* = .{};
}
const package_json_contents = try pm.root_package_json_file.readToEndAlloc(ctx.allocator, try pm.root_package_json_file.getEndPos());
defer ctx.allocator.free(package_json_contents);
const package_json_source = logger.Source.initPathString(PackageManager.root_package_json_path, package_json_contents);
var package_json = bun.json.parseUTF8(&package_json_source, ctx.log, ctx.allocator) catch |err| {
ctx.log.print(Output.errorWriter()) catch {};
Output.errGeneric("failed to parse package.json: {s}", .{@errorName(err)});
Global.crash();
};
// now add the package names to lockfile.trustedDependencies and package.json `trustedDependencies`
const names = package_names_to_add.keys();
if (comptime Environment.allow_assert) {
bun.assertWithLocation(names.len > 0, @src());
}
// could be null if these are the first packages to be trusted
if (pm.lockfile.trusted_dependencies == null) pm.lockfile.trusted_dependencies = .{};
var total_scripts_ran: usize = 0;
var total_packages_with_scripts: usize = 0;
var total_skipped_packages: usize = 0;
Output.print("\n", .{});
{
var iter = std.mem.reverseIterator(scripts_at_depth.values());
while (iter.next()) |entry| {
for (entry.items) |info| {
const resolution = pm.lockfile.packages.items(.resolution)[info.package_id];
if (info.skip) {
info.scripts_list.printScripts(&resolution, buf, .untrusted);
total_skipped_packages += 1;
} else {
total_packages_with_scripts += 1;
total_scripts_ran += info.scripts_list.total;
info.scripts_list.printScripts(&resolution, buf, .completed);
}
Output.print("\n", .{});
}
}
}
try Install.PackageManager.PackageJSONEditor.editTrustedDependencies(ctx.allocator, &package_json, names);
for (names) |name| {
try pm.lockfile.trusted_dependencies.?.put(ctx.allocator, @truncate(String.Builder.stringHash(name)), {});
}
pm.lockfile.saveToDisk(&load_lockfile, &pm.options);
var buffer_writer = bun.js_printer.BufferWriter.init(ctx.allocator);
try buffer_writer.buffer.list.ensureTotalCapacity(ctx.allocator, package_json_contents.len + 1);
buffer_writer.append_newline = package_json_contents.len > 0 and package_json_contents[package_json_contents.len - 1] == '\n';
var package_json_writer = bun.js_printer.BufferPrinter.init(buffer_writer);
_ = bun.js_printer.printJSON(@TypeOf(&package_json_writer), &package_json_writer, package_json, &package_json_source, .{ .mangled_props = null }) catch |err| {
Output.errGeneric("failed to print package.json: {s}", .{@errorName(err)});
Global.crash();
};
const new_package_json_contents = package_json_writer.ctx.writtenWithoutTrailingZero();
try pm.root_package_json_file.pwriteAll(new_package_json_contents, 0);
std.posix.ftruncate(pm.root_package_json_file.handle, new_package_json_contents.len) catch {};
pm.root_package_json_file.close();
if (comptime Environment.allow_assert) {
bun.assertWithLocation(total_scripts_ran > 0, @src());
}
Output.pretty(" <green>{d}<r> script{s} ran across {d} package{s} ", .{
total_scripts_ran,
if (total_scripts_ran > 1) "s" else "",
total_packages_with_scripts,
if (total_packages_with_scripts > 1) "s" else "",
});
Output.printStartEndStdout(bun.start_time, std.time.nanoTimestamp());
Output.print("\n", .{});
if (total_skipped_packages > 0) {
Output.print("\n", .{});
Output.prettyln(" <yellow>{d}<r> package{s} with blocked scripts", .{
total_skipped_packages,
if (total_skipped_packages > 1) "s" else "",
});
}
}
};
const string = []const u8;
const std = @import("std");
const Command = @import("../cli.zig").Command;
const PackageManagerCommand = @import("./package_manager_command.zig").PackageManagerCommand;
const Install = @import("../install/install.zig");
const DependencyID = Install.DependencyID;
const LifecycleScriptSubprocess = Install.LifecycleScriptSubprocess;
const Lockfile = Install.Lockfile;
const PackageID = Install.PackageID;
const PackageManager = Install.PackageManager;
const bun = @import("bun");
const ArrayIdentityContext = bun.ArrayIdentityContext;
const Environment = bun.Environment;
const Global = bun.Global;
const Output = bun.Output;
const Progress = bun.Progress;
const logger = bun.logger;
const strings = bun.strings;
const String = bun.Semver.String;