mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 20:09:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
8bc2959a52e479727d31b15695565da1a9e8b2a0
bun.sh/src
History
Dylan Conway d2b37a575f Fix poll fd bug where stderr fd was incorrectly set to stdout fd (#22091) 
## Summary
Fixes a bug in the internal `bun.spawnSync` implementation where
stderr's poll file descriptor was incorrectly set to stdout's fd when
polling both streams.

## The Bug
In `/src/bun.js/api/bun/process.zig` line 2204, when setting up the poll
file descriptor array for stderr, the code incorrectly used
`out_fds_to_wait_for[0]` (stdout) instead of `out_fds_to_wait_for[1]`
(stderr).

This meant:
- stderr's fd was never actually polled
- stdout's fd was polled twice
- Could cause stderr data to be lost or incomplete
- Could potentially cause hangs when reading from stderr

## Impact
This bug only affects Bun's internal CLI commands that use
`bun.spawnSync` with both stdout and stderr piped (like `bun create`,
`bun upgrade`, etc.). The JavaScript `spawnSync` API uses a different
code path and is not affected.

## The Fix
Changed line 2204 from:
```zig
poll_fds[poll_fds.len - 1].fd = @intCast(out_fds_to_wait_for[0].cast());
```
to:
```zig
poll_fds[poll_fds.len - 1].fd = @intCast(out_fds_to_wait_for[1].cast());
```

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-08-24 03:16:22 -07:00
..
allocators
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
analytics
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
api
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
ast
zig: ban not using .true and .false for js boolean literals (#21329)
2025-08-20 16:16:11 -07:00
async
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
bake
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
base64
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bun.js
Fix poll fd bug where stderr fd was incorrectly set to stdout fd (#22091)
2025-08-24 03:16:22 -07:00
bundler
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
cli
Add Windows metadata flags to bun build --compile (#22067)
2025-08-23 00:33:24 -07:00
codegen
Add string fast path for postMessage and structuredClone (#21926)
2025-08-20 00:25:00 -07:00
collections
Improve deepClone methods (#21747)
2025-08-11 13:29:53 -07:00
create
zig: delete deprecated bun.jsc.Maybe (#21327)
2025-07-25 12:38:06 -07:00
css
Fix CSS parser crash with large floating-point values (#21907) (#21909)
2025-08-15 20:59:50 -07:00
deps
Fix abort handler in "ws" polyfill (#21867)
2025-08-14 16:00:03 -07:00
errno
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
fs
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
glob
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
http
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
init
bun bake templates: --source-map -> --sourcemap (#21130)
2025-07-17 03:13:48 -07:00
install
bun install Security Scanner API (#21183)
2025-08-21 14:53:50 -07:00
interchange
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
io
Fix pipeline stack errors on Windows (#21800)
2025-08-14 18:03:26 -07:00
js
Use Object.create(null) instead of { __proto__: null } (#21997)
2025-08-23 15:12:09 -07:00
js_lexer
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
libarchive
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
napi
NAPI fixes (#21775)
2025-08-12 19:59:34 -07:00
node-fallbacks
node-fallbacks:buffer: fix numberIsNaN ReferenceError (#21527)
2025-07-31 22:07:17 -07:00
paths
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
ptr
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
resolver
Implement wildcard sideEffects support using glob API (#21039)
2025-08-14 11:58:37 -07:00
s3
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
safety
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
semver
zig: delete deprecated some bun.jsc apis (#21309)
2025-07-23 17:10:58 -07:00
shell
zig: ban not using .true and .false for js boolean literals (#21329)
2025-08-20 16:16:11 -07:00
sourcemap
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
sql
feat(MYSQL) Bun.SQL mysql support (#21968)
2025-08-21 15:28:15 -07:00
string
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
sys
fix: main is not readonly in @types/node (#21612)
2025-08-04 13:07:42 -07:00
test
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
threading
Various safety improvements (safety.ThreadLock, stack traces, MimallocArena, RefCount, safety.alloc) (#21726)
2025-08-11 13:40:07 -07:00
valkey
Fix redis reconnecting (#21724)
2025-08-22 12:08:42 -07:00
vm
Add support for node:vm.SyntheticModule (#19878)
2025-06-04 19:41:26 -07:00
watcher
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
.clang-format
…
allocators.zig
Improve owned pointer types (#21908)
2025-08-15 19:05:25 -07:00
analytics.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
asan-config.c
Fix Linux ASan debug builds (#19657)
2025-05-14 18:42:42 -07:00
asan.zig
Add asan checks to HiveArray (#21449)
2025-07-29 19:35:46 -07:00
ast.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bake.bind.ts
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bake.zig
Fix potential crash in new Bun.Transpiler() (#21650)
2025-08-07 15:16:44 -07:00
bits.zig
remove all usingnamespace in css (#19067)
2025-04-17 14:17:08 -07:00
boringssl.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
brotli.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
btjs.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bun.exe.manifest
Enable Windows long path support (#21244)
2025-07-20 23:04:17 -07:00
bun.ico
…
bun.js.zig
Introduce Bun.secrets API (#21973)
2025-08-23 06:57:00 -07:00
bun.zig
Add --compile-argv option to prepend arguments to standalone executables (#21895)
2025-08-15 22:28:42 -07:00
bunfig.zig
bun install Security Scanner API (#21183)
2025-08-21 14:53:50 -07:00
c-headers-for-zig.h
node:zlib: add zstd (#20313)
2025-06-12 14:20:28 -07:00
cache.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
ci_info.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
cli.zig
Fix argv handling for standalone binaries with compile-exec-argv (#22084)
2025-08-23 19:49:01 -07:00
collections.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
compile_target.zig
Plugins + cross-compilation + Bun.build API support for Bun.build({compile}) (#21915)
2025-08-20 01:25:49 -07:00
comptime_string_map.zig
Delete incorrect assertion in ComptimeStringMap (#21504)
2025-07-31 00:56:50 -07:00
copy_file.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
crash_handler.zig
Make it try llvm-symbolizer-19 if llvm-symbolizer is unavailable (#22030)
2025-08-21 18:52:17 -07:00
csrf.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
css_scanner.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
darwin.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
defines-table.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
defines.zig
Fix potential crash in new Bun.Transpiler() (#21650)
2025-08-07 15:16:44 -07:00
dir.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
dns.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
env_loader.zig
Fix env loader buffer overflow by using stack fallback allocator (#21416)
2025-07-28 00:13:17 -07:00
env.zig
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
fallback-backend.html
Fix formatters not running in CI + delete unnecessary files (#19433)
2025-05-08 23:22:16 -07:00
fallback.html
Fix formatters not running in CI + delete unnecessary files (#19433)
2025-05-08 23:22:16 -07:00
fallback.ts
…
favicon.png
…
fd.zig
Fix pipeline stack errors on Windows (#21800)
2025-08-14 18:03:26 -07:00
feature_flags.zig
[STAB-861] Suppress known-benign core dumps in CI (#21321)
2025-07-25 16:22:04 -07:00
fixtures_example.com.html
Fix formatters not running in CI + delete unnecessary files (#19433)
2025-05-08 23:22:16 -07:00
fmt.bind.ts
…
fmt.zig
feat(MYSQL) Bun.SQL mysql support (#21968)
2025-08-21 15:28:15 -07:00
fs.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
generated_perf_trace_events.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
generated_versions_list.zig
…
glob.zig
Revert "add support for "workspaces.nohoist" and "workspaces.hoistingLimits" (#20124)"
2025-06-03 23:51:03 -07:00
Global.zig
Fix mimalloc memory usage regression (#21550)
2025-08-01 23:38:34 -07:00
heap_breakdown.zig
Improve owned pointer types (#21908)
2025-08-15 19:05:25 -07:00
highway.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
hmac.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
HTMLScanner.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
http.zig
Add --user-agent flag to customize HTTP request User-Agent header (#21894)
2025-08-15 17:51:35 -07:00
identity_context.zig
implement "nodeLinker": "isolated" in bun install (#20440)
2025-07-09 00:19:57 -07:00
import_record.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
ini.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
interchange.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
js_lexer_tables.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
js_lexer.zig
Fix panic in JavaScript lexer when parsing invalid template strings in JSX (#21967)
2025-08-19 18:47:04 -07:00
js_parser.zig
Split JS parser into multiple files (#20880)
2025-08-05 20:52:16 -07:00
js_printer.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
jsc_stub.zig
…
linear_fifo.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
linker.lds
Better error message for NAPI modules which access unsupported libuv functions (#18503)
2025-03-26 23:57:10 -07:00
linker.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
linux.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
logger.zig
fix logger.zig from negative value error (#21876)
2025-08-14 21:12:22 -07:00
logo.svg
…
macho.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
main_test.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
main_wasm.zig
Various safety improvements (safety.ThreadLock, stack traces, MimallocArena, RefCount, safety.alloc) (#21726)
2025-08-11 13:40:07 -07:00
main.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
meta.zig
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
node_fallbacks.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
open.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
options.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
output.zig
Fix flickering in bun updated --interactive (#21964)
2025-08-18 20:02:08 -07:00
OutputFile.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
patch.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
paths.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
pe.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
perf.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
pool.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
Progress.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
ptr.zig
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
renamer.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
result.zig
…
router.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
runtime.bun.js
…
runtime.js
Fix NODE_PATH for bun build (#20576)
2025-06-22 20:51:45 -07:00
runtime.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
safety.zig
Various safety improvements (safety.ThreadLock, stack traces, MimallocArena, RefCount, safety.alloc) (#21726)
2025-08-11 13:40:07 -07:00
semver.zig
…
sha.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
StandaloneModuleGraph.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
StaticHashMap.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
string.zig
Downgrade mimalloc + set libc musl flag (#21684)
2025-08-08 18:02:19 -07:00
symbols.def
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
symbols.dyn
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
symbols.txt
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
sys_uv.zig
zig: delete deprecated bun.jsc.Maybe (#21327)
2025-07-25 12:38:06 -07:00
sys.zig
Fix pipeline stack errors on Windows (#21800)
2025-08-14 18:03:26 -07:00
system_timer.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
threading.zig
Add edge deletion safety checks to DevServer and fix cases where it was caught (#21551)
2025-08-04 19:21:28 -07:00
tmp.zig
zig: delete deprecated bun.jsc.Maybe (#21327)
2025-07-25 12:38:06 -07:00
tracy.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
trait.zig
…
transpiler.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
tsconfig.json
Fix formatters not running in CI + delete unnecessary files (#19433)
2025-05-08 23:22:16 -07:00
unit_test.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
url.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
util.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
walker_skippable.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
Watcher.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
which_npm_client.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
which.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
windows-app-info.rc
Enable Windows long path support (#21244)
2025-07-20 23:04:17 -07:00
windows.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
work_pool.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
workaround_missing_symbols.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
wyhash.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
zlib.test.gz
…
zlib.test.txt
…
zlib.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00