mirror of
https://github.com/oven-sh/bun
synced 2026-02-02 15:08:46 +00:00
e58a4a7282
## Summary Adds a new `concurrentTestGlob` configuration option to bunfig.toml that allows test files matching a glob pattern to automatically run with concurrent test execution enabled. This provides granular control over which tests run concurrently without modifying test files or using the global `--concurrent` flag. ## Problem Currently, enabling concurrent test execution in Bun requires either: 1. Using the `--concurrent` flag (affects ALL tests) 2. Manually adding `test.concurrent()` to individual test functions (requires modifying test files) This creates challenges for: - Large codebases wanting to gradually migrate to concurrent testing - Projects with mixed test types (unit tests that need isolation vs integration tests that can run in parallel) - CI/CD pipelines that want to optimize test execution without code changes ## Solution This PR introduces a `concurrentTestGlob` option in bunfig.toml that automatically enables concurrent execution for test files matching a specified glob pattern: ```toml [test] concurrentTestGlob = "**/concurrent-*.test.ts" ``` ### Key Features - ✅ Non-breaking: Completely opt-in via configuration - ✅ Flexible: Use glob patterns to target specific test files or directories - ✅ Override-friendly: `--concurrent` flag still forces all tests to run concurrently - ✅ Zero code changes: No need to modify existing test files ## Implementation Details ### Code Changes 1. Added `concurrent_test_glob` field to `TestOptions` struct (`src/cli.zig`) 2. Added parsing for `concurrentTestGlob` from bunfig.toml (`src/bunfig.zig`) 3. Added `concurrent_test_glob` field to `TestRunner` (`src/bun.js/test/jest.zig`) 4. Implemented `shouldFileRunConcurrently()` method that checks file paths against the glob pattern 5. Updated test execution logic to apply concurrent mode based on glob matching (`src/bun.js/test/ScopeFunctions.zig`) ### How It Works - When a test file is loaded, its path is checked against the configured glob pattern - If it matches, all tests in that file run concurrently (as if `--concurrent` was passed) - Files not matching the pattern run sequentially as normal - The `--concurrent` CLI flag overrides this behavior when specified ## Usage Examples ### Basic Usage ```toml # bunfig.toml [test] concurrentTestGlob = "**/integration/*.test.ts" ``` ### Multiple Patterns ```toml [test] concurrentTestGlob = [ "**/integration/*.test.ts", "**/e2e/*.test.ts", "**/concurrent-*.test.ts" ] ``` ### Migration Strategy Teams can gradually migrate to concurrent testing: 1. Start with integration tests: `"**/integration/*.test.ts"` 2. Add stable unit tests: `"**/fast-*.test.ts"` 3. Eventually migrate most tests except those requiring isolation ## Testing Added comprehensive test coverage in `test/cli/test/concurrent-test-glob.test.ts`: - ✅ Tests matching glob patterns run concurrently (verified via execution order logging) - ✅ Tests not matching patterns run sequentially (verified via shared state and execution order) - ✅ `--concurrent` flag properly overrides the glob setting - Tests use file system logging to deterministically verify concurrent vs sequential execution ## Documentation Complete documentation added: - `docs/runtime/bunfig.md` - Configuration reference - `docs/test/configuration.md` - Test configuration details - `docs/test/examples/concurrent-test-glob.md` - Comprehensive example with migration guide ## Performance Considerations - Glob matching happens once per test file during loading - Uses Bun's existing `glob.match()` implementation - Minimal overhead: simple string pattern matching - Future optimization: Could cache match results per file path ## Breaking Changes None. This is a fully backward-compatible, opt-in feature. ## Checklist - [x] Implementation complete and building - [x] Tests passing - [x] Documentation updated - [x] No breaking changes - [x] Follows existing code patterns ## Related Issues This addresses common requests for more granular control over concurrent test execution, particularly for large codebases migrating from other test runners. 🤖 Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>