## Summary Fixes a critical segmentation fault crash occurring during NAPI finalizer cleanup when finalizers trigger GC operations. This crash was reported with `node-sqlite3` and other NAPI modules during process exit. ## Root Cause The crash was caused by **iterator invalidation** in `napi_env__::cleanup()`: 1. Range-based for loop iterates over `m_finalizers` (std::unordered_set) 2. `boundFinalizer.call(this)` executes finalizer callbacks 3. Finalizers can trigger JavaScript execution and GC operations 4. GC can add/remove entries from `m_finalizers` during iteration 5. **Iterator invalidation** → undefined behavior → segfault ## Solution Added `JSC::DeferGCForAWhile deferGC(m_vm)` scope during entire finalizer cleanup to prevent any GC operations from occurring during iteration. ### Why This Approach? - **Addresses root cause**: Prevents GC entirely during critical section - **Simple & safe**: One-line RAII fix using existing JSC patterns - **Minimal impact**: Only affects process cleanup (not runtime performance) - **Proven pattern**: Already used elsewhere in Bun's codebase - **Better than alternatives**: Cleaner than Node.js manual iterator approach ## Testing Added comprehensive test (`test_finalizer_iterator_invalidation.c`) that reproduces the crash by: - Creating finalizers that trigger GC operations - Forcing JavaScript execution during finalization - Allocating objects that can trigger more GC - Calling process exit to trigger finalizer cleanup **Before fix**: Segmentation fault **After fix**: Clean exit ✅ ## Files Changed - `src/bun.js/bindings/napi.h`: Core fix + include - `test/napi/napi-app/test_finalizer_iterator_invalidation.c`: Test addon - `test/napi/napi-app/binding.gyp`: Build config for test addon - `test/regression/issue/napi-finalizer-crash.test.ts`: Integration test ## Test Plan - [x] Reproduces original crash without fix - [x] Passes cleanly with fix applied - [x] Existing NAPI tests continue to pass - [x] Manual testing with node-sqlite3 scenarios 🤖 Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Kai Tamkun <kai@tamkun.io>
Tests
Finding tests
Tests are located in the test/ directory and are organized using the following structure:
test/js/- tests for JavaScript APIs.cli/- tests for commands, configs, and stdout.bundler/- tests for the transpiler/bundler.regression/- tests that reproduce a specific issue.harness.ts- utility functions that can be imported from any test.
The tests in test/js/ directory are further categorized by the type of API.
test/js/bun/- tests forBun-specific APIs.node/- tests for Node.js APIs.web/- tests for Web APIs, likefetch().first_party/- tests for npm packages that are built-in, likeundici.third_party/- tests for npm packages that are not built-in, but are popular, likeesbuild.
Running tests
To run a test, use Bun's built-in test command: bun test.
bun test # Run all tests
bun test js/bun # Only run tests in a directory
bun test sqlite.test.ts # Only run a specific test
If you encounter lots of errors, try running bun install, then trying again.
Writing tests
Tests are written in TypeScript (preferred) or JavaScript using Jest's describe(), test(), and expect() APIs.
import { describe, test, expect } from "bun:test";
import { gcTick } from "harness";
describe("TextEncoder", () => {
test("can encode a string", async () => {
const encoder = new TextEncoder();
const actual = encoder.encode("bun");
await gcTick();
expect(actual).toBe(new Uint8Array([0x62, 0x75, 0x6E]));
});
});
If you are fixing a bug that was reported from a GitHub issue, remember to add a test in the test/regression/ directory.
// test/regression/issue/02005.test.ts
import { it, expect } from "bun:test";
it("regex literal should work with non-latin1", () => {
const text = "这是一段要替换的文字";
expect(text.replace(new RegExp("要替换"), "")).toBe("这是一段的文字");
expect(text.replace(/要替换/, "")).toBe("这是一段的文字");
});
In the future, a bot will automatically close or re-open issues when a regression is detected or resolved.
Zig tests
These tests live in various .zig files throughout Bun's codebase, leveraging Zig's builtin test keyword.
Currently, they're not run automatically nor is there a simple way to run all of them. We will make this better soon.
TypeScript
Test files should be written in TypeScript. The types in packages/bun-types should be updated to support all new APIs. Changes to the .d.ts files in packages/bun-types will be immediately reflected in test files; no build step is necessary.
Writing a test will often require using invalid syntax, e.g. when checking for errors when an invalid input is passed to a function. TypeScript provides a number of escape hatches here.
// @ts-expect-error- This should be your first choice. It tells TypeScript that the next line should fail typechecking.// @ts-ignore- Ignore the next line entirely.// @ts-nocheck- Put this at the top of the file to disable typechecking on the entire file. Useful for autogenerated test files, or when ignoring/disabling type checks an a per-line basis is too onerous.