mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 10:28:47 +00:00
Fixes ENG-21287
Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`
|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|
Runtime performance:
- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)
Improvements:
- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests
Still an issue:
- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed
Follow-up:
- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully
Files that add lines:
```
649 src/deprecated.zig
167 scripts/pack-codegen-for-zig-team.ts
54 scripts/cleartrace-impl.js
46 scripts/cleartrace.ts
43 src/windows.zig
18 src/fs.zig
17 src/bun.js/ConsoleObject.zig
16 src/output.zig
12 src/bun.js/test/debug.zig
12 src/bun.js/node/node_fs.zig
8 src/env_loader.zig
7 src/css/printer.zig
7 src/cli/init_command.zig
7 src/bun.js/node.zig
6 src/string/escapeRegExp.zig
6 src/install/PnpmMatcher.zig
5 src/bun.js/webcore/Blob.zig
4 src/crash_handler.zig
4 src/bun.zig
3 src/install/lockfile/bun.lock.zig
3 src/cli/update_interactive_command.zig
3 src/cli/pack_command.zig
3 build.zig
2 src/Progress.zig
2 src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2 src/css/small_list.zig
2 src/bun.js/webcore/prompt.zig
1 test/internal/ban-words.test.ts
1 test/internal/ban-limits.json
1 src/watcher/WatcherTrace.zig
1 src/transpiler.zig
1 src/shell/builtin/cp.zig
1 src/js_printer.zig
1 src/io/PipeReader.zig
1 src/install/bin.zig
1 src/css/selectors/selector.zig
1 src/cli/run_command.zig
1 src/bun.js/RuntimeTranspilerStore.zig
1 src/bun.js/bindings/JSRef.zig
1 src/bake/DevServer.zig
```
Files that remove lines:
```
-1 src/test/recover.zig
-1 src/sql/postgres/SocketMonitor.zig
-1 src/sql/mysql/MySQLRequestQueue.zig
-1 src/sourcemap/CodeCoverage.zig
-1 src/css/values/color_js.zig
-1 src/compile_target.zig
-1 src/bundler/linker_context/convertStmtsForChunk.zig
-1 src/bundler/bundle_v2.zig
-1 src/bun.js/webcore/blob/read_file.zig
-1 src/ast/base.zig
-2 src/sql/postgres/protocol/ArrayList.zig
-2 src/shell/builtin/mkdir.zig
-2 src/install/PackageManager/patchPackage.zig
-2 src/install/PackageManager/PackageManagerDirectories.zig
-2 src/fmt.zig
-2 src/css/declaration.zig
-2 src/css/css_parser.zig
-2 src/collections/baby_list.zig
-2 src/bun.js/bindings/ZigStackFrame.zig
-2 src/ast/E.zig
-3 src/StandaloneModuleGraph.zig
-3 src/deps/picohttp.zig
-3 src/deps/libuv.zig
-3 src/btjs.zig
-4 src/threading/Futex.zig
-4 src/shell/builtin/touch.zig
-4 src/meta.zig
-4 src/install/lockfile.zig
-4 src/css/selectors/parser.zig
-5 src/shell/interpreter.zig
-5 src/css/error.zig
-5 src/bun.js/web_worker.zig
-5 src/bun.js.zig
-6 src/cli/test_command.zig
-6 src/bun.js/VirtualMachine.zig
-6 src/bun.js/uuid.zig
-6 src/bun.js/bindings/JSValue.zig
-9 src/bun.js/test/pretty_format.zig
-9 src/bun.js/api/BunObject.zig
-14 src/install/install_binding.zig
-14 src/fd.zig
-14 src/bun.js/node/path.zig
-14 scripts/pack-codegen-for-zig-team.sh
-17 src/bun.js/test/diff_format.zig
```
`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
365 lines
13 KiB
Zig
365 lines
13 KiB
Zig
//! Node.js APIs in Bun. Access this namespace with `bun.api.node`
|
|
comptime {
|
|
_ = process.getTitle;
|
|
_ = process.setTitle;
|
|
_ = @import("./node/util/parse_args.zig");
|
|
}
|
|
|
|
/// node:fs
|
|
pub const fs = @import("./node/node_fs.zig");
|
|
/// node:path
|
|
pub const path = @import("./node/path.zig");
|
|
/// node:crypto
|
|
pub const crypto = @import("./node/node_crypto_binding.zig");
|
|
/// node:os
|
|
pub const os = @import("./node/node_os.zig");
|
|
/// node:process
|
|
pub const process = @import("./node/node_process.zig");
|
|
pub const validators = @import("./node/util/validators.zig");
|
|
pub const ErrorCode = @import("./node/nodejs_error_code.zig").Code;
|
|
|
|
pub const Buffer = jsc.MarkedArrayBuffer;
|
|
|
|
pub const PathOrBlob = types.PathOrBlob;
|
|
pub const Dirent = types.Dirent;
|
|
pub const FileSystemFlags = types.FileSystemFlags;
|
|
pub const PathOrFileDescriptor = types.PathOrFileDescriptor;
|
|
pub const modeFromJS = types.modeFromJS;
|
|
pub const VectorArrayBuffer = types.VectorArrayBuffer;
|
|
pub const Valid = types.Valid;
|
|
pub const PathLike = types.PathLike;
|
|
pub const CallbackTask = types.CallbackTask;
|
|
pub const PathOrBuffer = types.PathOrBuffer;
|
|
pub const jsAssertEncodingValid = types.jsAssertEncodingValid;
|
|
pub const Encoding = types.Encoding;
|
|
pub const StringOrBuffer = types.StringOrBuffer;
|
|
pub const BlobOrStringOrBuffer = types.BlobOrStringOrBuffer;
|
|
|
|
pub const FSEvents = @import("./node/fs_events.zig");
|
|
pub const Stats = stat.Stats;
|
|
pub const StatsBig = stat.StatsBig;
|
|
pub const StatsSmall = stat.StatsSmall;
|
|
|
|
pub const StatFSSmall = statfs.StatFSSmall;
|
|
pub const StatFSBig = statfs.StatFSBig;
|
|
pub const StatFS = statfs.StatFS;
|
|
|
|
pub const uid_t = if (Environment.isPosix) std.posix.uid_t else bun.windows.libuv.uv_uid_t;
|
|
pub const gid_t = if (Environment.isPosix) std.posix.gid_t else bun.windows.libuv.uv_gid_t;
|
|
|
|
pub const time_like = @import("./node/time_like.zig");
|
|
pub const TimeLike = time_like.TimeLike;
|
|
pub const timeLikeFromJS = time_like.fromJS;
|
|
|
|
/// Node.js expects the error to include contextual information
|
|
/// - "syscall"
|
|
/// - "path"
|
|
/// - "errno"
|
|
///
|
|
/// We can't really use Zig's error handling for syscalls because Node.js expects the "real" errno to be returned
|
|
/// and various issues with std.posix that make it too unstable for arbitrary user input (e.g. how .BADF is marked as unreachable)
|
|
pub fn Maybe(comptime ReturnTypeT: type, comptime ErrorTypeT: type) type {
|
|
// can't call @hasDecl on void, anyerror, etc
|
|
const has_any_decls = ErrorTypeT != void and ErrorTypeT != anyerror;
|
|
const has_retry = has_any_decls and @hasDecl(ErrorTypeT, "retry");
|
|
const has_todo = has_any_decls and @hasDecl(ErrorTypeT, "todo");
|
|
|
|
return union(Tag) {
|
|
pub const ErrorType = ErrorTypeT;
|
|
pub const ReturnType = ReturnTypeT;
|
|
|
|
err: ErrorType,
|
|
result: ReturnType,
|
|
|
|
pub const Tag = enum { err, result };
|
|
|
|
pub const retry: @This() = if (has_retry) .{ .err = ErrorType.retry } else .{ .err = .{} };
|
|
pub const success: @This() = .{
|
|
.result = std.mem.zeroes(ReturnType),
|
|
};
|
|
/// This value is technically garbage, but that is okay as `.aborted` is
|
|
/// only meant to be returned in an operation when there is an aborted
|
|
/// `AbortSignal` object associated with the operation.
|
|
pub const aborted: @This() = .{ .err = .{
|
|
.errno = @intFromEnum(posix.E.INTR),
|
|
.syscall = .access,
|
|
} };
|
|
|
|
pub inline fn todo() @This() {
|
|
if (Environment.allow_assert) {
|
|
if (comptime ReturnType == void) {
|
|
@panic("TODO called!");
|
|
}
|
|
@panic(comptime "TODO: Maybe(" ++ bun.meta.typeName(ReturnType) ++ ")");
|
|
}
|
|
if (has_todo) {
|
|
return .{ .err = ErrorType.todo() };
|
|
}
|
|
return .{ .err = ErrorType{} };
|
|
}
|
|
|
|
pub fn isTrue(this: @This()) bool {
|
|
if (comptime ReturnType != bool) @compileError("This function can only be called on bool");
|
|
return switch (this) {
|
|
.result => |r| r,
|
|
else => false,
|
|
};
|
|
}
|
|
|
|
pub fn unwrap(this: @This()) !ReturnType {
|
|
return switch (this) {
|
|
.result => |r| r,
|
|
.err => |e| bun.errnoToZigErr(e.errno),
|
|
};
|
|
}
|
|
|
|
/// Unwrap the value if it is `result` or use the provided `default_value`
|
|
pub inline fn unwrapOr(this: @This(), default_value: ReturnType) ReturnType {
|
|
return switch (this) {
|
|
.result => |v| v,
|
|
.err => default_value,
|
|
};
|
|
}
|
|
|
|
pub inline fn initErr(e: ErrorType) Maybe(ReturnType, ErrorType) {
|
|
return .{ .err = e };
|
|
}
|
|
|
|
pub inline fn initErrWithP(e: bun.sys.SystemErrno, syscall: sys.Tag, file_path: anytype) Maybe(ReturnType, ErrorType) {
|
|
return .{ .err = .{
|
|
.errno = @intFromEnum(e),
|
|
.syscall = syscall,
|
|
.path = file_path,
|
|
} };
|
|
}
|
|
|
|
pub inline fn asErr(this: *const @This()) ?ErrorType {
|
|
if (this.* == .err) return this.err;
|
|
return null;
|
|
}
|
|
|
|
pub inline fn asValue(this: *const @This()) ?ReturnType {
|
|
if (this.* == .result) return this.result;
|
|
return null;
|
|
}
|
|
|
|
pub inline fn isOk(this: *const @This()) bool {
|
|
return switch (this.*) {
|
|
.result => true,
|
|
.err => false,
|
|
};
|
|
}
|
|
|
|
pub inline fn isErr(this: *const @This()) bool {
|
|
return switch (this.*) {
|
|
.result => false,
|
|
.err => true,
|
|
};
|
|
}
|
|
|
|
pub inline fn initResult(result: ReturnType) Maybe(ReturnType, ErrorType) {
|
|
return .{ .result = result };
|
|
}
|
|
|
|
pub inline fn mapErr(this: @This(), comptime E: type, err_fn: *const fn (ErrorTypeT) E) Maybe(ReturnType, E) {
|
|
return switch (this) {
|
|
.result => |v| .{ .result = v },
|
|
.err => |e| .{ .err = err_fn(e) },
|
|
};
|
|
}
|
|
|
|
pub inline fn toCssResult(this: @This()) Maybe(ReturnType, bun.css.ParseError(bun.css.ParserError)) {
|
|
return switch (ErrorTypeT) {
|
|
bun.css.BasicParseError => {
|
|
return switch (this) {
|
|
.result => |v| return .{ .result = v },
|
|
.err => |e| return .{ .err = e.intoDefaultParseError() },
|
|
};
|
|
},
|
|
bun.css.ParseError(bun.css.ParserError) => @compileError("Already a ParseError(ParserError)"),
|
|
else => @compileError("Bad!"),
|
|
};
|
|
}
|
|
|
|
pub fn toJS(this: @This(), globalObject: *jsc.JSGlobalObject) bun.JSError!jsc.JSValue {
|
|
return switch (this) {
|
|
.result => |r| switch (ReturnType) {
|
|
jsc.JSValue => r,
|
|
|
|
void => .js_undefined,
|
|
bool => jsc.JSValue.jsBoolean(r),
|
|
|
|
jsc.ArrayBuffer => r.toJS(globalObject),
|
|
[]u8 => jsc.ArrayBuffer.fromBytes(r, .ArrayBuffer).toJS(globalObject),
|
|
|
|
else => switch (@typeInfo(ReturnType)) {
|
|
.int, .float, .comptime_int, .comptime_float => jsc.JSValue.jsNumber(r),
|
|
.@"struct", .@"enum", .@"opaque", .@"union" => r.toJS(globalObject),
|
|
.pointer => {
|
|
if (bun.trait.isZigString(ReturnType))
|
|
jsc.ZigString.init(bun.asByteSlice(r)).withEncoding().toJS(globalObject);
|
|
|
|
return r.toJS(globalObject);
|
|
},
|
|
},
|
|
},
|
|
.err => |e| e.toJS(globalObject),
|
|
};
|
|
}
|
|
|
|
pub fn toArrayBuffer(this: @This(), globalObject: *jsc.JSGlobalObject) jsc.JSValue {
|
|
return switch (this) {
|
|
.result => |r| jsc.ArrayBuffer.fromBytes(r, .ArrayBuffer).toJS(globalObject, null),
|
|
.err => |e| e.toJS(globalObject),
|
|
};
|
|
}
|
|
|
|
pub fn getErrno(this: @This()) posix.E {
|
|
return switch (this) {
|
|
.result => posix.E.SUCCESS,
|
|
.err => |e| @enumFromInt(e.errno),
|
|
};
|
|
}
|
|
|
|
pub fn errnoSys(rc: anytype, syscall: sys.Tag) ?@This() {
|
|
if (comptime Environment.isWindows) {
|
|
if (comptime @TypeOf(rc) == std.os.windows.NTSTATUS) {} else {
|
|
if (rc != 0) return null;
|
|
}
|
|
}
|
|
return switch (sys.getErrno(rc)) {
|
|
.SUCCESS => null,
|
|
else => |e| @This(){
|
|
// always truncate
|
|
.err = .{
|
|
.errno = translateToErrInt(e),
|
|
.syscall = syscall,
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn errno(err: anytype, syscall: sys.Tag) @This() {
|
|
return @This(){
|
|
// always truncate
|
|
.err = .{
|
|
.errno = translateToErrInt(err),
|
|
.syscall = syscall,
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn errnoSysFd(rc: anytype, syscall: sys.Tag, fd: bun.FileDescriptor) ?@This() {
|
|
if (comptime Environment.isWindows) {
|
|
if (comptime @TypeOf(rc) == std.os.windows.NTSTATUS) {} else {
|
|
if (rc != 0) return null;
|
|
}
|
|
}
|
|
return switch (sys.getErrno(rc)) {
|
|
.SUCCESS => null,
|
|
else => |e| @This(){
|
|
// Always truncate
|
|
.err = .{
|
|
.errno = translateToErrInt(e),
|
|
.syscall = syscall,
|
|
.fd = fd,
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn errnoSysP(rc: anytype, syscall: sys.Tag, file_path: anytype) ?@This() {
|
|
if (bun.meta.Item(@TypeOf(file_path)) == u16) {
|
|
@compileError("Do not pass WString path to errnoSysP, it needs the path encoded as utf8");
|
|
}
|
|
if (comptime Environment.isWindows) {
|
|
if (comptime @TypeOf(rc) == std.os.windows.NTSTATUS) {} else {
|
|
if (rc != 0) return null;
|
|
}
|
|
}
|
|
return switch (sys.getErrno(rc)) {
|
|
.SUCCESS => null,
|
|
else => |e| @This(){
|
|
// Always truncate
|
|
.err = .{
|
|
.errno = translateToErrInt(e),
|
|
.syscall = syscall,
|
|
.path = bun.asByteSlice(file_path),
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn errnoSysFP(rc: anytype, syscall: sys.Tag, fd: bun.FileDescriptor, file_path: anytype) ?@This() {
|
|
if (comptime Environment.isWindows) {
|
|
if (comptime @TypeOf(rc) == std.os.windows.NTSTATUS) {} else {
|
|
if (rc != 0) return null;
|
|
}
|
|
}
|
|
return switch (sys.getErrno(rc)) {
|
|
.SUCCESS => null,
|
|
else => |e| @This(){
|
|
// Always truncate
|
|
.err = .{
|
|
.errno = translateToErrInt(e),
|
|
.syscall = syscall,
|
|
.fd = fd,
|
|
.path = bun.asByteSlice(file_path),
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn errnoSysPD(rc: anytype, syscall: sys.Tag, file_path: anytype, dest: anytype) ?@This() {
|
|
if (bun.meta.Item(@TypeOf(file_path)) == u16) {
|
|
@compileError("Do not pass WString path to errnoSysPD, it needs the path encoded as utf8");
|
|
}
|
|
if (comptime Environment.isWindows) {
|
|
if (comptime @TypeOf(rc) == std.os.windows.NTSTATUS) {} else {
|
|
if (rc != 0) return null;
|
|
}
|
|
}
|
|
return switch (sys.getErrno(rc)) {
|
|
.SUCCESS => null,
|
|
else => |e| @This(){
|
|
// Always truncate
|
|
.err = .{
|
|
.errno = translateToErrInt(e),
|
|
.syscall = syscall,
|
|
.path = bun.asByteSlice(file_path),
|
|
.dest = bun.asByteSlice(dest),
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
pub fn format(this: @This(), writer: *std.Io.Writer) !void {
|
|
return switch (this) {
|
|
.result => try writer.print("Result(...)", .{}),
|
|
.err => |e| try writer.print("Error(" ++ bun.deprecated.autoFormatLabelFallback(ErrorType, "{any}") ++ ")", .{e}),
|
|
};
|
|
}
|
|
};
|
|
}
|
|
|
|
fn translateToErrInt(err: anytype) bun.sys.Error.Int {
|
|
return switch (@TypeOf(err)) {
|
|
bun.windows.NTSTATUS => @intFromEnum(bun.windows.translateNTStatusToErrno(err)),
|
|
else => @truncate(@intFromEnum(err)),
|
|
};
|
|
}
|
|
|
|
const stat = @import("./node/Stat.zig");
|
|
const statfs = @import("./node/StatFS.zig");
|
|
const types = @import("./node/types.zig");
|
|
|
|
const bun = @import("bun");
|
|
const Environment = bun.Environment;
|
|
const jsc = bun.jsc;
|
|
const meta = bun.meta;
|
|
const sys = bun.sys;
|
|
const windows = bun.windows;
|
|
|
|
const std = @import("std");
|
|
const posix = std.posix;
|