### What does this PR do? Fixes printing `import.meta.url` and others with `--bytecode`. Fixes #14954. Fixes printing `__toESM` when output module format is CJS and input module format is ESM. The key change is that `__toESM`'s `isNodeMode` parameter now depends on the **input module type** (whether the importing file uses ESM syntax like `import`/`export`) rather than the output format. This matches Node.js ESM behavior where importing CommonJS from `.mjs` files always wraps the entire `module.exports` object as the default export, ignoring `__esModule` markers. ### How did you verify your code works? Added comprehensive test suite in `test/bundler/bundler_cjs.test.ts` with **23 tests** covering: #### Core Behaviors: - ✅ Files using `import` syntax always get `isNodeMode=1`, which **ignores `__esModule`** markers and wraps the entire CJS module as default - ✅ This matches Node.js ESM semantics for importing CJS from `.mjs` files - ✅ Different CJS export patterns (`exports.x`, `module.exports = ...`, functions, primitives) - ✅ Named, default, and namespace (`import *`) imports - ✅ Different targets (node, browser, bun) - all behave the same - ✅ Different output formats (esm, cjs) - format doesn't affect the behavior - ✅ `.mjs` files re-exporting from `.cjs` - ✅ Deep re-export chains - ✅ Edge cases (non-boolean `__esModule`, `__esModule=false`, etc.) #### Test Results: - **With this PR's changes**: All 23 tests pass ✅ - **Without this PR (system bun)**: 22 pass, 1 fails (the one testing that `__esModule` is ignored with import syntax + CJS format) The failing test with system bun demonstrates the bug being fixed: currently, format=cjs with import syntax still respects `__esModule`, but it should ignore it (matching Node.js behavior). --------- Co-authored-by: Jarred Sumner <jarred@jarredsumner.com> Co-authored-by: Claude Bot <claude-bot@bun.sh>
Tests
Finding tests
Tests are located in the test/ directory and are organized using the following structure:
test/js/- tests for JavaScript APIs.cli/- tests for commands, configs, and stdout.bundler/- tests for the transpiler/bundler.regression/- tests that reproduce a specific issue.harness.ts- utility functions that can be imported from any test.
The tests in test/js/ directory are further categorized by the type of API.
test/js/bun/- tests forBun-specific APIs.node/- tests for Node.js APIs.web/- tests for Web APIs, likefetch().first_party/- tests for npm packages that are built-in, likeundici.third_party/- tests for npm packages that are not built-in, but are popular, likeesbuild.
Running tests
To run a test, use Bun's built-in test command: bun test.
bun test # Run all tests
bun test js/bun # Only run tests in a directory
bun test sqlite.test.ts # Only run a specific test
If you encounter lots of errors, try running bun install, then trying again.
Writing tests
Tests are written in TypeScript (preferred) or JavaScript using Jest's describe(), test(), and expect() APIs.
import { describe, test, expect } from "bun:test";
import { gcTick } from "harness";
describe("TextEncoder", () => {
test("can encode a string", async () => {
const encoder = new TextEncoder();
const actual = encoder.encode("bun");
await gcTick();
expect(actual).toBe(new Uint8Array([0x62, 0x75, 0x6E]));
});
});
If you are fixing a bug that was reported from a GitHub issue, remember to add a test in the test/regression/ directory.
// test/regression/issue/02005.test.ts
import { it, expect } from "bun:test";
it("regex literal should work with non-latin1", () => {
const text = "这是一段要替换的文字";
expect(text.replace(new RegExp("要替换"), "")).toBe("这是一段的文字");
expect(text.replace(/要替换/, "")).toBe("这是一段的文字");
});
In the future, a bot will automatically close or re-open issues when a regression is detected or resolved.
Zig tests
These tests live in various .zig files throughout Bun's codebase, leveraging Zig's builtin test keyword.
Currently, they're not run automatically nor is there a simple way to run all of them. We will make this better soon.
TypeScript
Test files should be written in TypeScript. The types in packages/bun-types should be updated to support all new APIs. Changes to the .d.ts files in packages/bun-types will be immediately reflected in test files; no build step is necessary.
Writing a test will often require using invalid syntax, e.g. when checking for errors when an invalid input is passed to a function. TypeScript provides a number of escape hatches here.
// @ts-expect-error- This should be your first choice. It tells TypeScript that the next line should fail typechecking.// @ts-ignore- Ignore the next line entirely.// @ts-nocheck- Put this at the top of the file to disable typechecking on the entire file. Useful for autogenerated test files, or when ignoring/disabling type checks an a per-line basis is too onerous.