mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 18:38:55 +00:00
24b7835ecd
## Summary - Fixed shell lexer to properly store error messages using TextRange instead of direct string slices - This prevents potential use-after-free issues when error messages are accessed after the lexer's string pool might have been reallocated - Added test coverage for shell syntax error reporting ## Changes - Changed `LexError.msg` from `[]const u8` to `Token.TextRange` to store indices into the string pool - Added `TextRange.slice()` helper method for converting ranges back to string slices - Updated error message concatenation logic to use the new range-based approach - Added test to verify syntax errors are reported correctly ## Test plan - [x] Added test case for invalid shell syntax error reporting - [x] Existing shell tests continue to pass - [x] Manual testing of various shell syntax errors closes BAPI-2232 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
34 lines
1.2 KiB
TypeScript
34 lines
1.2 KiB
TypeScript
import { expect, test } from "bun:test";
|
|
import { mkdirSync } from "fs";
|
|
import { bunEnv, bunExe, tmpdirSync } from "harness";
|
|
import { join } from "path";
|
|
|
|
test("running a shell script works", async () => {
|
|
const dir = tmpdirSync();
|
|
mkdirSync(dir, { recursive: true });
|
|
await Bun.write(join(dir, "something.sh"), "echo wah");
|
|
let { stdout, stderr } = Bun.spawnSync({
|
|
cmd: [bunExe(), join(dir, "something.sh")],
|
|
cwd: dir,
|
|
env: bunEnv,
|
|
stderr: "pipe",
|
|
});
|
|
console.log(stderr.toString("utf8"));
|
|
expect(stdout.toString("utf8")).toEqual("wah\n");
|
|
});
|
|
|
|
test("invalid syntax reports the error correctly", async () => {
|
|
const dir = tmpdirSync("bun-shell-test-error");
|
|
mkdirSync(dir, { recursive: true });
|
|
const shellScript = `-h)
|
|
echo "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"`;
|
|
await Bun.write(join(dir, "scripts", "script.sh"), shellScript);
|
|
let { stderr } = Bun.spawnSync({
|
|
cmd: [bunExe(), join(dir, "scripts", "script.sh")],
|
|
cwd: dir,
|
|
env: bunEnv,
|
|
stderr: "pipe",
|
|
});
|
|
expect(stderr.toString("utf8")).toBe("error: Failed to run script.sh due to error Unexpected ')'\n");
|
|
});
|