Files
bun.sh/src/bun.js/bindings/webcore/HTTPHeaderMap.cpp
SUZUKI Sosuke d7eebef6f8 Upgrade WebKit (#23122)
### What does this PR do?

- **Use `Latin1Character` instead of `LChar`**
- **Fix for
0875bc8f62**

### How did you verify your code works?

---

# WebKit Update Summary (September 2025)

## Overview
This document summarizes the major changes in WebKit/JavaScriptCore from
the September 2025 update. The update includes approximately 254
JSC-related commits with significant improvements to performance,
stability, and developer experience.

## Critical Bug Fixes

### Memory Safety
- **operationMaterializeObjectInOSR fix** (5c7aadfa0a96): Fixed
uninitialized Butterfly storage during OSR exits with sunk Array
allocations. This prevents potential crashes when arrays with holes are
materialized during OSR exit.
- **FTL materialization fixes** (a72d19840714, ed1e6fe03899): Added
missing internal object type handling in FTL materialization, improving
stability during optimization bailouts.

### Promise and Async Improvements
- **JSPromiseReaction object** (a1cb5e087a46, later reverted in
b0566a4db201): Initially introduced to improve promise reaction handling
but was reverted due to compatibility issues with Bun's modifications.
- **Async stack traces enhancements**:
  - Added support for `Promise.any` in async stack traces (d9a997b3edaa)
- Added empty JSValue checking for async stack trace safety
(9d26223d4bcb)
- Promise.all support was added and later reverted due to performance
concerns

## Performance Optimizations

### JIT Compiler Improvements
- **B3 Immutable Loads** (570a3530f949, 62300f8db3d9): Added
immutability annotations and CSE optimizations for loads that can look
for targets in dominators
- **BBQ JIT enhancements**:
  - Fixed callee-save register handling (c7ae05719045)
  - Simplified F32 copysign operations (e0651af57025)
- **DFG optimizations**:
- Fixed RegExp constant folding with materialized NewRegExp nodes
(7b53a04a5afa)
- Improved RegExp object node handling in strength reduction
(eeb65e05095b)

### WebAssembly Improvements
- **WASM SIMD Support**:
- Added v128 support for IPInt call and tail-call instructions
(73f0c9d430cb)
- Implemented v128 support in local.get, local.set, global.get,
global.set (67d7bf15139a)
  - Added x86_64 SIMD integer arithmetic and float instructions
- **WASM Memory Management**:
- Introduced WasmInstanceAnchor for better instance lifecycle management
(f9f1ed183bf7)
- Attached AbstractHeap to wasm memory access for better optimization
(f183c6f7def4)
  - Added signal handling for null checks in wasm (bf18b5b709f3)
- **WASM Debugging**: Added LLDB debugging infrastructure for
WebAssembly (e03c10225cc8)

## API and Language Features

### Iterator Helpers
- Merged `Iterator.prototype.sliding` into `Iterator.prototype.windows`
(1d49e823702d)
- Optimized iterator next method calls using CachedCall (5ee92514060c)

### Math Extensions
- Improved performance of `Math.sumPrecise` implementation
(602294057337)

### Error Handling
- Enhanced error messages for for-of loops without Symbol.iterator
(0051bbf2491f)

## Infrastructure Changes

### Character Type Refactoring
- **LChar to Latin1Character rename** (63b97b511366, 1424f0687876):
Major refactoring replacing the `LChar` type with `Latin1Character`
throughout the codebase for better clarity
- Additional fixes for Latin1Character usage (711eab3243f0,
50bf8e6fd4ca, 88e29ab76aec)

### Build System
- Fixed builds with GCC 15.x (e33b18bc59d6)
- Added gitattributes for JSC test files (82c4cc796da6)
- Improved test runner with comprehensive verbose logging (7ef95c177a42)
- Added memory-limited annotations for tests using excessive memory
(b991cd17d612)

### Testing Infrastructure
- Improved handling of missing test executables (db1e3bbb3be2)
- Added support for non-customized ICU 74.2 in intl tests (c922a28b6642)
- Fixed various test configuration issues and timeouts

## Bun-Specific Modifications

### Preserved Customizations
- Maintained `BUN_JSC_ADDITIONS` for Bun-specific features
- Kept async context support for AsyncLocalStorage
- Preserved V8 heap snapshot compatibility layer
- Maintained custom inspector extensions

### Conflicts Resolved
- Successfully merged upstream changes while preserving Bun's event loop
integration
- Resolved conflicts in promise handling while maintaining Bun's async
behavior
- Fixed re-declaration issues with `isAsyncFrame` for async stack traces

## Breaking Changes and Reverts

### Reverted Features
1. **JSPromiseReaction object**: Reverted due to conflicts with Bun's
promise handling
2. **Promise.all async stack trace support**: Reverted due to ~4%
performance regression in JetStream3/doxbee-async benchmark
3. **Array.prototype.flat C++ implementation**: Reverted (reason not
specified in commit)

## Security Improvements
- Type safety improvements with uncheckedDowncast for Wasm::Callee
(48425afd643d)
- Added bounds checking and validation for Wasm array operations
(b5148db1c4c1)
- Improved memory safety with proper initialization of materialized
objects

## Platform Support
- macOS: Continued support for x64/arm64
- Linux: Maintained glibc/musl compatibility
- Windows: Preserved x64 support
- Fixed platform-specific alignment issues for x86_64 (94a60eb123c5)

## Notable Debugging Enhancements
- LLDB infrastructure for WebAssembly debugging
- Improved verbose command logging in test runners
- Enhanced stack trace capabilities for async functions
- Better error reporting for missing Symbol.iterator

## Performance Metrics
- Several memory optimizations for test execution
- JIT memory reservation size adjustments for debug builds
- Optimized iterator operations with cached calls
- Improved Math.sumPrecise performance

## Future Considerations
- The JSPromiseReaction implementation may need revisiting with adjusted
architecture
- Async stack trace support for Promise.all requires performance
optimization
- Continued work on WASM SIMD support for additional operations

## Migration Notes for Bun Team
1. **LChar usage**: All references to `LChar` have been replaced with
`Latin1Character`
2. **Promise handling**: The reverted JSPromiseReaction changes indicate
potential architectural conflicts that may need addressing
3. **Test configuration**: New memory-limited annotations should be used
for memory-intensive tests
4. **Build flags**: Ensure USE_BUN_JSC_ADDITIONS and USE_BUN_EVENT_LOOP
remain enabled
2025-10-01 17:16:25 -07:00

351 lines
10 KiB
C++

/*
* Copyright (C) 2009 Google Inc. All rights reserved.
* Copyright (C) 2022 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following disclaimer
* in the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Google Inc. nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config.h"
#include "HTTPHeaderMap.h"
#include <utility>
#include <wtf/CrossThreadCopier.h>
#include <wtf/text/StringView.h>
namespace WebCore {
HTTPHeaderMap::HTTPHeaderMap()
{
}
HTTPHeaderMap HTTPHeaderMap::isolatedCopy() const&
{
HTTPHeaderMap map;
map.m_commonHeaders = crossThreadCopy(m_commonHeaders);
map.m_uncommonHeaders = crossThreadCopy(m_uncommonHeaders);
map.m_setCookieHeaders = crossThreadCopy(m_setCookieHeaders);
return map;
}
HTTPHeaderMap HTTPHeaderMap::isolatedCopy() &&
{
HTTPHeaderMap map;
map.m_commonHeaders = crossThreadCopy(WTFMove(m_commonHeaders));
map.m_uncommonHeaders = crossThreadCopy(WTFMove(m_uncommonHeaders));
map.m_setCookieHeaders = crossThreadCopy(WTFMove(m_setCookieHeaders));
return map;
}
String HTTPHeaderMap::get(const StringView name) const
{
HTTPHeaderName headerName;
if (findHTTPHeaderName(name, headerName))
return get(headerName);
return getUncommonHeader(name);
}
size_t HTTPHeaderMap::memoryCost() const
{
size_t cost = m_commonHeaders.size() * sizeof(CommonHeader);
cost += m_uncommonHeaders.size() * sizeof(UncommonHeader);
cost += m_setCookieHeaders.size() * sizeof(String);
for (auto& header : m_commonHeaders)
cost += header.value.sizeInBytes();
for (auto& header : m_uncommonHeaders) {
cost += header.key.sizeInBytes();
cost += header.value.sizeInBytes();
}
for (auto& header : m_setCookieHeaders)
cost += header.sizeInBytes();
return cost;
}
String HTTPHeaderMap::getUncommonHeader(const StringView name) const
{
auto index = m_uncommonHeaders.findIf([&](auto& header) {
return equalIgnoringASCIICase(header.key, name);
});
return index != notFound ? m_uncommonHeaders[index].value : String();
}
#if USE(CF)
void HTTPHeaderMap::set(CFStringRef name, const String& value)
{
// Fast path: avoid constructing a temporary String in the common header case.
if (auto* nameCharacters = CFStringGetCStringPtr(name, kCFStringEncodingASCII)) {
unsigned length = CFStringGetLength(name);
HTTPHeaderName headerName;
if (findHTTPHeaderName(StringView(nameCharacters, length), headerName))
set(headerName, value);
else
setUncommonHeader(String(nameCharacters, length), value);
return;
}
set(String(name), value);
}
#endif // USE(CF)
void HTTPHeaderMap::set(const String& name, const String& value)
{
HTTPHeaderName headerName;
if (findHTTPHeaderName(name, headerName)) {
set(headerName, value);
return;
}
setUncommonHeader(name, value);
}
void HTTPHeaderMap::setUncommonHeader(const String& name, const String& value)
{
auto index = m_uncommonHeaders.findIf([&](auto& header) {
return equalIgnoringASCIICase(header.key, name);
});
if (index == notFound)
m_uncommonHeaders.append(UncommonHeader { name, value });
else
m_uncommonHeaders[index].value = value;
}
void HTTPHeaderMap::setUncommonHeaderCloneName(const StringView name, const String& value)
{
auto index = m_uncommonHeaders.findIf([&](auto& header) {
return equalIgnoringASCIICase(header.key, name);
});
if (index == notFound) {
std::span<Latin1Character> ptr;
auto nameCopy = WTF::String::createUninitialized(name.length(), ptr);
memcpy(ptr.data(), name.span8().data(), name.length());
m_uncommonHeaders.append(UncommonHeader { nameCopy, value });
} else
m_uncommonHeaders[index].value = value;
}
void HTTPHeaderMap::add(const String& name, const String& value)
{
HTTPHeaderName headerName;
if (findHTTPHeaderName(name, headerName)) {
add(headerName, value);
return;
}
auto index = m_uncommonHeaders.findIf([&](auto& header) {
return equalIgnoringASCIICase(header.key, name);
});
if (index == notFound)
m_uncommonHeaders.append(UncommonHeader { name, value });
else
m_uncommonHeaders[index].value = makeString(m_uncommonHeaders[index].value, ", "_s, value);
}
void HTTPHeaderMap::append(const String& name, const String& value)
{
ASSERT(!contains(name));
HTTPHeaderName headerName;
if (findHTTPHeaderName(name, headerName)) {
if (headerName == HTTPHeaderName::SetCookie)
m_setCookieHeaders.append(value);
else
m_commonHeaders.append(CommonHeader { headerName, value });
} else {
m_uncommonHeaders.append(UncommonHeader { name, value });
}
}
bool HTTPHeaderMap::addIfNotPresent(HTTPHeaderName headerName, const String& value)
{
if (contains(headerName))
return false;
m_commonHeaders.append(CommonHeader { headerName, value });
return true;
}
bool HTTPHeaderMap::contains(const StringView name) const
{
HTTPHeaderName headerName;
if (findHTTPHeaderName(name, headerName))
return contains(headerName);
return m_uncommonHeaders.findIf([&](auto& header) {
return equalIgnoringASCIICase(header.key, name);
}) != notFound;
}
bool HTTPHeaderMap::remove(const StringView name)
{
HTTPHeaderName headerName;
if (findHTTPHeaderName(name, headerName))
return remove(headerName);
return removeUncommonHeader(name);
}
bool HTTPHeaderMap::removeUncommonHeader(const StringView name)
{
#if ASSERT_ENABLED
HTTPHeaderName headerName;
ASSERT(!findHTTPHeaderName(name, headerName));
#endif
return m_uncommonHeaders.removeFirstMatching([&](auto& header) {
return equalIgnoringASCIICase(header.key, name);
});
}
String HTTPHeaderMap::get(HTTPHeaderName name) const
{
if (name == HTTPHeaderName::SetCookie) {
unsigned count = m_setCookieHeaders.size();
switch (count) {
case 0:
return String();
case 1:
return m_setCookieHeaders[0];
default: {
StringBuilder builder;
builder.reserveCapacity(m_setCookieHeaders[0].length() * count + (count - 1));
builder.append(m_setCookieHeaders[0]);
for (unsigned i = 1; i < count; ++i) {
builder.append(", "_s);
builder.append(m_setCookieHeaders[i]);
}
return builder.toString();
}
}
}
auto index = m_commonHeaders.findIf([&](auto& header) {
return header.key == name;
});
return index != notFound ? m_commonHeaders[index].value : String();
}
HTTPHeaderMap::HeaderIndex HTTPHeaderMap::indexOf(HTTPHeaderName name) const
{
auto index = m_commonHeaders.findIf([&](auto& header) {
return header.key == name;
});
return (HeaderIndex) { .index = index, .isCommon = true };
}
HTTPHeaderMap::HeaderIndex HTTPHeaderMap::indexOf(const String& name) const
{
auto index = m_uncommonHeaders.findIf([&](auto& header) {
return equalIgnoringASCIICase(header.key, name);
});
return (HeaderIndex) { .index = index, .isCommon = false };
}
String HTTPHeaderMap::getIndex(HTTPHeaderMap::HeaderIndex index) const
{
if (index.index == notFound)
return String();
if (index.isCommon)
return m_commonHeaders[index.index].value;
return m_uncommonHeaders[index.index].value;
}
void HTTPHeaderMap::set(HTTPHeaderName name, const String& value)
{
if (name == HTTPHeaderName::SetCookie) {
m_setCookieHeaders.clear();
m_setCookieHeaders.append(value);
return;
}
auto index = m_commonHeaders.findIf([&](auto& header) {
return header.key == name;
});
if (index == notFound)
m_commonHeaders.append(CommonHeader { name, value });
else
m_commonHeaders[index].value = value;
}
bool HTTPHeaderMap::setIndex(HTTPHeaderMap::HeaderIndex index, const String& value)
{
if (!index.isValid())
return false;
if (index.isCommon) {
m_commonHeaders[index.index].value = value;
} else {
m_uncommonHeaders[index.index].value = value;
}
return true;
}
bool HTTPHeaderMap::contains(HTTPHeaderName name) const
{
if (name == HTTPHeaderName::SetCookie)
return !m_setCookieHeaders.isEmpty();
return m_commonHeaders.findIf([&](auto& header) {
return header.key == name;
}) != notFound;
}
bool HTTPHeaderMap::remove(HTTPHeaderName name)
{
if (name == HTTPHeaderName::SetCookie) {
bool any = m_setCookieHeaders.size() > 0;
m_setCookieHeaders.clear();
return any;
}
return m_commonHeaders.removeFirstMatching([&](auto& header) {
return header.key == name;
});
}
void HTTPHeaderMap::add(HTTPHeaderName name, const String& value)
{
if (name == HTTPHeaderName::SetCookie) {
m_setCookieHeaders.append(value);
return;
}
auto index = m_commonHeaders.findIf([&](auto& header) {
return header.key == name;
});
if (index != notFound)
m_commonHeaders[index].value = makeString(m_commonHeaders[index].value, name == HTTPHeaderName::Cookie ? "; "_s : ", "_s, value);
else
m_commonHeaders.append(CommonHeader { name, value });
}
} // namespace WebCore