mirror of
https://github.com/oven-sh/bun
synced 2026-02-02 15:08:46 +00:00
## Summary - Refactor 16 test files to use async `Bun.spawn` instead of `Bun.spawnSync` - Wrap tests in `describe.concurrent` blocks for parallel execution - Use `await using` for automatic resource cleanup ## Performance Improvement | Test File | Before | After | Improvement | |-----------|--------|-------|-------------| | `node-module-module.test.js` (28 tests) | ~325ms | ~185ms | **43% faster** | | `non-english-import.test.js` (3 tests) | ~238ms | ~157ms | **34% faster** | ## Files Changed - `test/cli/run/commonjs-invalid.test.ts` - `test/cli/run/commonjs-no-export.test.ts` - `test/cli/run/empty-file.test.ts` - `test/cli/run/jsx-symbol-collision.test.ts` - `test/cli/run/run-cjs.test.ts` - `test/cli/run/run-extensionless.test.ts` - `test/cli/run/run-shell.test.ts` - `test/cli/run/run-unicode.test.ts` - `test/js/bun/resolve/non-english-import.test.js` - `test/js/node/module/node-module-module.test.js` - `test/regression/issue/00631.test.ts` - `test/regression/issue/03216.test.ts` - `test/regression/issue/03830.test.ts` - `test/regression/issue/04011.test.ts` - `test/regression/issue/04893.test.ts` - `test/regression/issue/hashbang-still-works.test.ts` ## Test plan - [x] All refactored tests pass with `USE_SYSTEM_BUN=1 bun test <file>` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com>
65 lines
1.8 KiB
TypeScript
65 lines
1.8 KiB
TypeScript
import { describe, expect, test } from "bun:test";
|
|
import { bunEnv, bunExe, tempDirWithFiles } from "harness";
|
|
import path from "path";
|
|
|
|
describe.concurrent("hashbang-still-works", () => {
|
|
test("hashbang still works after bounds check fix", async () => {
|
|
const dir = tempDirWithFiles("hashbang", {
|
|
"script.js": "#!/usr/bin/env bun\nconsole.log('hello');",
|
|
});
|
|
|
|
await using proc = Bun.spawn({
|
|
cmd: [bunExe(), "--bun", "script.js"],
|
|
env: bunEnv,
|
|
cwd: dir,
|
|
});
|
|
|
|
const [stdout, stderr, exitCode] = await Promise.all([
|
|
new Response(proc.stdout).text(),
|
|
new Response(proc.stderr).text(),
|
|
proc.exited,
|
|
]);
|
|
|
|
expect(exitCode).toBe(0);
|
|
expect(stdout.trim()).toBe("hello");
|
|
});
|
|
|
|
test("lexer handles single # character without bounds error", async () => {
|
|
const dir = tempDirWithFiles("single-hash", {
|
|
"single-hash.js": "#",
|
|
});
|
|
|
|
// Using Bun.build to exercise the lexer directly
|
|
try {
|
|
await Bun.build({
|
|
entrypoints: [path.join(dir, "single-hash.js")],
|
|
target: "node",
|
|
});
|
|
expect.unreachable();
|
|
} catch (e: any) {
|
|
const errorMessage = Bun.inspect((e as AggregateError).errors[0]);
|
|
expect(errorMessage).toContain("error: Syntax Error");
|
|
}
|
|
});
|
|
|
|
test("lexer should not crash on single # character", async () => {
|
|
const dir = tempDirWithFiles("single-hash", {
|
|
"single-hash.js": "#",
|
|
});
|
|
|
|
await using proc = Bun.spawn({
|
|
cmd: [bunExe(), "single-hash.js"],
|
|
env: bunEnv,
|
|
cwd: dir,
|
|
stdout: "pipe",
|
|
stderr: "pipe",
|
|
});
|
|
|
|
const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]);
|
|
|
|
const output = stdout + stderr;
|
|
expect(output).toContain("error: Syntax Error");
|
|
expect(exitCode).toBe(1);
|
|
});
|
|
});
|