Files
bun.sh/src/install/hoisted_install.zig
Alistair Smith 3ee477fc5b fix: scanner on update, install, remove, uninstall and add, and introduce the pm scan command (#22193)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
2025-09-09 21:42:01 -07:00

386 lines
16 KiB
Zig

pub fn installHoistedPackages(
this: *PackageManager,
ctx: Command.Context,
workspace_filters: []const WorkspaceFilter,
install_root_dependencies: bool,
log_level: PackageManager.Options.LogLevel,
packages_to_install: ?[]const PackageID,
) !PackageInstall.Summary {
bun.analytics.Features.hoisted_bun_install += 1;
const original_trees = this.lockfile.buffers.trees;
const original_tree_dep_ids = this.lockfile.buffers.hoisted_dependencies;
try this.lockfile.filter(this.log, this, install_root_dependencies, workspace_filters, packages_to_install);
defer {
this.lockfile.buffers.trees = original_trees;
this.lockfile.buffers.hoisted_dependencies = original_tree_dep_ids;
}
var root_node: *Progress.Node = undefined;
var download_node: Progress.Node = undefined;
var install_node: Progress.Node = undefined;
var scripts_node: Progress.Node = undefined;
const options = &this.options;
var progress = &this.progress;
if (log_level.showProgress()) {
progress.supports_ansi_escape_codes = Output.enable_ansi_colors_stderr;
root_node = progress.start("", 0);
download_node = root_node.start(ProgressStrings.download(), 0);
install_node = root_node.start(ProgressStrings.install(), this.lockfile.buffers.hoisted_dependencies.items.len);
scripts_node = root_node.start(ProgressStrings.script(), 0);
this.downloads_node = &download_node;
this.scripts_node = &scripts_node;
}
defer {
if (log_level.showProgress()) {
progress.root.end();
progress.* = .{};
}
}
// If there was already a valid lockfile and so we did not resolve, i.e. there was zero network activity
// the packages could still not be in the cache dir
// this would be a common scenario in a CI environment
// or if you just cloned a repo
// we want to check lazily though
// no need to download packages you've already installed!!
var new_node_modules = false;
const cwd = bun.FD.cwd();
const node_modules_folder = brk: {
// Attempt to open the existing node_modules folder
switch (bun.sys.openatOSPath(cwd, bun.OSPathLiteral("node_modules"), bun.O.DIRECTORY | bun.O.RDONLY, 0o755)) {
.result => |fd| break :brk std.fs.Dir{ .fd = fd.cast() },
.err => {},
}
new_node_modules = true;
// Attempt to create a new node_modules folder
if (bun.sys.mkdir("node_modules", 0o755).asErr()) |err| {
if (err.errno != @intFromEnum(bun.sys.E.EXIST)) {
Output.err(err, "could not create the <b>\"node_modules\"<r> directory", .{});
Global.crash();
}
}
break :brk bun.openDir(cwd.stdDir(), "node_modules") catch |err| {
Output.err(err, "could not open the <b>\"node_modules\"<r> directory", .{});
Global.crash();
};
};
var skip_delete = new_node_modules;
var skip_verify_installed_version_number = new_node_modules;
if (options.enable.force_install) {
skip_verify_installed_version_number = true;
skip_delete = false;
}
var summary = PackageInstall.Summary{};
{
var iterator = Lockfile.Tree.Iterator(.node_modules).init(this.lockfile);
if (comptime Environment.isPosix) {
Bin.Linker.ensureUmask();
}
var installer: PackageInstaller = brk: {
const completed_trees, const tree_ids_to_trees_the_id_depends_on = trees: {
const trees = this.lockfile.buffers.trees.items;
const completed_trees = try Bitset.initEmpty(this.allocator, trees.len);
var tree_ids_to_trees_the_id_depends_on = try Bitset.List.initEmpty(this.allocator, trees.len, trees.len);
{
// For each tree id, traverse through it's parents and mark all visited tree
// ids as dependents for the current tree parent
var deps = try Bitset.initEmpty(this.allocator, trees.len);
defer deps.deinit(this.allocator);
for (trees) |_curr| {
var curr = _curr;
tree_ids_to_trees_the_id_depends_on.set(curr.id, curr.id);
while (curr.parent != Lockfile.Tree.invalid_id) {
deps.set(curr.id);
tree_ids_to_trees_the_id_depends_on.setUnion(curr.parent, deps);
curr = trees[curr.parent];
}
deps.setAll(false);
}
}
if (comptime Environment.allow_assert) {
if (trees.len > 0) {
// last tree should only depend on one other
bun.assertWithLocation(tree_ids_to_trees_the_id_depends_on.at(trees.len - 1).count() == 1, @src());
// and it should be itself
bun.assertWithLocation(tree_ids_to_trees_the_id_depends_on.at(trees.len - 1).isSet(trees.len - 1), @src());
// root tree should always depend on all trees
bun.assertWithLocation(tree_ids_to_trees_the_id_depends_on.at(0).count() == trees.len, @src());
}
// a tree should always depend on itself
for (0..trees.len) |j| {
bun.assertWithLocation(tree_ids_to_trees_the_id_depends_on.at(j).isSet(j), @src());
}
}
break :trees .{
completed_trees,
tree_ids_to_trees_the_id_depends_on,
};
};
// These slices potentially get resized during iteration
// so we want to make sure they're not accessible to the rest of this function
// to make mistakes harder
var parts = this.lockfile.packages.slice();
break :brk PackageInstaller{
.manager = this,
.options = &this.options,
.metas = parts.items(.meta),
.bins = parts.items(.bin),
.root_node_modules_folder = node_modules_folder,
.names = parts.items(.name),
.pkg_name_hashes = parts.items(.name_hash),
.resolutions = parts.items(.resolution),
.pkg_dependencies = parts.items(.dependencies),
.lockfile = this.lockfile,
.node = &install_node,
.node_modules = .{
.path = std.ArrayList(u8).fromOwnedSlice(
this.allocator,
try this.allocator.dupe(
u8,
strings.withoutTrailingSlash(FileSystem.instance.top_level_dir),
),
),
.tree_id = 0,
},
.progress = progress,
.skip_verify_installed_version_number = skip_verify_installed_version_number,
.skip_delete = skip_delete,
.summary = &summary,
.force_install = options.enable.force_install,
.successfully_installed = try Bitset.initEmpty(
this.allocator,
this.lockfile.packages.len,
),
.tree_iterator = &iterator,
.command_ctx = ctx,
.tree_ids_to_trees_the_id_depends_on = tree_ids_to_trees_the_id_depends_on,
.completed_trees = completed_trees,
.trees = trees: {
const trees = bun.handleOom(this.allocator.alloc(TreeContext, this.lockfile.buffers.trees.items.len));
for (0..this.lockfile.buffers.trees.items.len) |i| {
trees[i] = .{
.binaries = Bin.PriorityQueue.init(this.allocator, .{
.dependencies = &this.lockfile.buffers.dependencies,
.string_buf = &this.lockfile.buffers.string_bytes,
}),
};
}
break :trees trees;
},
.trusted_dependencies_from_update_requests = this.findTrustedDependenciesFromUpdateRequests(),
.seen_bin_links = bun.StringHashMap(void).init(this.allocator),
};
};
try installer.node_modules.path.append(std.fs.path.sep);
defer installer.deinit();
while (iterator.next(&installer.completed_trees)) |node_modules| {
installer.node_modules.path.items.len = strings.withoutTrailingSlash(FileSystem.instance.top_level_dir).len + 1;
try installer.node_modules.path.appendSlice(node_modules.relative_path);
installer.node_modules.tree_id = node_modules.tree_id;
var remaining = node_modules.dependencies;
installer.current_tree_id = node_modules.tree_id;
if (comptime Environment.allow_assert) {
bun.assert(node_modules.dependencies.len == this.lockfile.buffers.trees.items[installer.current_tree_id].dependencies.len);
}
// cache line is 64 bytes on ARM64 and x64
// PackageIDs are 4 bytes
// Hence, we can fit up to 64 / 4 = 16 package IDs in a cache line
const unroll_count = comptime 64 / @sizeOf(PackageID);
while (remaining.len > unroll_count) {
comptime var i: usize = 0;
inline while (i < unroll_count) : (i += 1) {
installer.installPackage(remaining[i], log_level);
}
remaining = remaining[unroll_count..];
// We want to minimize how often we call this function
// That's part of why we unroll this loop
if (this.pendingTaskCount() > 0) {
try this.runTasks(
*PackageInstaller,
&installer,
.{
.onExtract = PackageInstaller.installEnqueuedPackagesAfterExtraction,
.onResolve = {},
.onPackageManifestError = {},
.onPackageDownloadError = {},
},
true,
log_level,
);
if (!installer.options.do.install_packages) return error.InstallFailed;
}
this.tickLifecycleScripts();
this.reportSlowLifecycleScripts();
}
for (remaining) |dependency_id| {
installer.installPackage(dependency_id, log_level);
}
try this.runTasks(
*PackageInstaller,
&installer,
.{
.onExtract = PackageInstaller.installEnqueuedPackagesAfterExtraction,
.onResolve = {},
.onPackageManifestError = {},
.onPackageDownloadError = {},
},
true,
log_level,
);
if (!installer.options.do.install_packages) return error.InstallFailed;
this.tickLifecycleScripts();
this.reportSlowLifecycleScripts();
}
while (this.pendingTaskCount() > 0 and installer.options.do.install_packages) {
const Closure = struct {
installer: *PackageInstaller,
err: ?anyerror = null,
manager: *PackageManager,
pub fn isDone(closure: *@This()) bool {
const pm = closure.manager;
closure.manager.runTasks(
*PackageInstaller,
closure.installer,
.{
.onExtract = PackageInstaller.installEnqueuedPackagesAfterExtraction,
.onResolve = {},
.onPackageManifestError = {},
.onPackageDownloadError = {},
},
true,
pm.options.log_level,
) catch |err| {
closure.err = err;
};
if (closure.err != null) {
return true;
}
closure.manager.reportSlowLifecycleScripts();
if (PackageManager.verbose_install and closure.manager.pendingTaskCount() > 0) {
const pending_task_count = closure.manager.pendingTaskCount();
if (pending_task_count > 0 and PackageManager.hasEnoughTimePassedBetweenWaitingMessages()) {
Output.prettyErrorln("<d>[PackageManager]<r> waiting for {d} tasks\n", .{pending_task_count});
}
}
return closure.manager.pendingTaskCount() == 0 and closure.manager.hasNoMorePendingLifecycleScripts();
}
};
var closure = Closure{
.installer = &installer,
.manager = this,
};
// Whenever the event loop wakes up, we need to call `runTasks`
// If we call sleep() instead of sleepUntil(), it will wait forever until there are no more lifecycle scripts
// which means it will not call runTasks until _all_ current lifecycle scripts have finished running
this.sleepUntil(&closure, &Closure.isDone);
if (closure.err) |err| {
return err;
}
} else {
this.tickLifecycleScripts();
this.reportSlowLifecycleScripts();
}
for (installer.trees) |tree| {
if (comptime Environment.allow_assert) {
bun.assert(tree.pending_installs.items.len == 0);
}
const force = true;
installer.installAvailablePackages(log_level, force);
}
// .monotonic is okay because this value is only accessed on this thread.
this.finished_installing.store(true, .monotonic);
if (log_level.showProgress()) {
scripts_node.activate();
}
if (!installer.options.do.install_packages) return error.InstallFailed;
summary.successfully_installed = installer.successfully_installed;
// need to make sure bins are linked before completing any remaining scripts.
// this can happen if a package fails to download
installer.linkRemainingBins(log_level);
installer.completeRemainingScripts(log_level);
// .monotonic is okay because this value is only accessed on this thread.
while (this.pending_lifecycle_script_tasks.load(.monotonic) > 0) {
this.reportSlowLifecycleScripts();
this.sleep();
}
if (log_level.showProgress()) {
scripts_node.end();
}
}
return summary;
}
const std = @import("std");
const bun = @import("bun");
const Environment = bun.Environment;
const Global = bun.Global;
const Output = bun.Output;
const Progress = bun.Progress;
const strings = bun.strings;
const Bitset = bun.bit_set.DynamicBitSetUnmanaged;
const Command = bun.cli.Command;
const FileSystem = bun.fs.FileSystem;
const install = bun.install;
const Bin = install.Bin;
const Lockfile = install.Lockfile;
const PackageID = install.PackageID;
const PackageInstall = install.PackageInstall;
const PackageManager = install.PackageManager;
const ProgressStrings = PackageManager.ProgressStrings;
const WorkspaceFilter = PackageManager.WorkspaceFilter;
const PackageInstaller = PackageManager.PackageInstaller;
const TreeContext = PackageInstaller.TreeContext;