mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-16 05:42:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
fef57b9b79031a46d8ca89742855f0fc0039b0a9
bun.sh/src
History
Claude Bot fef57b9b79 Fix getConnections to match Node.js behavior - validate callback and use process.nextTick 
This improves the getConnections() implementation to match Node.js:

1. **Validate callback argument**: Now throws ERR_INVALID_ARG_TYPE if
   callback is not a function, matching Node.js behavior

2. **Async callback**: Uses process.nextTick to call the callback
   asynchronously, matching Node.js behavior. In Node.js, this is
   necessary because it needs to poll worker processes in cluster mode.

3. **Better comments**: Explained why it's async (cluster/worker polling)
   and why it can't error in Bun (no workers yet)

Applied the same fix to both:
- http.Server.getConnections (src/js/node/_http_server.ts:290-296)
- net.Server.getConnections (src/js/node/net.ts:2170-2176)

Added test for validation behavior to ensure:
- Throws for undefined callback
- Throws for null callback
- Throws for non-function values

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-10 23:34:50 +00:00
..
allocators
Remove MemoryReportingAllocator (#24251)
2025-10-31 19:50:55 -07:00
analytics
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
api
zig: remove Location.suggestion (#23478)
2025-10-27 12:26:21 -07:00
ast
Updates eqlComptime to resolve the rope if needed (#23883)
2025-10-20 21:18:47 -07:00
async
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
bake
zig: bun.sourcemap -> bun.SourceMap (#23477)
2025-10-27 12:26:09 -07:00
base64
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bun.js
deps: update sqlite to 3.51.0 (#24530)
2025-11-09 01:09:25 -08:00
bundler
zig: remove Location.suggestion (#23478)
2025-10-27 12:26:21 -07:00
cli
Implement isolated event loop for spawnSync (#24436)
2025-11-07 05:28:33 -08:00
codegen
Fix bindgenv2 type annotations (#24139)
2025-11-05 12:45:43 -08:00
collections
implement publicHoistPattern and hoistPattern (#23567)
2025-10-21 14:18:39 -07:00
create
Fix Windows shell crash with && operator and external commands (#22651)
2025-09-14 04:14:48 -07:00
css
fix(css): process color-scheme rules inside @layer blocks (#24034)
2025-10-24 19:27:14 -07:00
deps
Implement isolated event loop for spawnSync (#24436)
2025-11-07 05:28:33 -08:00
errno
Add missing libuv errcodes UV_ENOEXEC and UV_EFTYPE (#23854)
2025-10-20 23:46:44 -07:00
fs
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
glob
Add missing error handling for directory entries errors (#23511)
2025-10-11 19:21:14 -07:00
http
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
init
fix: fix broken scripts in the React templates after the index.ts rename (#23472)
2025-10-10 22:49:45 -07:00
install
fix(install): create bun.lock instead of bun.lockb if npm/yarn/pnpm migration fails (#24494)
2025-11-07 20:58:44 -08:00
interchange
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
io
Implement isolated event loop for spawnSync (#24436)
2025-11-07 05:28:33 -08:00
js
Fix getConnections to match Node.js behavior - validate callback and use process.nextTick
2025-11-10 23:34:50 +00:00
js_lexer
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
libarchive
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
meta
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
napi
fix(NAPI): return detached buffer from napi_create_external_buffer if empty (#24297)
2025-11-01 22:21:41 -07:00
node-fallbacks
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
paths
Make --linker=isolated the default for bun install (#23311)
2025-10-08 18:00:38 -07:00
ptr
Add .cloneUpgrade() to fix clone-upgrade (#23201)
2025-10-03 16:13:06 -07:00
resolver
feat(ENG-21324): Implement hosted_git_info.zig (#24138)
2025-10-29 19:29:04 -07:00
s3
zig: fix s3 list-objects memory leak (#23880)
2025-10-20 20:28:14 -07:00
safety
Remove MemoryReportingAllocator (#24251)
2025-10-31 19:50:55 -07:00
semver
Fix Output.enable_ansi_colors usage to check stdout vs stderr (#24212)
2025-10-31 19:08:41 -07:00
shell
Implement isolated event loop for spawnSync (#24436)
2025-11-07 05:28:33 -08:00
sourcemap
Fix source index bounds check in sourcemap decoder (#24145)
2025-10-28 12:32:53 -07:00
sql
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
string
feat(ENG-21324): Implement hosted_git_info.zig (#24138)
2025-10-29 19:29:04 -07:00
sys
Preserve original types in PosixStat
2025-10-16 21:52:22 -04:00
test
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
threading
Require deinit function for memory.deinit() (#22923)
2025-09-26 13:47:24 -07:00
valkey
bug(ENG-21479): Fix Valkey URL Parsing (#24458)
2025-11-07 21:18:07 -08:00
vm
Add support for node:vm.SyntheticModule (#19878)
2025-06-04 19:41:26 -07:00
watcher
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
windows
Convert os.environ to WTF-8 (#23885)
2025-10-20 20:52:35 -07:00
.clang-format
…
AGENTS.md
update CLAUDE.md
2025-10-04 02:17:55 -07:00
allocators.zig
Remove MemoryReportingAllocator (#24251)
2025-10-31 19:50:55 -07:00
analytics.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
asan-config.c
misc tidyings from another branch (#24406)
2025-11-05 15:28:28 -08:00
asan.zig
Add asan checks to HiveArray (#21449)
2025-07-29 19:35:46 -07:00
ast.zig
fix(bundler): import.meta.url and esm wrapper fixes (#23803)
2025-10-18 20:49:57 -07:00
bake.bind.ts
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bake.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
bits.zig
…
boringssl.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
brotli.zig
fix: handle empty chunked gzip responses correctly (#22360)
2025-09-03 18:57:39 -07:00
btjs.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
bun.exe.manifest
Enable Windows long path support (#21244)
2025-07-20 23:04:17 -07:00
bun.ico
…
bun.js.zig
Implement --cpu-prof CLI flag (#24112)
2025-10-29 16:41:21 -07:00
bun.zig
Move Bun.spawn & Bun.spawnSync into a separate file (#24425)
2025-11-05 22:03:27 -08:00
bunfig.zig
implement publicHoistPattern and hoistPattern (#23567)
2025-10-21 14:18:39 -07:00
c-headers-for-zig.h
node:zlib: add zstd (#20313)
2025-06-12 14:20:28 -07:00
cache.zig
zig: remove bun.fs_allocator alias (#22782)
2025-09-18 19:37:24 -07:00
ci_info.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
CLAUDE.md
Add some internal deprecation @compileError messages
2025-10-24 23:42:20 -07:00
cli.zig
Make 'bun list' an alias for 'bun pm ls' (#24159)
2025-10-29 21:05:25 -07:00
collections.zig
Add generic-allocator ArrayList (#22917)
2025-09-26 15:19:45 -07:00
compile_target.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
comptime_string_map.zig
feat(ENG-21324): Implement hosted_git_info.zig (#24138)
2025-10-29 19:29:04 -07:00
ConfigVersion.zig
add "configVersion" to bun.lock(b) (#24236)
2025-11-03 22:20:07 -08:00
copy_file.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
crash_handler.zig
Use std.debug.captureStackTrace on all platforms (#24456)
2025-11-07 04:07:53 -08:00
csrf.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
darwin.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
defines-table.zig
fix(build): Promise.all() async module dependencies (#22704)
2025-09-26 22:21:00 -07:00
defines.zig
ci: instrument being able to run leaksanitizer (#21142)
2025-09-19 02:06:02 -07:00
dir.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
dns.zig
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
env_loader.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
env_var.zig
Add postinstall optimizer with native binlink support and script skipping (#24283)
2025-11-03 20:36:22 -08:00
env.zig
Dev server refactoring, part 1 (mainly IncrementalGraph) (#22010)
2025-08-22 23:04:58 -07:00
fallback-backend.html
…
fallback.html
…
fallback.ts
…
favicon.png
…
fd.zig
Fix pipeline stack errors on Windows (#21800)
2025-08-14 18:03:26 -07:00
feature_flags.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
fixtures_example.com.html
…
fmt.bind.ts
…
fmt.zig
Fix Output.enable_ansi_colors usage to check stdout vs stderr (#24212)
2025-10-31 19:08:41 -07:00
fs.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
generated_perf_trace_events.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
glob.zig
fix(install): make negative workspace patterns work (#23229)
2025-10-04 00:31:47 -07:00
Global.zig
Fix: Error when using bun build --no-bundle with HTML entrypoint (#23572)
2025-10-19 23:29:29 -07:00
handle_oom.zig
Passthrough anyerror when using handleOom (#23176)
2025-10-02 14:11:29 -07:00
heap_breakdown.zig
disable heap_breakdown when asan is enabled
2025-09-19 02:38:38 -07:00
highway.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
hmac.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
HTMLScanner.zig
Refactor BabyList (#22502)
2025-09-09 20:41:10 -07:00
http.zig
Write more data faster (#23989)
2025-10-23 17:52:13 -07:00
identity_context.zig
implement "nodeLinker": "isolated" in bun install (#20440)
2025-07-09 00:19:57 -07:00
import_record.zig
Eliminates special handling for bun:test in the transpiler (#22888)
2025-10-14 20:51:34 -07:00
ini.zig
implement publicHoistPattern and hoistPattern (#23567)
2025-10-21 14:18:39 -07:00
interchange.zig
Add Bun.YAML.parse and YAML imports (#22073)
2025-08-23 06:55:30 -07:00
js_lexer_tables.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
js_lexer.zig
fix writing UTF-16 with a trailing unpaired surrogate to process.stdout/stderr (#23444)
2025-10-10 03:48:04 -07:00
js_parser.zig
'vi' was missing from bun test globals (#23674)
2025-10-15 14:31:27 -07:00
js_printer.zig
zig: bun.sourcemap -> bun.SourceMap (#23477)
2025-10-27 12:26:09 -07:00
jsc_stub.zig
…
linear_fifo.zig
Fix linear_fifo (#22590)
2025-09-11 23:29:53 -07:00
linker.lds
…
linker.zig
Eliminates special handling for bun:test in the transpiler (#22888)
2025-10-14 20:51:34 -07:00
linux.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
logger.zig
Fix Output.enable_ansi_colors usage to check stdout vs stderr (#24212)
2025-10-31 19:08:41 -07:00
logo.svg
…
macho.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
main_test.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
main_wasm.zig
Replace catch bun.outOfMemory() with safer alternatives (#22141)
2025-08-26 12:50:25 -07:00
main.zig
Autoformat
2025-10-25 00:05:28 -07:00
memory.zig
Port SocketConfig to bindings generator (#23755)
2025-10-18 18:14:01 -07:00
meta.zig
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
node_fallbacks.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
open.zig
Fix Windows shell crash with && operator and external commands (#22651)
2025-09-14 04:14:48 -07:00
options.zig
Eliminates special handling for bun:test in the transpiler (#22888)
2025-10-14 20:51:34 -07:00
output.zig
Fix Output.enable_ansi_colors usage to check stdout vs stderr (#24212)
2025-10-31 19:08:41 -07:00
OutputFile.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
patch.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
paths.zig
fix(pnpm migration): correctly resolve link: dependencies on the root package (#23111)
2025-09-30 00:10:15 -07:00
pe.zig
feat(windows): implement authenticode stripping for --compile (#22960)
2025-09-25 18:03:27 -07:00
perf.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
pool.zig
Refactor BabyList (#22502)
2025-09-09 20:41:10 -07:00
Progress.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
ptr.zig
Add ExternalShared and RawRefCount (#23013)
2025-09-26 15:15:58 -07:00
renamer.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
result.zig
…
router.zig
Replace catch bun.outOfMemory() with safer alternatives (#22141)
2025-08-26 12:50:25 -07:00
runtime.bun.js
…
runtime.js
fix(build): Promise.all() async module dependencies (#22704)
2025-09-26 22:21:00 -07:00
runtime.zig
fix(build): Promise.all() async module dependencies (#22704)
2025-09-26 22:21:00 -07:00
safety.zig
Static allocator polymorphism (#22227)
2025-09-03 15:40:44 -07:00
semver.zig
fix(install): change semver core numbers to u64 (#22889)
2025-09-22 19:28:26 -07:00
sha.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
SignalCode.zig
Move Bun.spawn & Bun.spawnSync into a separate file (#24425)
2025-11-05 22:03:27 -08:00
StandaloneModuleGraph.zig
zig: bun.sourcemap -> bun.SourceMap (#23477)
2025-10-27 12:26:09 -07:00
StaticHashMap.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
string.zig
Fix incorrect/suspicious uses of ZigString.Slice.cloneIfNeeded (#23937)
2025-10-23 13:17:51 -07:00
symbols.def
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
symbols.dyn
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
symbols.txt
Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737)
2025-07-13 04:27:43 -07:00
sys_uv.zig
Implement birthtime support on Linux using statx syscall (#23209)
2025-10-04 04:57:29 -07:00
sys.zig
Fix memory leaks & blocking syscall in Bun Shell (#23636)
2025-10-19 22:17:19 -07:00
system_timer.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
threading.zig
Static allocator polymorphism (#22227)
2025-09-03 15:40:44 -07:00
tmp.zig
zig: delete deprecated bun.jsc.Maybe (#21327)
2025-07-25 12:38:06 -07:00
tracy.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
trait.zig
…
transpiler.zig
feat(ENG-21362): Environment Variables Store (#23930)
2025-10-23 23:08:08 -07:00
tsconfig.json
Add new bindings generator; port SSLConfig (#23169)
2025-10-03 17:10:28 -07:00
unit_test.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
url.zig
zig: handle termination exception from promise fulfullment/rejection (#23285)
2025-10-14 19:48:25 -07:00
util.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
walker_skippable.zig
chore: Mutable deinitializers (#23876)
2025-10-20 20:39:46 -07:00
Watcher.zig
fix(watcher): handle vim atomic save race on macOS (#23566)
2025-10-14 16:33:30 -07:00
which_npm_client.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
which.zig
Rename disabled parameter in Output.scoped (#21769)
2025-08-11 20:19:34 -07:00
windows-app-info.rc
Enable Windows long path support (#21244)
2025-07-20 23:04:17 -07:00
windows.zig
Convert os.environ to WTF-8 (#23885)
2025-10-20 20:52:35 -07:00
work_pool.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
workaround_missing_symbols.zig
Refactor Zig imports and file structure (part 1) (#21270)
2025-07-22 17:51:38 -07:00
wyhash.zig
Sort imports in all files (#21119)
2025-07-21 13:26:47 -07:00
zlib.test.gz
…
zlib.test.txt
…
zlib.zig
fix: handle empty chunked gzip responses correctly (#22360)
2025-09-03 18:57:39 -07:00