mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 16:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up Destroy pattern everywhere, fix missing overrides (#202)

Browse Source 
* Rename MxMusicPresenter function vtable38

* Rename MxMusicPresenter function vtable38

* MxMediaPresenter, MxMusicManager and MxMusicPresenter
* Refactoring Destroy functions

* MxMediaManager & MxMusicPresenter

* Fix some vtable declarations, more renames

* Fix MxEventManager

* More rename fixes

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
This commit is contained in:
DmitriLeon2000
2023-10-14 01:43:45 +09:00
committed by GitHub
parent 91c3ed3e70
commit 34e09c2bb3
24 changed files with 104 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
LEGO1/mxpresenter.cpp
View File

@@ -29,7 +29,6 @@ void MxPresenter::Init()
// OFFSET: LEGO1 0x100b4fc0
void MxPresenter::ParseExtra()
{
MxAutoLocker lock(&m_criticalSection);
MxU32 len = m_action->GetExtraLength();
char *extraData = m_action->GetExtraData();
@@ -47,15 +46,13 @@ void MxPresenter::ParseExtra()
strcpy(t_token, token);
token = strtok(NULL, g_parseExtraTokens);
int val = token ? atoi(token) : 0;
int result = MxOmni::GetInstance()->vtable0x30(t_token, val, this);
MxS32 val = token ? atoi(token) : 0;
MxS32 result = MxOmni::GetInstance()->vtable0x30(t_token, val, this);
m_action->SetFlags(m_action->GetFlags() | MxDSAction::Flag_Parsed);
if (result)
SendTo_unkPresenter(MxOmni::GetInstance());
}
}
}
@@ -279,13 +276,13 @@ void MxPresenter::DoneTickle()
}
// OFFSET: LEGO1 0x1000bf70
undefined4 MxPresenter::VTable0x34()
MxResult MxPresenter::AddToManager()
{
return 0;
return SUCCESS;
}
// OFFSET: LEGO1 0x1000bf80
void MxPresenter::InitVirtual()
void MxPresenter::Destroy()
{
Init();
}