mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-24 00:44:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Discussion/Proposals) Consistency regarding annotations of header-implemented functions (#316)

Browse Source 
* Open discussion

* Move annotations of header-implemented functions back to `.h` files

* Adjust `README.md`

* Relocate annotation

* linter

* Comment markers in headers only, rename script, update github actions

* type hint compat

* Rename github action, better argparse for linter

* Type hints, working test for byname ignore

* Move annotation

* CI rename and enable warnfail, enforce mode always on

* Two step linting

* or one step

* continue on error

* two jobs instead

* Fixes

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-12 14:27:17 -05:00
committed by GitHub
parent 4dd0d60dec
commit 3b155bfe38
73 changed files with 838 additions and 650 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
LEGO1/mxcore.h
View File

@@ -8,13 +8,6 @@
class MxParam;
// TODO: Find proper compilation unit to put these
// FUNCTION: LEGO1 0x100140d0
// MxCore::IsA
// FUNCTION: LEGO1 0x100144c0
// MxCore::ClassName
// VTABLE: LEGO1 0x100dc0f8
// SIZE 0x8
class MxCore {
@@ -24,12 +17,14 @@ public:
__declspec(dllexport) virtual MxLong Notify(MxParam& p); // vtable+04
virtual MxResult Tickle(); // vtable+08
// FUNCTION: LEGO1 0x100144c0
inline virtual const char* ClassName() const // vtable+0c
{
// GLOBAL: LEGO1 0x100f007c
return "MxCore";
}
// FUNCTION: LEGO1 0x100140d0
inline virtual MxBool IsA(const char* name) const // vtable+10
{
return !strcmp(name, MxCore::ClassName());