(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -7,16 +7,16 @@
DECOMP_SIZE_ASSERT(LegoEntity, 0x68)
// OFFSET: LEGO1 0x10001090 TEMPLATE
// FUNCTION: LEGO1 0x10001090
// LegoEntity::SetWorldSpeed
// OFFSET: LEGO1 0x1000c290
// FUNCTION: LEGO1 0x1000c290
LegoEntity::~LegoEntity()
{
Destroy(TRUE);
}
// OFFSET: LEGO1 0x100105f0
// FUNCTION: LEGO1 0x100105f0
void LegoEntity::Init()
{
m_worldLocation.Fill(0);
@@ -32,19 +32,19 @@ void LegoEntity::Init()
m_unk59 = 4;
}
// OFFSET: LEGO1 0x10010650 STUB
// STUB: LEGO1 0x10010650
void LegoEntity::ResetWorldTransform(MxBool p_inVehicle)
{
// TODO
}
// OFFSET: LEGO1 0x10010790 STUB
// STUB: LEGO1 0x10010790
void LegoEntity::SetWorldTransform(Vector3Impl& p_loc, Vector3Impl& p_dir, Vector3Impl& p_up)
{
// TODO
}
// OFFSET: LEGO1 0x100107e0
// FUNCTION: LEGO1 0x100107e0
MxResult LegoEntity::Create(MxDSObject& p_dsObject)
{
m_mxEntityId = p_dsObject.GetObjectId();
@@ -53,7 +53,7 @@ MxResult LegoEntity::Create(MxDSObject& p_dsObject)
return SUCCESS;
}
// OFFSET: LEGO1 0x10010810 STUB
// STUB: LEGO1 0x10010810
void LegoEntity::Destroy(MxBool p_fromDestructor)
{
if (m_roi) {
@@ -64,7 +64,7 @@ void LegoEntity::Destroy(MxBool p_fromDestructor)
Init();
}
// OFFSET: LEGO1 0x10010880
// FUNCTION: LEGO1 0x10010880
void LegoEntity::SetWorld()
{
LegoWorld* world = GetCurrentWorld();
@@ -73,13 +73,13 @@ void LegoEntity::SetWorld()
}
}
// OFFSET: LEGO1 0x100108a0 STUB
// STUB: LEGO1 0x100108a0
void LegoEntity::SetROI(LegoROI* p_roi, MxBool p_bool1, MxBool p_bool2)
{
// TODO
}
// OFFSET: LEGO1 0x10010e10
// FUNCTION: LEGO1 0x10010e10
void LegoEntity::ParseAction(char* p_extra)
{
char copy[1024];
@@ -102,49 +102,49 @@ void LegoEntity::ParseAction(char* p_extra)
}
}
// OFFSET: LEGO1 0x10010f10 STUB
// STUB: LEGO1 0x10010f10
void LegoEntity::VTable0x34()
{
// TODO
}
// OFFSET: LEGO1 0x10011070 STUB
// STUB: LEGO1 0x10011070
void LegoEntity::VTable0x38()
{
// TODO
}
// OFFSET: LEGO1 0x10011300 STUB
// STUB: LEGO1 0x10011300
void LegoEntity::VTable0x3c()
{
// TODO
}
// OFFSET: LEGO1 0x10011360 STUB
// STUB: LEGO1 0x10011360
void LegoEntity::VTable0x40()
{
// TODO
}
// OFFSET: LEGO1 0x100113c0 STUB
// STUB: LEGO1 0x100113c0
void LegoEntity::VTable0x44()
{
// TODO
}
// OFFSET: LEGO1 0x10011420 STUB
// STUB: LEGO1 0x10011420
void LegoEntity::VTable0x48()
{
// TODO
}
// OFFSET: LEGO1 0x10011470 STUB
// STUB: LEGO1 0x10011470
void LegoEntity::VTable0x4c()
{
// TODO
}
// OFFSET: LEGO1 0x100114f0 STUB
// STUB: LEGO1 0x100114f0
MxLong LegoEntity::Notify(MxParam& p)
{
// TODO