(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -6,18 +6,18 @@
DECOMP_SIZE_ASSERT(LegoPathPresenter, 0x54);
// OFFSET: LEGO1 0x100448d0
// FUNCTION: LEGO1 0x100448d0
LegoPathPresenter::LegoPathPresenter()
{
Init();
}
// OFFSET: LEGO1 0x10044ab0
// FUNCTION: LEGO1 0x10044ab0
void LegoPathPresenter::Init()
{
}
// OFFSET: LEGO1 0x10044b40
// FUNCTION: LEGO1 0x10044b40
MxResult LegoPathPresenter::AddToManager()
{
MxResult status = FAILURE;
@@ -30,7 +30,7 @@ MxResult LegoPathPresenter::AddToManager()
return status;
}
// OFFSET: LEGO1 0x10044b70
// FUNCTION: LEGO1 0x10044b70
void LegoPathPresenter::Destroy(MxBool p_fromDestructor)
{
if (VideoManager())
@@ -45,13 +45,13 @@ void LegoPathPresenter::Destroy(MxBool p_fromDestructor)
MxMediaPresenter::Destroy(FALSE);
}
// OFFSET: LEGO1 0x10044c10
// FUNCTION: LEGO1 0x10044c10
void LegoPathPresenter::Destroy()
{
Destroy(FALSE);
}
// OFFSET: LEGO1 0x10044d40
// FUNCTION: LEGO1 0x10044d40
void LegoPathPresenter::RepeatingTickle()
{
if (this->m_action->GetDuration() == -1)
@@ -60,7 +60,7 @@ void LegoPathPresenter::RepeatingTickle()
EndAction();
}
// OFFSET: LEGO1 0x10044d60 STUB
// STUB: LEGO1 0x10044d60
void LegoPathPresenter::ParseExtra()
{
// TODO