(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -2,7 +2,7 @@
#include "mxomni.h"
// OFFSET: LEGO1 0x100acf90
// FUNCTION: LEGO1 0x100acf90
MxAtomId::MxAtomId(const char* p_str, LookupMode p_mode)
{
if (!MxOmni::GetInstance())
@@ -16,13 +16,13 @@ MxAtomId::MxAtomId(const char* p_str, LookupMode p_mode)
counter->Inc();
}
// OFFSET: LEGO1 0x100acfd0
// FUNCTION: LEGO1 0x100acfd0
MxAtomId::~MxAtomId()
{
Destroy();
}
// OFFSET: LEGO1 0x100acfe0
// FUNCTION: LEGO1 0x100acfe0
void MxAtomId::Destroy()
{
if (!m_internal)
@@ -42,7 +42,7 @@ void MxAtomId::Destroy()
counter->Dec();
}
// OFFSET: LEGO1 0x100ad1c0
// FUNCTION: LEGO1 0x100ad1c0
MxAtomId& MxAtomId::operator=(const MxAtomId& p_atomId)
{
if (m_internal)
@@ -58,7 +58,7 @@ MxAtomId& MxAtomId::operator=(const MxAtomId& p_atomId)
return *this;
}
// OFFSET: LEGO1 0x100ad210
// FUNCTION: LEGO1 0x100ad210
MxAtomIdCounter* MxAtomId::GetCounter(const char* p_str, LookupMode p_mode)
{
MxAtomId _unused;
@@ -88,7 +88,7 @@ MxAtomIdCounter* MxAtomId::GetCounter(const char* p_str, LookupMode p_mode)
return counter;
}
// OFFSET: LEGO1 0x100ad7e0
// FUNCTION: LEGO1 0x100ad7e0
void MxAtomId::Clear()
{
// Reset but do not delete MxAtomId object.