(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -26,13 +26,13 @@ inline MxLong _Abs(MxLong p_value)
return p_value > 0 ? p_value : -p_value;
}
// OFFSET: LEGO1 0x1004e0d0
// FUNCTION: LEGO1 0x1004e0d0
int MxBitmap::vtable28(int)
{
return -1;
}
// OFFSET: LEGO1 0x100bc980
// FUNCTION: LEGO1 0x100bc980
MxBitmap::MxBitmap()
{
this->m_info = NULL;
@@ -43,7 +43,7 @@ MxBitmap::MxBitmap()
this->m_palette = NULL;
}
// OFFSET: LEGO1 0x100bca10
// FUNCTION: LEGO1 0x100bca10
MxBitmap::~MxBitmap()
{
if (this->m_info)
@@ -54,7 +54,7 @@ MxBitmap::~MxBitmap()
delete m_palette;
}
// OFFSET: LEGO1 0x100bcaa0
// FUNCTION: LEGO1 0x100bcaa0
MxResult MxBitmap::SetSize(MxS32 p_width, MxS32 p_height, MxPalette* p_palette, MxBool p_isHighColor)
{
MxResult ret = FAILURE;
@@ -99,7 +99,7 @@ MxResult MxBitmap::SetSize(MxS32 p_width, MxS32 p_height, MxPalette* p_palette,
return ret;
}
// OFFSET: LEGO1 0x100bcba0
// FUNCTION: LEGO1 0x100bcba0
MxResult MxBitmap::ImportBitmapInfo(MxBITMAPINFO* p_info)
{
MxResult result = FAILURE;
@@ -133,7 +133,7 @@ MxResult MxBitmap::ImportBitmapInfo(MxBITMAPINFO* p_info)
return result;
}
// OFFSET: LEGO1 0x100bcc40
// FUNCTION: LEGO1 0x100bcc40
MxResult MxBitmap::ImportBitmap(MxBitmap* p_bitmap)
{
MxResult result = FAILURE;
@@ -168,7 +168,7 @@ MxResult MxBitmap::ImportBitmap(MxBitmap* p_bitmap)
return result;
}
// OFFSET: LEGO1 0x100bcd10
// FUNCTION: LEGO1 0x100bcd10
MxLong MxBitmap::Read(const char* p_filename)
{
MxResult result = FAILURE;
@@ -184,7 +184,7 @@ MxLong MxBitmap::Read(const char* p_filename)
return result;
}
// OFFSET: LEGO1 0x100bcd60
// FUNCTION: LEGO1 0x100bcd60
MxResult MxBitmap::LoadFile(HANDLE p_handle)
{
MxResult result = FAILURE;
@@ -231,17 +231,17 @@ MxResult MxBitmap::LoadFile(HANDLE p_handle)
return result;
}
// OFFSET: LEGO1 0x100bce70 STUB
// STUB: LEGO1 0x100bce70
void MxBitmap::vtable2c(int, int, int, int, int, int, int)
{
}
// OFFSET: LEGO1 0x100bd020 STUB
// STUB: LEGO1 0x100bd020
void MxBitmap::vtable30(int, int, int, int, int, int, int)
{
}
// OFFSET: LEGO1 0x100bd1c0
// FUNCTION: LEGO1 0x100bd1c0
MxPalette* MxBitmap::CreatePalette()
{
MxBool success = FALSE;
@@ -269,7 +269,7 @@ MxPalette* MxBitmap::CreatePalette()
return palette;
}
// OFFSET: LEGO1 0x100bd280
// FUNCTION: LEGO1 0x100bd280
void MxBitmap::ImportPalette(MxPalette* p_palette)
{
// Odd to use a switch on a boolean, but it matches.
@@ -287,7 +287,7 @@ void MxBitmap::ImportPalette(MxPalette* p_palette)
}
}
// OFFSET: LEGO1 0x100bd2d0
// FUNCTION: LEGO1 0x100bd2d0
MxResult MxBitmap::SetBitDepth(MxBool p_isHighColor)
{
MxResult ret = FAILURE;
@@ -334,7 +334,7 @@ MxResult MxBitmap::SetBitDepth(MxBool p_isHighColor)
return ret;
}
// OFFSET: LEGO1 0x100bd3e0
// FUNCTION: LEGO1 0x100bd3e0
MxResult MxBitmap::StretchBits(
HDC p_hdc,
MxS32 p_xSrc,
@@ -367,7 +367,7 @@ MxResult MxBitmap::StretchBits(
);
}
// OFFSET: LEGO1 0x100bd450
// FUNCTION: LEGO1 0x100bd450
MxResult MxBitmap::ImportColorsToPalette(RGBQUAD* p_rgbquad, MxPalette* p_palette)
{
MxResult ret = FAILURE;