(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -11,7 +11,7 @@
class MxDiskStreamProvider;
// VTABLE 0x100dd130
// VTABLE: LEGO1 0x100dd130
class MxDiskStreamProviderThread : public MxThread {
public:
// Only inlined, no offset
@@ -22,21 +22,21 @@ public:
MxResult StartWithTarget(MxDiskStreamProvider* p_target);
};
// VTABLE 0x100dd138
// VTABLE: LEGO1 0x100dd138
class MxDiskStreamProvider : public MxStreamProvider {
public:
MxDiskStreamProvider();
virtual ~MxDiskStreamProvider() override;
// OFFSET: LEGO1 0x100d1160
// FUNCTION: LEGO1 0x100d1160
inline virtual const char* ClassName() const override // vtable+0x0c
{
// 0x1010287c
// GLOBAL: LEGO1 0x1010287c
return "MxDiskStreamProvider";
}
// OFFSET: LEGO1 0x100d1170
// FUNCTION: LEGO1 0x100d1170
inline virtual MxBool IsA(const char* name) const override // vtable+0x10
{
return !strcmp(name, MxDiskStreamProvider::ClassName()) || MxStreamProvider::IsA(name);