mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 08:24:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Proposal) Adjustments to "decomp" language (#308)

Browse Source 
* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
LEGO1/mxdsmediaaction.cpp
View File

@@ -4,7 +4,7 @@
DECOMP_SIZE_ASSERT(MxDSMediaAction, 0xb8)
// OFFSET: LEGO1 0x100c8b40
// FUNCTION: LEGO1 0x100c8b40
MxDSMediaAction::MxDSMediaAction()
{
this->m_mediaSrcPath = NULL;
@@ -18,13 +18,13 @@ MxDSMediaAction::MxDSMediaAction()
this->SetType(MxDSType_MediaAction);
}
// OFFSET: LEGO1 0x100c8cf0
// FUNCTION: LEGO1 0x100c8cf0
MxDSMediaAction::~MxDSMediaAction()
{
delete[] this->m_mediaSrcPath;
}
// OFFSET: LEGO1 0x100c8d60
// FUNCTION: LEGO1 0x100c8d60
void MxDSMediaAction::CopyFrom(MxDSMediaAction& p_dsMediaAction)
{
CopyMediaSrcPath(p_dsMediaAction.m_mediaSrcPath);
@@ -36,7 +36,7 @@ void MxDSMediaAction::CopyFrom(MxDSMediaAction& p_dsMediaAction)
this->m_sustainTime = p_dsMediaAction.m_sustainTime;
}
// OFFSET: LEGO1 0x100c8dc0
// FUNCTION: LEGO1 0x100c8dc0
MxDSMediaAction& MxDSMediaAction::operator=(MxDSMediaAction& p_dsMediaAction)
{
if (this == &p_dsMediaAction)
@@ -47,7 +47,7 @@ MxDSMediaAction& MxDSMediaAction::operator=(MxDSMediaAction& p_dsMediaAction)
return *this;
}
// OFFSET: LEGO1 0x100c8e80
// FUNCTION: LEGO1 0x100c8e80
void MxDSMediaAction::CopyMediaSrcPath(const char* p_mediaSrcPath)
{
if (this->m_mediaSrcPath == p_mediaSrcPath)
@@ -64,7 +64,7 @@ void MxDSMediaAction::CopyMediaSrcPath(const char* p_mediaSrcPath)
this->m_mediaSrcPath = NULL;
}
// OFFSET: LEGO1 0x100c8f10
// FUNCTION: LEGO1 0x100c8f10
MxU32 MxDSMediaAction::GetSizeOnDisk()
{
MxU32 totalSizeOnDisk = MxDSAction::GetSizeOnDisk();
@@ -79,7 +79,7 @@ MxU32 MxDSMediaAction::GetSizeOnDisk()
return totalSizeOnDisk;
}
// OFFSET: LEGO1 0x100c8f60
// FUNCTION: LEGO1 0x100c8f60
void MxDSMediaAction::Deserialize(char** p_source, MxS16 p_unk24)
{
MxDSAction::Deserialize(p_source, p_unk24);